feat(spec): an app-declared capability token is not a platform system permission at the everyone anchor - #17811
Conversation
… permission `describeHighPrivilegeBits` treated any non-empty `systemPermissions` as a high-privilege bit, so a permission set carrying the capability token its own app declared could not be bound to the `everyone` audience anchor. The predicate now takes an optional `AnchorBindingContext` naming the capability names this stack declared (ADR-0066 D1); a token on that list is the app's own gate and is not counted as a system permission. The discriminator is provenance, not spelling. Platform capability names are never excusable, a missing list refuses exactly as before, and the D9 `guest` tier does not honour the excusal. ADR-0090 D5's offending list is revised to match. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MkQhmuuJAVDjmeWNixwDDH
…urface baselines Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MkQhmuuJAVDjmeWNixwDDH
…inor Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MkQhmuuJAVDjmeWNixwDDH
📓 Docs Drift CheckThis PR changes 1 package(s): ⛔ 1 release-owned page(s) name something this change touched. These are read-only:
What this run could not see
Coarse fallback — 136 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): Which tree this was computed onThis run read A worktree cut from an older # while this PR is open — GitHub drops the merge commit once it closes
git fetch origin e573e215c8c4f546e1c1912550ed2f15e67115e2 && git checkout e573e215c8c4f546e1c1912550ed2f15e67115e2
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin 2b08a7299cbd53edfaeaa9d949da71cc1c8471b1 f15288e14f8b963cbecc4fde2081e2678058fe61 && git checkout -B drift-repro 2b08a7299cbd53edfaeaa9d949da71cc1c8471b1 && git merge --no-ff f15288e14f8b963cbecc4fde2081e2678058fe61
node scripts/docs-audit/affected-docs.mjs --json 2b08a7299cbd53edfaeaa9d949da71cc1c8471b1
|
Seat review of head
|
The revision and the predicate change were one diff. One governed path made the whole PR human-merge-only, which is the shape the ruling wrote 「单独」 to avoid: the ADR half waits for its human, the predicate half takes ordinary landing. The revision text moves byte-identical; nothing in it claimed the predicate ships alongside it, so no sentence of it needed editing. The changeset's pointer to it is corrected to name the separate PR. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MkQhmuuJAVDjmeWNixwDDH
Contract review of head
|
| shape | verdict |
|---|---|
all 9 platform names, each declared as a bare string AND as a { name, scope:'org', managed_by:'package' } row, and carried in the set |
'system permissions' for all 9 — the floor holds over the whole set, not just the two the suite names |
declared MANAGE_USERS, set carries manage_users |
refused (exact compare; nothing folds case) |
declared composed é, set carries decomposed é |
refused (no Unicode normalization on either side) |
{ get name() {…} } returning app.tok on the first read and manage_users afterwards |
one read only (getterReads=1); manage_users still refused |
Proxy row whose name trap returns manage_users |
refused |
| iterable that yields a different value on a second pass | iterated exactly once (passes=1) |
| generator that throws mid-iteration | the throw propagates — no partial excusal is committed |
declared '__proto__' / 'constructor' / 'hasOwnProperty' beside manage_users |
manage_users refused; '__proto__' as a plain declared+carried token is excused as any other non-platform string (a Set, not an object key — no prototype reach) |
declared '' or { name: '' }, set carries '' |
refused (empty name never excusable) |
set carries new String('app.tok'), null, or { name: 'app.tok' } while app.tok is declared |
refused (non-string token never excused) |
context = null / 'str' / { declaredCapabilities: null } / {} / [] |
the pre-change verdict |
the caller hands the set's OWN systemPermissions as the list |
manage_users still refused — the floor does not depend on where the list came from |
system_permissions JSON-string column carrying a platform name, declared |
refused |
a declared token beside VAMA / allowDelete / allowExport |
View/Modify All Data on 'a' / delete/purge/transfer on 'a' / bulk export on 'a' — the excusal reaches only the systemPermissions branch |
A variant of a platform name that differs by case, a leading space, or a zero-width character IS excusable when it is both declared and carried (' manage_users' → null). That is not a laundering path: the runtime grants systemPermissions by exact .includes(p) (packages/core/src/security/resolve-authz-context.ts:934, :987) and PLATFORM_ADMIN_ONLY_CAPABILITIES (plugin-security/src/security-plugin.ts:169) is a strict subset of PLATFORM_CAPABILITY_NAMES, so such a token names no platform power anywhere it would be honoured. Recorded as a reading, not a finding.
2. Fails-closed, byte-identical to the pre-change artifact — differential, not reasoning. Merge-base 482d34d60c built to its own dist in a second worktree (JS-only, exit 0; base arity read 1 / 2). 20,000 generated definitions (random systemPermissions arrays mixing platform names, app tokens, empty strings, non-strings; JSON-string columns; malformed JSON; non-array values; object bits in both spellings and as JSON strings; null/scalar defs), each judged on base and on head under no context, {}, { declaredCapabilities: [] }, and a list whose names never occur in any definition, for describeHighPrivilegeBits and for describeAnchorForbiddenBits at both anchors — verdict strings compared exactly, throws included:
defs=20000 base refused=11652 base null=8348 DIFFS=0
LIT CONTROL base="system permissions" head(with excusing ctx)=null -> harness can see a difference
3. The platform floor. The floor reads PLATFORM_CAPABILITY_NAMES (high-privilege.ts:74), which is derived from PLATFORM_CAPABILITIES (capabilities.ts:82-84), not transcribed. The suite pins has('manage_users'), has('setup.access') true and has('clm_requester.access') false against the exported set itself, so a rename would turn the pin red rather than empty the floor. Probe 1's whole-set row covers the seven names the suite does not spell.
4. Is the widening exactly the ruling's? Ruling 5615806616: 「多收一个输入——本 stack 声明过的应用能力名单——名单内的名字不计为系统权限」, with the ADR list 「平台系统权限;带 package provenance 的应用声明 capability 令牌不计」. The diff accepts a name on the list minus the platform floor (narrower, and the ruling's own ADR wording), only for string tokens (narrower), and not at guest (narrower). Accepting { name } rows beside bare strings is an input-shape convenience that widens nothing — the name is read once and judged identically. Nothing outside the ruling was found.
5. The guest tier, in the code. high-privilege.ts:195: describeHighPrivilegeBits(def, anchor === 'guest' ? undefined : context). Probed on dist: describeAnchorForbiddenBits({systemPermissions:['app.tok']}, 'guest', {declaredCapabilities:['app.tok']}) → 'system permissions', with the lit control ({objects:{a:{allowRead:true}}}, 'guest') → null. Ablation leg C below is the proof the pin is aimed at that line.
6. The two regenerated snapshots, against a fresh build of this head: pnpm --filter @objectstack/spec check:api-surface → public API surface + factory signatures unchanged ✓, exit 0 (reads dist/**/*.d.ts and refuses a stale dist); check:export-origins → self-test green then 5167 exports across 17 entry points resolve exactly as recorded, exit 0; check:generated → All 15 generated artifacts are up to date, exit 0. The diff against the merge-base is one added row in each file (AnchorBindingContext (interface) / src/security/high-privilege.ts#AnchorBindingContext (interface)), and regeneration reproduces it. Not hand-edited.
7. Changeset grade. AGENTS.md (line 1043): "A PR that declares Clause-②: yes takes at least minor". minor is the floor for this declaration, so the grade is right; that no live caller passes the argument this release does not lower it. Shipped-ness re-measured on the full build: declaredCapabilities in 4 built files, appDeclaredCapabilityNames in 2, positive control describeHighPrivilegeBits in 4, dark control 0, AnchorBindingContext present in 2 .d.ts — dist is in files[].
8. Suite non-vacuity, by ablation (script with trap … EXIT INT TERM, absolute paths, git hash-object before/after each leg; the mutation's presence on disk proven by an occurrence count before each run):
HEAD blob for the file: cf047ce9a120763e4c498bcf844b1c3095dbba20
LEG A delete the excusal (unexcused = sys) -> 6 failed | 9 passed (the 4 acceptance pins + `everyone` binding + the other-D5-bits case, exactly the 6 the round reported)
LEG B delete the platform floor -> 3 failed | 12 passed (exactly the 3 floor pins: platform name declared / dotted platform name declared / mixed set)
LEG C make guest honour the excusal -> 1 failed | 14 passed (exactly the guest pin)
LEG D no mutation (control) -> 15 passed
RESTORE hash-object after=cf047ce9a120763e4c498bcf844b1c3095dbba20 before=cf047ce9a120763e4c498bcf844b1c3095dbba20 ; git status on the file: clean
9. Unedited consumers. git diff 482d34d60c 55dc4ac6 -- packages/plugins/plugin-security packages/lint is empty. Run against the freshly built spec: audience-anchor-set-claims.pin.test.ts (the pin that machine-reads this function's JSDoc) 7 passed; validate-security-posture.test.ts 122 passed. plugin-security/src/audience-anchors.test.ts (13 of the 20 plugin-security tests the round cites) never loaded in the review worktree — Failed to resolve entry for package "@objectstack/metadata-core", an unbuilt sibling in the whole-repo closure; turbo run build --filter='@objectstack/plugin-security^...' was still in the spec DTS pass at posting time and wrote no exit line. It would have shown whether the runtime anchor-gate tests still pass against the changed predicate with the old arity; the differential in item 2 (0 diffs over 20,000 definitions at the old arity, both anchors) is the reading that covers the same question from the other side, and the JSDoc pin file did load and pass. The lint side cleared: validate-security-posture.runtime-surface.test.ts loaded once @objectstack/sdui-parser was built — lint total 2 files / 139 passed, exit 0.
10. Record. Ruling 5615806616 (director seat, batch #110 item 1, carrying 「17189 同意,但是同时评估是否需要改进skills」) and ordering note 5617614086 read in full, with all 12 card comments and both PR comments. Step ② is correctly absent (the ordering note says 跟随). The ADR half is #17814 (draft, governed, one file, human merge) — the sibling PR body's merge-order flag stands: nothing mechanical orders #17814 before this one, and the seat decides that, not this review. check-governed-merges was not re-run here; the seat's 0/3 pair on the split heads is on the card.
Findings
F1 — non-binding. AnchorBindingContext.declaredCapabilities is typed Iterable<string | {…}> (high-privilege.ts:50), and a bare string satisfies that type. A caller that passes declaredCapabilities: 'clm_requester.access' instead of ['clm_requester.access'] compiles, and the predicate then iterates the string character by character:
declaredCapabilities: "app.tok" — token "app.tok" -> "system permissions" (the intended token is NOT excused: over-refusal)
declaredCapabilities: "app.tok" — token "a" -> null (single-character tokens ARE excused)
No platform capability is a single character, so this cannot reach the floor; the error direction for the intended token is over-refusal. It is a footgun for the step-② callers rather than a bypass. Suggested for step ② (or a follow-up here): if (typeof declared === 'string') return undefined; at :63, or narrow the type to ReadonlyArray<…> | ReadonlySet<…>.
F2 — non-binding, observation. describeAnchorForbiddenBits treats any anchor other than the literal 'guest' as the everyone tier — that else-branch pre-dates this PR — so an out-of-type spelling such as 'Guest' now receives the excusal when a context is passed (probed: ('Guest', ctx) → null; ('Guest') with no context → refused, as before). Unreachable from both live callers: security-plugin.ts:5356 continues unless positionName is exactly everyone/guest, and suggested-audience-bindings.ts sets anchor from EVERYONE_POSITION (:254) and re-matches it (:791). Recorded so that a future caller with a free-form anchor does not inherit it silently.
F3 — non-binding, text. The changeset says declaredCapabilities and appDeclaredCapabilityNames "each occur in 2 built files". On a full build (JS + DTS) the first reads 4 (the .d.ts/.d.mts carry the interface field) and the positive control moves 2 → 4 with it; the second stays 2 (a non-exported function has no declaration). The claim the sentence makes — that the change ships — holds either way; the numbers are build-mode-dependent. Not worth a re-spin on its own.
What this verdict does not do
⛔ No label written, stripped or changed; ⛔ the PR stays draft, not enqueued, no auto-merge, no approving review; ⛔ nothing pushed. The needs:contract-review carrier on this PR and on card #17189 is the seat's to lift on this record.
Generated by Claude Code
Seat adoption of the at-tier verdict — PASS_WITH_FINDINGS accepted. ⛔ The carrier stays hung for now, and this comment says exactly why.
⭐ Tier verified by this seat, from the transcript — ⛔ not from the reviewer's self-report
⇒ the verdict ran at the contract-review tier and is adoptable. ⛔ Had any row read otherwise it would be void whole, not partially salvaged. What the review measured, accepted as read41 adversarial probes on the built head artifact — case folding, Unicode, getters, ⭐ The reviewer also declared what it could NOT measure rather than folding it into the green: 13 of one consumer suite's 20 cases never loaded ( The three non-binding findings — dispositions
Why the carrier is NOT coming off yetTwo reasons, and they are separate:
⛔ No label was changed by this comment. ⛔ The PR stays draft. Generated by Claude Code |
The one NOT MEASURED line in the at-tier verdict has since been measured — green, and the verdict is unchanged
Item 9 of verdict ⇒ every consumer the round cited is now measured green against a freshly built spec of head
⛔ Still held, unchanged by this: the carrier stays hung until the scoped re-review of the F3 changeset correction is on record, and this PR is not armed until PR #17814 is merged by hand. Generated by Claude Code |
… build state The measurement paragraph read "each occur in 2 built files". Both numbers were taken against a `dist` that had no declaration files: a background build was rebuilding the package at the time and had emitted JS but not DTS. Every figure in that paragraph was the JS-only reading, the negative control included. Re-measured on a clean full build of this head — empty `dist`, then both build passes, 34/34 declaration files emitted, both input hashes matching `src`: `declaredCapabilities` reaches 4 files and `describeHighPrivilegeBits` 4, while `AnchorBindingContext` (a type) reaches only the two declaration files and `appDeclaredCapabilityNames` (module-private) only the two JS files. The paragraph now states the build state, because it changes the answer. The negative control was also wrong, and not only in its number: `The platform floor is absolute` is in this predicate's own JSDoc as well as in the ADR, so it was never ADR-unique and reads 2. It is replaced by a sentence the source does not carry, which reads 0. The conclusion is unchanged: the change ships, so a changeset is owed. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MkQhmuuJAVDjmeWNixwDDH
Scoped re-review of head
|
| identifier | changeset says | read (files under dist containing the literal) |
|---|---|---|
declaredCapabilities |
4 | 4 — security/index.js, security/index.mjs, security/index.d.ts, security/index.d.mts |
AnchorBindingContext |
2 | 2 — security/index.d.ts, security/index.d.mts (declarations only) |
appDeclaredCapabilityNames |
2 | 2 — security/index.js, security/index.mjs (JS only) |
describeHighPrivilegeBits (positive control) |
4 | 4 — the same four security/ files |
dark control zzqx_no_such_identifier_17811 |
— | 0 |
Every count in the changeset table reproduces. Cross-check: the sibling worktree at 55dc4ac6 (identical packages/spec tree, its own earlier full build, stamps e6eca021… both present) reads the same 4 / 2 / 2 / 4.
The negative control, in both directions
- Absent from the artifact:
As first written, the bullet above made→ 0 files under the builtdist(same run as the table above). It is also absent from the source tree off15288e1underpackages/spec(git grep→ 0 files), which is why it cannot reachdiston any build mode — the property the old control lacked. - Present where claimed: on PR docs(adr): ADR-0090 D5 offending bits are platform system permissions, not any systemPermissions #17814's branch (
origin/pr/17814=a8dfc166, one changed file vs its merge base)git grep -Ffinds it in exactly 1 file,docs/adr/0090-permission-model-v2-concept-convergence.md:252.docs/adrappears in nopackage.jsonfiles[]atf15288e1(70 manifests with afiles[], 0 hits). - The old control was fake for the reason the changeset now gives:
The platform floor is absolutereads 2 on the full build (security/index.d.ts,security/index.d.mts) — it is inpackages/spec/src/security/high-privilege.ts:130(JSDoc, emitted into the declarations) and in the docs(adr): ADR-0090 D5 offending bits are platform system permissions, not any systemPermissions #17814 ADR at:266. On a JS-only dist it reads 0. The replacement is a real control.
PR body cross-check
The body's Verification bullet carries the same counts and the same control correction as the changeset (4 / 4 / 2 / 2, negative control 0, The platform floor is absolute explained as reading 2) and names the same build state. Changeset and body agree.
Findings
N1 — non-binding (PR body text; does not ship). The body's trailing Governed surface footer still reads: check-governed-merges --test on this PR's final file list exits 3 (GOVERNED) … Draft only. That is pre-split text. The body's own second paragraph says the five-file list exits 0 (NOT governed), and measured on f15288e1:
$ node scripts/pm/check-governed-merges.mjs --test <the PR's five files>
governed-surface predicate: 0 of 5 path(s) hit the register … NOT governed EXIT=0
$ … --test <changeset> <high-privilege.ts> docs/adr/0090-permission-model-v2-concept-convergence.md (control)
EXIT=3
The PR's file list (git diff --name-only 482d34d60c f15288e1) is the five files, no docs/adr. The footer contradicts the body's own text and the measurement; it should be dropped or rewritten to say NOT governed. (The PR still stays draft for the merge-order reason the seat recorded — that is a separate, unaffected hold.)
N2 — non-binding (changeset wording). The table's where column reads security/index.js, index.mjs, index.d.ts, index.d.mts. Only the first carries the directory; taken literally the other three name the root-level entry files, which read 0 for declaredCapabilities (dist/index.js, index.mjs, index.d.ts, index.d.mts — all 0). All four hits are under security/. Since changeset prose ships into CHANGELOG.md, spelling security/ on each is worth one word each; the count is right either way.
Does the earlier PASS_WITH_FINDINGS on 55dc4ac6 still describe this head?
Yes. Evidence: packages/spec at f15288e1 is tree-identical to 55dc4ac6 and to a21ad008 (a3dfe3c0…), the only changed bytes are the changeset file, and the corrected prose in that file is measured true on a build whose completion is proven by the wrapper's own END rc=0 / VERDICT BUILD_OK, 34/34 declarations, and stamps equal to the recomputed source hash. F3 of 5644839802 is thereby addressed; F1 and F2 are unchanged and remain non-binding.
⛔ No label written, stripped or changed; ⛔ the PR stays draft, not enqueued, no auto-merge, no approving review; ⛔ nothing pushed. needs:contract-review on this PR and on card #17189 is the seat's to lift on this record.
Generated by Claude Code
Scoped re-review adopted — carrier lifted from both carriers. ⛔ The PR is still NOT armed, and that is a separate hold.
⭐ Tier verified by this seat from the transcript, exhaustively⇒ adoptable. ⛔ Had any row read otherwise the verdict would be void whole. The load-bearing reading, and why it is the one that mattered
The corrected counts reproduce on a build the reviewer confirmed complete before reading it (wrapper ⭐ And the replacement negative control is real in both directions: absent from built The two non-binding findings — dispositions
Carrier lifted, and what is NOT thereby cleared
⛔ This PR is still not armed, for a reason that has nothing to do with review: after the split, nothing mechanical keeps the code half behind the ADR half, and the maintainer's ordering note is verbatim 「我们的项目以objectstack 协议为准,文档应该以实际实现为准。协议不正确的应该先修改协议。」 ⇒ the seat holds PR #17811 until PR #17814 is merged by hand. Landing the code first would leave a window in which this file's JSDoc describes a D5 list narrower than the published ADR still states. Generated by Claude Code |
Part of #17189 — step ① of the ruled order only. ⛔ This PR does not discharge the card and ⛔ carries no closing keyword: the
plugin-securityboot refusal and the@objectstack/lintsecurity-anchor-high-privilegerule are step ②, deliberately untouched here.Sibling: #17814 carries the ADR-0090 D5 revision alone, as its own governed draft PR. The two were one PR until the seat review of head
a21ad008; they are split on the ruling's own instruction — 「ADR-0090 修订单独受管 PR」 and 「ADR 修订走独立受管 PR(draft、请审、人合)」 (#17189 comment5615806616), which the triage seat had already spelled 「⛔ 不得与代码同 diff」. Measured:check-governed-merges --teston this PR's five-file list exits 0 (NOT governed); add the ADR back and the same predicate exits 3 (GOVERNED). Bundled, one governed path made the predicate change human-merge-only too. ⭐ Both halves are phase ① and ⛔ neither is dropped.5617614086) puts the protocol first: 「协议不正确的应该先修改协议。」 The ADR half is human-merge-only and this half is not, so nothing mechanical keeps this one from landing first. If that order matters, merge #17814 before this is enqueued — flagging rather than deciding, since a draft PR cannot enforce it.capabilitywithscope: 'org'counts as a high-privilege bit, so a set carrying only app capability tokens cannot bind to theeveryoneanchor #17189 comment5615806616) declared this value in advance, in its 执行 line, and a declaration made in advance is not overruled by a reading of the diff. My earliernoapplied a narrower test ("no new key on a published payload") than clause ② asks. The diff agrees with the ruling three ways: a permission set that was refused is now accepted;packages/spec/api-surface/security.jsonandexport-origins/security.jsonwere regenerated, so the published-surface snapshots moved; and the changeset's own rationale says "a widened accept set".The defect
describeHighPrivilegeBitscounted any non-emptysystemPermissionsas a high-privilege bit, so a permission set carrying the capability token its own app declared could not be bound to theeveryoneaudience anchor.Re-confirmed on this branch's own base (
482d34d60c) against a freshly builtdist, with a lit control:{ objects: { a: { allowRead: true } } }and{ systemPermissions: [] }both returnednullin the same run, so the instrument could have come back the other way. The shipped predicate's arity was1— there was no channel through which the distinction could have arrived.The change
Both predicates take a new optional
AnchorBindingContextnaming the capability names this stack declared (ADR-0066 D1:defineCapability, enteringsys_capabilitywithmanaged_by: 'package'+package_idprovenance). A token on that list is the app's own gate and is not counted as a system permission.The discriminator is provenance, not spelling, and that is the point rather than a convenience. The rejected alternative was a naming-syntax rule (dotted ⇒ app token). It misjudges in silence in both directions:
setup.accessis a platform capability that is dotted today, and nothing stops an app declaring an undotted token. A syntax rule guesses; the declared list is a fact the caller can read, and only the caller can read it — the predicate is pure and synchronous by contract, and a set may never vouch for its own tokens.Two properties keep the widening honest, both fail-closed:
PLATFORM_CAPABILITY_NAMESstays high-privilege however it is declared, so a package cannot laundermanage_userspast the gate by declaring a capability of that name.guest(ADR-0090 D9) does not honour the excusal at all: D5 speaks for authenticated members, and conferring an app's own gate on anonymous visitors is a different act that ruling (i) did not decide.Both directions tested
packages/spec/src/security/high-privilege.test.ts, 15 cases. Newly accepted: a set whose only system permission is a declared token, in the authored shape, thesys_permission_setJSON-string column shape, declaration/registry row entries, and the filing consumer's real shape. Still refused: a platform permission even when a package declares that name;setup.access— dotted, declared, still refused; any undeclared token; every token when no list is passed; a mixed set (one unexcused token refuses the whole set); non-string entries; every other D5 bit (VAMA, delete/transfer, bulk export); and the wholeguesttier.Ablation (both legs: mutate, prove it reached disk with an occurrence count on the mutated text, run, restore; restore verified byte-identical to the
HEADblob withgit diff HEADempty):unexcused = sys)The first leg reddened one test more than predicted:
leaves every other D5 bit refusingcarries both a declared token and an object bit, so without the excusal thesystemPermissionsbranch answers before the object branch is reached. Reported as observed, not as predicted.ADR-0090 D5
The revision is not optional here. D5's last bullet said any
systemPermissions, and the code implemented that literally — so the protocol, not the implementation, was the thing that was wrong. Per the maintainer's ordering, verbatim:The bullet now reads "a⚠️ Until #17814 merges, this file's own JSDoc describes a D5 list narrower than the published ADR still states; that window is the split's cost, and the merge-order note above is how to close it.
systemPermissionsentry naming a platform system permission", with a dated revision note recording the two token kinds, the three fail-closed boundaries, why the spelling rule was rejected, thatguestis untouched, and that the callers keep the pre-revision behaviour until they supply the list. That change now lives in #17814, byte-identical to what stood here ona21ad008— verified by diffing the two branches' copies of the file. Removing the code hunks from it made no sentence of it false: nothing in the note ever claimed the predicate ships alongside it.Verification
pnpm --filter @objectstack/spec test— 472 files / 13365 tests passed.pnpm --filter @objectstack/spec typecheck— passed (tsc --noEmit, scripts, and the test-layer ledger; the new test file compiles clean and is not added totest-typecheck-debt.json).plugin-securityaudience-anchors.test.ts+audience-anchor-set-claims.pin.test.ts(20 passed — including the pin that reads this very JSDoc block),@objectstack/lintvalidate-security-posture*.test.ts(139 passed).scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstack): 83 commands — 79 exit 0, and four exit 3 = PREREQUISITE NOT MET (check:dual-build-cjs-loads,check:lean-entry-closure,check:type-check-debt,check:doc-formula-expressions). All four read a whole-repo build; the closure build was OOM-killed on this shared box at 11m52s. They are NOT MEASURED, ⛔ not green, and are declared to CI. Exactly six commands left this PR's family when the ADR did —check-adr-links,check-adr-symbol-anchors(each with its--self-test),check:adr-anchorsandcheck:pm-governed-merges— and all six are run green on docs(adr): ADR-0090 D5 offending bits are platform system permissions, not any systemPermissions #17814 instead, which derives 18 commands of its own (17 green, the samecheck:doc-formula-expressionsat 3).git diff a21ad008 HEAD -- packages/specis empty. Only the ADR file and one changeset sentence moved (the sentence said the revision landed "in the same PR", which the split made false; it now names docs(adr): ADR-0090 D5 offending bits are platform system permissions, not any systemPermissions #17814).eslint . --no-inline-configover the whole repo — exit 0, measured ona21ad008, whosepackages/spectree is byte-identical to this head. No narrowing claimed.api-surface/security.json,export-origins/security.json(one line each, the new interface).check:generatedgreen.dist, thenpnpm --filter @objectstack/spec buildwith both passes, exit 0,check-dts-emitted34/34, and bothdist/.build-input-hash*matchingsrc.declaredCapabilitiesreaches 4 files (security/index.js,index.mjs,index.d.ts,index.d.mts) and the positive controldescribeHighPrivilegeBits4;AnchorBindingContext2 (declarations only - it is a type) andappDeclaredCapabilityNames2 (JS only - it is module-private). Negative control: a sentence occurring only in the ADR revision reads 0, anddocs/adr/**is in no package'sfiles[].The platform floor is absoluteis in this predicate's own JSDoc as well as in the ADR, so it was never ADR-unique and reads 2, not 0, once declarations exist. Both the number and the control are corrected, and the changeset now names the build state, because the build state is what changes the answer. The conclusion it supports - that a changeset is owed - never moved.git diffoverpackages/plugins/plugin-securityandpackages/lintagainst the merge base is empty.维护者速读(草稿)
改了什么 — 应用自己声明的「门牌」不再被当成平台系统权限。应用现在可以把「全体员工都持有」的权限集绑到
everyone,即使这个集合带着它自己导航要读的那张门牌。平台权限(manage_users一类)的保护一点没松。本 PR 同时按裁决修订了 ADR-0090 D5 的清单——协议先改,实现跟上。为什么改 — 具名下游
objectstack-ai/hotclm被这条规则挡住:它无法表达「全体员工」,只能把权限集逐一绑到七个岗位,再由管理员为每个没有岗位的员工手工授予;每一个新入职都是一次手工步骤,永远。该仓维护者已裁定保留这个 workaround 等本修。风险与代价(含回滚) — 本次发布没有任何已有行为变化:所有调用方仍用旧参数调用,不传名单时判定与改前逐字一致。风险集中在第二步(
plugin-security与lint开始传名单)落地时,而不是现在。误判方向是「多拒」不是「多放」:名单缺失即拒绝。平台权限有绝对下限——应用声明一个叫manage_users的能力也洗不白它。guest(匿名访客)这一档完全不放宽。回滚成本低:本 PR 是一个可选参数加一份文档修订,git revert即可,无数据迁移、无存储格式变化。席位意见 — (留给维护者)
你要做的 — 一、确认 D5 修订的措辞就是您要的协议(这是受管面,需要您人工合并)。二、确认「应用声明过的能力可以发给全体员工」这条安全姿态判断——本 PR 只按已声明的出处区分,不按
scope: 'org'再收窄一层;若您要求更窄的判据,说一声,第二步的调用方过滤一下名单即可,谓词不用改。docs/adr/0090-…,check-governed-merges --teston its file list exited 3 (GOVERNED). It no longer carries it: re-measured on the five-file list at 2026-09-12T09:5xZ the same predicate exits 0 — NOT governed, with the ADR appended as the control exiting 3. ⇒ ordinary queue landing applies to this PR, and the human-merge rule applies to #17814 instead. ⛔ Still not armed, for a different reason: the maintainer's ordering note puts the protocol first, so the seat holds this PR until #17814 is merged by hand.Generated by Claude Code
Generated by Claude Code