docs(spec): correct ReportChart xAxis/yAxis semantics; mark dead report surface (#1890)#3441
Merged
Merged
Conversation
…rt surface (#1890) Closes the report residual of the ADR-0021 analytics migration. The dataset-bound report chart already renders (objectui DatasetReportRenderer plots chart.xAxis/yAxis as the bound dataset's dimension/measure via useDatasetRows; Studio ReportDefaultInspector picks them from the dataset catalogs), but the spec describe() still called them raw fields. - ReportChart.xAxis/yAxis describe now states dataset dimension/measure names. - ReportChart.groupBy marked [EXPERIMENTAL — not enforced] (dataset renderer never reads it; only the legacy ReportViewer fallback did). - ReportColumnSchema/ReportGroupingSchema marked @deprecated — unreferenced by the single-form report shape; kept only as public type exports pending a governed prune. Docs regenerated. No shape/parse-behavior change; no export removed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CMaDBhnZEUu1fcw8Rvo6Yq
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
documentation
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 104 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
os-zhuang
marked this pull request as ready for review
July 24, 2026 15:07
This was referenced Jul 24, 2026
os-zhuang
added a commit
that referenced
this pull request
Jul 25, 2026
…#3462) (#3474) Closes the systemic anti-drift gap for two authorable UI types (umbrella #1878). Both were registered but ungoverned, so their property liveness wasn't CI-checked. - Add liveness/report.json (20 live / 2 dead) and dashboard.json (18 live / 2 dead), each property classified with an objectui consumer. - Re-verification corrected stale 2026-06 audit findings: report `chart` is live (DatasetReportChart via useDatasetRows, #1890/#3441); dashboard globalFilters/dateRange live (#2501); title↔label fixed (objectui#2806); ADR-0021 widget migration shipped (#3251). Only aria/performance dead. - Add both to GOVERNED in check-liveness.mts; gate green; README table + rollout list updated. webhook (third type in #3462) deferred — not a registered metadata type; rides with the disconnect decision in #3461. No spec shape/behavior change (ledger + gate config only). Claude-Session: https://claude.ai/code/session_01CMaDBhnZEUu1fcw8Rvo6Yq Co-authored-by: Claude <noreply@anthropic.com>
os-zhuang
added a commit
that referenced
this pull request
Jul 25, 2026
…ts + unread report chart groupBy (#3463) (#3488) Deep-cleanup close-out of the report-chart disposition (follow-up to #3441, umbrella #1878/#1890). After the ADR-0021 single-form cutover a dataset-bound report expresses columns/grouping as dataset measure/dimension name arrays (`values`/`rows`/`columns` = `z.array(z.string())`), so ReportColumnSchema / ReportGroupingSchema were referenced by no schema body — they survived only as public type exports and were marked @deprecated in #3441. - Remove ReportColumnSchema / ReportGroupingSchema and their type exports (ReportColumn / ReportGrouping / ReportColumnInput / ReportGroupingInput) from @objectstack/spec/ui; drop the now-orphan ResponsiveConfigSchema import. - Remove ReportChart.groupBy — the [EXPERIMENTAL — not enforced] series-split field from #3441. The dataset-bound DatasetReportRenderer plots a single xAxis×yAxis series and never read it; only the retired legacy ReportViewer fallback consumed a top-level groupBy. ReportChartSchema is non-strict, so residual chart.groupBy in stored metadata is silently stripped on parse. - Drop manifest ratchet keys ui/ReportColumn, ui/ReportGrouping; regenerate content/docs/references/ui/report.mdx and the spec API-surface snapshot. No first-party or example report authored these objects or chart.groupBy. Ships as minor per the launch-window breaking-as-minor policy; changeset carries the FROM→TO migration. Co-authored-by: Jack Zhuang <277994282+os-zhuang@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Closes the report residual of the ADR-0021 analytics migration (#1890,
umbrella #1878). Investigation overturned the audit's premise: the dataset-bound
report chart is not un-migrated — objectui's
DatasetReportRendereralreadyplots
chart.xAxis/yAxisas the bound dataset's dimension/measure viauseDatasetRows, and the StudioReportDefaultInspectorsources them from thedataset's dimension/measure catalogs. The old
ReportViewer(legacyxAxisField/yAxisFields) is only a fallback.The genuine leftovers were spec-accuracy, not a renderer migration:
ReportChart.xAxis/yAxis—.describe()still said raw "Grouping field" /"Summary field", which misleads an author/AI into naming object fields instead of
the dataset dimension/measure names the renderer requires. Corrected.
ReportChart.groupBy— marked[EXPERIMENTAL — not enforced]: thedataset renderer plots a single
xAxis×yAxisseries and never reads it.ReportColumnSchema/ReportGroupingSchema— marked@deprecated:unreferenced by the single-form report shape (columns/grouping are dataset
measure/dimension name arrays). Left in place (breaking to remove — objectui
re-exports them as
SpecReportColumn/SpecReportGrouping); flagged for afuture governed prune.
Testing
check:spec-changesgreen;tsc --noEmitgreen;gen:api-surfacereproduces the checked-in snapshot (no export removed).ui/report.mdx).Note for maintainers
The deeper disposition — enrolling
reportin the livenessGOVERNEDset (it'sregistered/authorable but not yet governed, so no ledger), and pruning the
ReportColumn/ReportGroupingexports + retiring the legacyReportViewer— isleft as a follow-up; this PR is the non-breaking accuracy fix.
Part of umbrella #1878.
🤖 Generated with Claude Code
Generated by Claude Code