Skip to content

fix(studio): approver Type dropdown drops deprecated role, membership-tier picker (framework #3133)#2643

Merged
os-zhuang merged 1 commit into
mainfrom
fix/approver-membership-tier-picker
Jul 17, 2026
Merged

fix(studio): approver Type dropdown drops deprecated role, membership-tier picker (framework #3133)#2643
os-zhuang merged 1 commit into
mainfrom
fix/approver-membership-tier-picker

Conversation

@os-zhuang

Copy link
Copy Markdown
Contributor

The objectui half of framework #3133 (framework PR objectstack-ai/framework#3137). Both gaps were found by dogfooding the running console, not by reading code — and the first one is exactly the kind of thing static reading misses.

Context

Framework #3137 renames the role approver type to org_membership_level (role kept as a deprecated alias) and, crucially, publishes an xEnumDeprecated annotation on the node configSchema so pickers can drop the deprecated spelling. This PR makes Studio honor it — and fixes a second, older gap along the way.

1. The approver Type was silently free text (the real bug)

FlowObjectListField handled boolean, reference, expression, and else → plain <Input>. There was no select branch. The approver Type column is kind: 'select' (derived from the spec enum by json-schema-to-fields), so it fell through to a free-text input: the computed optionsincluding framework's xEnumDeprecated filtering — were thrown away, and the author got no dropdown and no guidance at all.

This is why the rename alone wasn't enough: I'd wired xEnumDeprecated through enumOptions, and it was inert, because nothing rendered the options. Only driving the real designer in a browser revealed it.

Fix: added the select branch — a real dropdown from col.options. A stored value no longer in the options (a 15.x role row) still renders, flagged (deprecated), so editing a legacy row can't silently blank it. That mirrors the framework runtime's keep-the-authored-spelling decision.

2. The membership-tier picker called a deleted metadata type

KIND_TO_META_TYPE.role = 'role'client.list('role'), but ADR-0090 D3 deleted the role metadata type. The call returned nothing, so the Value box degraded to free text — the picker was already dead. Replaced with a fixed owner/admin/member enum (org-membership-level kind). Both role and org_membership_level map to it, so a stored legacy row still renders its picker.

Also

  • json-schema-to-fields threads xEnumDeprecated from the schema into enumOptions on both the top-level and objectList-column paths.
  • The hardcoded fallback config (flow-node-config.ts) and the ReferenceKind union follow the rename (the fallback objectList also renders free text until a backend is present, so this is belt-and-suspenders).

Verification — driven in the browser against a live backend

Ran the console against a framework backend on the #3133 branch, created a writable package + flow + approval node, and opened the real approver Type dropdown:

["User","Org Membership Level","Position","Team","Department","Manager","Field","Queue"]
containsRole: false · containsOrgMembership: true

Role is gone, through the entire stack: framework spec → published configSchema over HTTP → objectui's converter → the rendered dropdown.

  • New DOM test FlowObjectListField.select.test.tsx (3): renders a select column as a combobox, offers no role, and keeps a stored deprecated value visible+flagged.
  • json-schema-to-fields.test.ts updated to the new contract (options exclude role; picker map keeps role → org-membership-level).
  • Full suite: 564 files / 6858 tests pass (+1 file, +3). type-check clean; changed files lint clean.

Merge order

Framework #3137 should land (or at least be published to the version objectui resolves) so the backend actually emits xEnumDeprecated. Until then this PR is inert-but-safe: no xEnumDeprecated → dropdown simply shows all enum members, exactly as before, and gap #2 (the dead picker) is fixed regardless.

🤖 Generated with Claude Code

…ip-tier picker (framework #3133)

Two objectui-side gaps that let the ADR-0090 D3 approver `role` trap survive in
the Studio flow designer, both found by dogfooding the running console.

1. `FlowObjectListField` had no `select` branch. An objectList column of kind
   `select` — which the approver `Type` is, derived from the spec enum — fell
   through to a plain `<Input>`. So the Type field was FREE TEXT: the options
   (and framework's ADR-0090 D3 `xEnumDeprecated` filtering that drops `role`)
   were computed and thrown away, and the author got no guidance at all.
   Added the branch: a real dropdown from `col.options`, honoring
   `xEnumDeprecated`. A STORED value no longer in the options (a 15.x `role`
   row) still renders, flagged `(deprecated)`, so editing a legacy row can't
   silently blank it — mirroring the framework runtime's keep-authored-spelling
   decision.

2. The `role`/`org-membership-level` reference picker called
   `client.list('role')` — a metadata type ADR-0090 D3 DELETED. It returned
   nothing, so the Value box degraded to free text. Replaced with a fixed
   owner/admin/member enum; `role` and `org_membership_level` both map to the
   new `org-membership-level` picker kind so a stored legacy row still renders.

`json-schema-to-fields` now threads `xEnumDeprecated` from the schema into
`enumOptions` (both the top-level and objectList-column paths). The hardcoded
fallback config and the `ReferenceKind` union follow the rename.

Verified end to end in the browser against a framework backend on the #3133
branch: the live approver Type dropdown shows
[User, Org Membership Level, Position, Team, Department, Manager, Field, Queue]
— no "Role".

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@vercel

vercel Bot commented Jul 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
objectui Ignored Ignored Jul 17, 2026 3:18pm

Request Review

@github-actions github-actions Bot added the tests label Jul 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Main entry (gzip) 28.1 KB 350 KB
Entry file index-Bf6T1lu2.js
Status PASS

📦 Bundle Size Report

Package Size Gzipped
app-shell (index.js) 8.17KB 2.95KB
app-shell (runtime-config.js) 7.42KB 2.32KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 7.57KB 2.97KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 1.17KB 0.53KB
auth (AuthProvider.js) 21.70KB 4.21KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.12KB 3.41KB
auth (LoginForm.js) 17.86KB 5.29KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.43KB 2.09KB
auth (SocialSignInButtons.js) 9.60KB 3.89KB
auth (UserMenu.js) 3.40KB 1.22KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 33.74KB 8.53KB
auth (createAuthenticatedFetch.js) 3.93KB 1.55KB
auth (index.js) 1.83KB 0.79KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 4.86KB 0.85KB
auth (useIsWorkspaceAdmin.js) 1.61KB 0.85KB
collaboration (CommentThread.js) 18.38KB 4.49KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 3.65KB 1.42KB
collaboration (PresenceProvider.js) 2.42KB 0.96KB
collaboration (index.js) 1.25KB 0.53KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 450.03KB 97.83KB
core (index.js) 1.82KB 0.62KB
create-plugin (index.js) 9.28KB 2.98KB
data-objectstack (index.js) 115.42KB 28.53KB
fields (index.js) 208.25KB 50.87KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (currency.js) 1.22KB 0.64KB
i18n (i18n.js) 4.32KB 1.77KB
i18n (index.js) 2.46KB 0.96KB
i18n (pickLocalized.js) 1.70KB 0.83KB
i18n (provider.js) 5.37KB 1.72KB
i18n (useObjectLabel.js) 21.22KB 4.69KB
i18n (useSafeTranslation.js) 2.87KB 1.28KB
layout (index.js) 38.45KB 10.67KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.74KB
mobile (index.js) 1.50KB 0.62KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 4.42KB 1.27KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.71KB 0.42KB
mobile (useResponsiveConfig.js) 1.36KB 0.63KB
mobile (useSpecGesture.js) 1.77KB 0.77KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 5.90KB 2.15KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 3.46KB 1.03KB
permissions (evaluator.js) 4.00KB 1.23KB
permissions (index.js) 0.91KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.52KB
permissions (usePermissions.js) 1.50KB 0.70KB
plugin-ai (index.js) 15.71KB 3.79KB
plugin-calendar (index.js) 45.12KB 12.34KB
plugin-charts (index.js) 46.31KB 13.06KB
plugin-chatbot (index.js) 179.58KB 42.81KB
plugin-dashboard (index.js) 117.25KB 29.14KB
plugin-designer (index.js) 213.89KB 43.03KB
plugin-detail (index.js) 213.30KB 51.94KB
plugin-editor (index.js) 2.46KB 1.10KB
plugin-form (index.js) 105.03KB 25.46KB
plugin-gantt (index.js) 149.18KB 37.17KB
plugin-grid (index.js) 173.23KB 45.75KB
plugin-kanban (index.js) 47.23KB 12.88KB
plugin-list (index.js) 97.69KB 23.10KB
plugin-map (index.js) 16.80KB 5.24KB
plugin-markdown (index.js) 13.65KB 4.67KB
plugin-report (index.js) 37.63KB 9.92KB
plugin-timeline (index.js) 25.37KB 7.20KB
plugin-tree (index.js) 8.36KB 2.81KB
plugin-view (index.js) 85.72KB 20.86KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.55KB 0.67KB
providers (UploadProvider.js) 11.71KB 3.53KB
providers (index.js) 0.44KB 0.22KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 3.19KB 1.38KB
react (LazyPluginLoader.js) 3.77KB 1.33KB
react (SchemaRenderer.js) 18.70KB 6.09KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 0.76KB 0.42KB
sdui-parser (codegen.js) 4.09KB 1.74KB
sdui-parser (index.js) 2.16KB 0.94KB
sdui-parser (parse.js) 10.04KB 2.82KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 4.69KB 1.48KB
types (ai.js) 0.20KB 0.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 0.99KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 0.20KB 0.18KB
types (crud.js) 0.20KB 0.18KB
types (data-display.js) 0.20KB 0.18KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 0.77KB 0.41KB
types (disclosure.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (index.js) 1.67KB 0.75KB
types (layout.js) 0.20KB 0.18KB
types (mobile.js) 0.20KB 0.18KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (spec-report.js) 5.26KB 1.96KB
types (theme.js) 0.20KB 0.18KB
types (ui-action.js) 0.75KB 0.46KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang
os-zhuang merged commit 6c53960 into main Jul 17, 2026
14 checks passed
@os-zhuang
os-zhuang deleted the fix/approver-membership-tier-picker branch July 17, 2026 15:29
os-zhuang added a commit to objectstack-ai/framework that referenced this pull request Jul 17, 2026
…l` (#3137)

Closes #3133. Renames the last platform surface projecting the ADR-0090 D3 reserved word: `ApproverType.role` → `org_membership_level`, with `role` kept as a deprecated alias for one window (resolves identically, warns). Publishes `xEnumDeprecated` on the node configSchema so Studio drops the deprecated spelling from the approver-type picker. Supersedes #3120/#3122. objectui half: objectstack-ai/objectui#2643 (merged).

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant