Skip to content

fix(flow-designer): author the canonical config.schedule the runtime reads#2671

Merged
os-zhuang merged 1 commit into
mainfrom
claude/time-relative-trigger-ikme70
Jul 19, 2026
Merged

fix(flow-designer): author the canonical config.schedule the runtime reads#2671
os-zhuang merged 1 commit into
mainfrom
claude/time-relative-trigger-ikme70

Conversation

@os-zhuang

Copy link
Copy Markdown
Contributor

The bug

The flow designer's start-node "Cron schedule" field wrote a flat config.cron string. But the automation runtime (resolveTriggerBindingnormalizeSchedule, in framework @objectstack/service-automation / @objectstack/trigger-schedule) only ever reads config.schedule — there is no config.cronconfig.schedule conversion anywhere. So a schedule flow authored in the designer got config.cron, which the backend ignored → normalizeSchedule(undefined)the flow silently never bound and never fired.

A second, related glitch: a code-authored object-shaped config.schedule ({ type: 'cron', expression }) rendered as "[object Object]" in the legacy bare-string text field.

(Found while adding the time-relative trigger panel; adjacent, pre-existing.)

The fix

packages/app-shell/.../metadata-admin/:

  • inspectors/flow-node-config.ts — replace the dead config.cron field with a config.schedule.expression field (the canonical shape normalizeSchedule reads; it infers cron from expression, and any runtime-set type/timezone are preserved through edits since setAtPath merges). fallbackPath: ['config','cron'] surfaces and migrates an existing flat config.cron on first edit. Reading .expression renders an object-shaped schedule as its cron string, not "[object Object]". Drops the legacy bare-string config.schedule text field (which was the source of the "[object Object]" render). The field is also offered for the time_relative sweep cadence.
  • previews/FlowCanvas.tsx — the node-card summary reads the nested config.schedule.expression (and config.timeRelative.object), so an object-shaped descriptor summarizes as its value.
  • inspectors/flow-node-config.test.ts — covers the field path/fallback, object-shape read, config.cron migration read, gating, and removal of the raw config.schedule field.

Contract-first: the fix is on the producer (the designer authors the shape the runtime reads) — no lenient config.cron fallback was added to the backend consumer.

Testing

  • flow-node-config.test.ts — 18 pass (5 new). ✅
  • @object-ui/app-shell type-check green; ESLint clean (0 errors). ✅
  • Browser-verified via the console preview gallery: the sample flow's flat config.cron: '0 9 * * *' now surfaces in the Cron schedule field (ready to migrate on edit); no "[object Object]"; zero JS errors.

Changeset included (@object-ui/app-shell patch).

🤖 Generated with Claude Code


Generated by Claude Code

…reads

The start-node inspector's "Cron schedule" field wrote a flat `config.cron`, but
the automation runtime (resolveTriggerBinding → normalizeSchedule) only reads
`config.schedule` — so a scheduled flow authored in the designer silently never
bound and never fired.

- flow-node-config.ts: replace the dead `config.cron` field with a
  `config.schedule.expression` field. `fallbackPath: ['config','cron']` surfaces
  and migrates the legacy flat key on first edit; reading `.expression` renders an
  object-shaped `config.schedule` as its cron string instead of "[object Object]".
  Drops the legacy bare-string `config.schedule` text field (which printed the
  object shape as "[object Object]"). Field is also offered for the time_relative
  sweep cadence.
- FlowCanvas.tsx: the node-card summary reads the nested config.schedule.expression
  (and config.timeRelative.object) so an object-shaped descriptor summarizes as its
  value, not "[object Object]".
- tests: cover the new field's path/fallback, object-shape read, config.cron
  migration read, gating, and removal of the raw config.schedule field.

Browser-verified via the console preview gallery: the sample flow's flat
config.cron '0 9 * * *' now surfaces in the Cron schedule field; no "[object
Object]"; zero JS errors.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AHzW68suiFuu6GdJyea8U4
@vercel

vercel Bot commented Jul 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
objectui Ignored Ignored Jul 19, 2026 6:59am

Request Review

@github-actions github-actions Bot added the tests label Jul 19, 2026
@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Main entry (gzip) 28.0 KB 350 KB
Entry file index-C23IrbUI.js
Status PASS

📦 Bundle Size Report

Package Size Gzipped
app-shell (index.js) 8.17KB 2.95KB
app-shell (runtime-config.js) 7.42KB 2.32KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 7.57KB 2.97KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 1.17KB 0.53KB
auth (AuthProvider.js) 21.70KB 4.21KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.12KB 3.41KB
auth (LoginForm.js) 17.86KB 5.29KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.43KB 2.09KB
auth (SocialSignInButtons.js) 9.60KB 3.89KB
auth (UserMenu.js) 3.40KB 1.22KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 33.74KB 8.53KB
auth (createAuthenticatedFetch.js) 3.93KB 1.55KB
auth (index.js) 1.83KB 0.79KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 4.86KB 0.85KB
auth (useIsWorkspaceAdmin.js) 1.61KB 0.85KB
collaboration (CommentThread.js) 18.38KB 4.49KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 3.65KB 1.42KB
collaboration (PresenceProvider.js) 2.42KB 0.96KB
collaboration (index.js) 1.25KB 0.53KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 450.03KB 97.83KB
core (index.js) 1.82KB 0.62KB
create-plugin (index.js) 9.28KB 2.98KB
data-objectstack (index.js) 115.42KB 28.53KB
fields (index.js) 208.98KB 51.09KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (currency.js) 1.22KB 0.64KB
i18n (i18n.js) 4.32KB 1.77KB
i18n (index.js) 2.46KB 0.96KB
i18n (pickLocalized.js) 1.70KB 0.83KB
i18n (provider.js) 5.37KB 1.72KB
i18n (useObjectLabel.js) 21.22KB 4.69KB
i18n (useSafeTranslation.js) 2.87KB 1.28KB
layout (index.js) 38.45KB 10.67KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.74KB
mobile (index.js) 1.50KB 0.62KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 4.42KB 1.27KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.71KB 0.42KB
mobile (useResponsiveConfig.js) 1.36KB 0.63KB
mobile (useSpecGesture.js) 1.77KB 0.77KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 5.90KB 2.15KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 3.46KB 1.03KB
permissions (evaluator.js) 4.00KB 1.23KB
permissions (index.js) 0.91KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.52KB
permissions (usePermissions.js) 1.50KB 0.70KB
plugin-ai (index.js) 15.71KB 3.79KB
plugin-calendar (index.js) 45.12KB 12.34KB
plugin-charts (index.js) 46.31KB 13.06KB
plugin-chatbot (index.js) 179.58KB 42.81KB
plugin-dashboard (index.js) 117.26KB 29.15KB
plugin-designer (index.js) 213.43KB 42.95KB
plugin-detail (index.js) 213.28KB 51.94KB
plugin-editor (index.js) 2.46KB 1.10KB
plugin-form (index.js) 105.08KB 25.47KB
plugin-gantt (index.js) 149.18KB 37.17KB
plugin-grid (index.js) 174.72KB 46.05KB
plugin-kanban (index.js) 47.23KB 12.88KB
plugin-list (index.js) 98.22KB 23.21KB
plugin-map (index.js) 16.80KB 5.24KB
plugin-markdown (index.js) 13.65KB 4.67KB
plugin-report (index.js) 37.63KB 9.92KB
plugin-timeline (index.js) 25.37KB 7.20KB
plugin-tree (index.js) 8.36KB 2.81KB
plugin-view (index.js) 85.72KB 20.86KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.55KB 0.67KB
providers (UploadProvider.js) 11.71KB 3.53KB
providers (index.js) 0.44KB 0.22KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 3.19KB 1.38KB
react (LazyPluginLoader.js) 3.77KB 1.33KB
react (SchemaRenderer.js) 18.70KB 6.09KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 0.76KB 0.42KB
sdui-parser (codegen.js) 4.09KB 1.74KB
sdui-parser (index.js) 2.16KB 0.94KB
sdui-parser (parse.js) 10.04KB 2.82KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 4.69KB 1.48KB
types (ai.js) 0.20KB 0.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 0.99KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 0.20KB 0.18KB
types (crud.js) 0.20KB 0.18KB
types (data-display.js) 0.20KB 0.18KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 0.77KB 0.41KB
types (disclosure.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (index.js) 1.67KB 0.75KB
types (layout.js) 0.20KB 0.18KB
types (mobile.js) 0.20KB 0.18KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (spec-report.js) 5.26KB 1.96KB
types (theme.js) 0.20KB 0.18KB
types (ui-action.js) 0.75KB 0.46KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang
os-zhuang marked this pull request as ready for review July 19, 2026 07:04
@os-zhuang
os-zhuang merged commit ce5e3fc into main Jul 19, 2026
14 checks passed
@os-zhuang
os-zhuang deleted the claude/time-relative-trigger-ikme70 branch July 19, 2026 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants