Skip to content

feat(studio): visualize loop/parallel/try_catch nested regions on the flow canvas (#2670 Phase 1)#2675

Merged
os-zhuang merged 1 commit into
mainfrom
claude/step-logs-run-observability-plxc2p
Jul 19, 2026
Merged

feat(studio): visualize loop/parallel/try_catch nested regions on the flow canvas (#2670 Phase 1)#2675
os-zhuang merged 1 commit into
mainfrom
claude/step-logs-run-observability-plxc2p

Conversation

@os-zhuang

Copy link
Copy Markdown
Contributor

Summary

Phase 1 of #2670 — the ADR-0031 "designer rendering" follow-up to the Runs-panel nesting (#2667). The flow designer canvas rendered structured control-flow containers (loop / parallel / try_catch) as opaque single node cards; their nested regions (config.body / config.branches[] / config.try/catch) were only visible — and only editable — as raw JSON in the inspector's Advanced block.

A container card now carries a "show nested regions" control that opens a read-only popover rendering the region(s) as a mini-canvas — the same top-to-bottom node/edge layout as the parent graph — so an author can see the structure without reading JSON.

What changed

  • flow-canvas-layout.tsextractRegions(node) (pure): pulls a container's labeled regions from config. Returns [] for ordinary nodes and for a legacy flat loop (no config.body), which stay plain cards.
  • flow-region-view.tsx (new) — a read-only mini-canvas for a region: reuses the shared computeLayout / diagramSize / edgePath at full scale, then fits the whole region to the popover width with a single CSS transform. No new layout engine.
  • flow-canvas-parts.tsx (NodeCard) — when a node has regions, a chevron control opens a Popover with the region view, each region headed by its label (a named branch or Branch N, and Try / Catch; a loop body has none).
  • FlowCanvas.tsx — passes extractRegions(node) to each card.

Design note — why a popover (zero regression)

The region renders in a floating, portaled Popover, so it never overlaps the canvas's other nodes and requires no change to computeLayout, diagramSize, or the edge routing — every existing flat flow renders byte-identically. (An earlier inline-growth prototype overlapped the nodes below an expanded container; push-down layout would mean threading variable heights through the shared layout + edge anchors — deferred deliberately.)

Deferred to the next increments on #2670: inline push-down nesting on the canvas (regions embedded in the flow, siblings pushed down), nested selection + a structured region inspector, nested editing (add/drag/reparent), and client-side region validation. This PR does not close #2670.

Verification

  • flow-canvas-layout.test.tsextractRegions unit tests (ordinary / legacy-loop / loop body / parallel-branch labels / try+catch).
  • FlowCanvas.test.tsx — render tests: opening a loop shows its body node; parallel branch labels (Branch 2) + handlers render; a legacy flat loop has no region control.
  • 19/19 tests pass; turbo type-check clean; ESLint 0 errors.
  • Browser-verified in the offline preview gallery (Playwright): loop body, named + indexed parallel branches, and Try/Catch handlers all render in their popovers with the main flow chain intact and no overlap.

🤖 Generated with Claude Code


Generated by Claude Code

… flow canvas (#2670)

Phase 1 of #2670 (ADR-0031 designer rendering follow-up to the Runs-panel
nesting in #2667). The flow designer rendered `loop`/`parallel`/`try_catch`
containers as opaque single cards; their nested regions (`config.body` /
`config.branches[]` / `config.try`/`catch`) were only visible as raw JSON.

- `extractRegions(node)` (flow-canvas-layout) — pure: pulls a container's labeled
  regions from config; returns [] for ordinary nodes and legacy flat loops.
- `flow-region-view` — read-only mini-canvas for a region, reusing `computeLayout`
  / `diagramSize` / `edgePath` at full scale then fitting to width with one CSS
  transform (no new layout engine).
- `NodeCard` — a container gains a "show nested regions" control that opens the
  region(s) in a Popover, each with a header (named branch / `Branch N` / `Try` /
  `Catch`). Floating + portaled, so it never overlaps canvas nodes and needs no
  change to the layout or edge routing — zero regression to existing flows.

Read-only for now; inline push-down nesting and nested editing are the next
increments on #2670. Adds `extractRegions` unit tests and FlowCanvas render tests
(loop body, parallel branch labels, legacy-loop has no control).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VuvxWgoadqryqBcjs7TpVi
@vercel

vercel Bot commented Jul 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
objectui Ignored Ignored Jul 19, 2026 8:49am

Request Review

@github-actions github-actions Bot added the tests label Jul 19, 2026
@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Main entry (gzip) 28.0 KB 350 KB
Entry file index-DUp4SfSJ.js
Status PASS

📦 Bundle Size Report

Package Size Gzipped
app-shell (index.js) 8.17KB 2.95KB
app-shell (runtime-config.js) 7.42KB 2.32KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 7.57KB 2.97KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 1.17KB 0.53KB
auth (AuthProvider.js) 21.70KB 4.21KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.12KB 3.41KB
auth (LoginForm.js) 17.86KB 5.29KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.43KB 2.09KB
auth (SocialSignInButtons.js) 9.60KB 3.89KB
auth (UserMenu.js) 3.40KB 1.22KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 33.74KB 8.53KB
auth (createAuthenticatedFetch.js) 3.93KB 1.55KB
auth (index.js) 1.83KB 0.79KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 4.86KB 0.85KB
auth (useIsWorkspaceAdmin.js) 1.61KB 0.85KB
collaboration (CommentThread.js) 18.38KB 4.49KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 3.65KB 1.42KB
collaboration (PresenceProvider.js) 2.42KB 0.96KB
collaboration (index.js) 1.25KB 0.53KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 450.03KB 97.83KB
core (index.js) 1.82KB 0.62KB
create-plugin (index.js) 9.28KB 2.98KB
data-objectstack (index.js) 115.42KB 28.53KB
fields (index.js) 208.98KB 51.09KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (currency.js) 1.22KB 0.64KB
i18n (i18n.js) 4.32KB 1.77KB
i18n (index.js) 2.46KB 0.96KB
i18n (pickLocalized.js) 1.70KB 0.83KB
i18n (provider.js) 5.37KB 1.72KB
i18n (useObjectLabel.js) 21.22KB 4.69KB
i18n (useSafeTranslation.js) 2.87KB 1.28KB
layout (index.js) 38.45KB 10.67KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.74KB
mobile (index.js) 1.50KB 0.62KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 4.42KB 1.27KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.71KB 0.42KB
mobile (useResponsiveConfig.js) 1.36KB 0.63KB
mobile (useSpecGesture.js) 1.77KB 0.77KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 5.90KB 2.15KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 3.46KB 1.03KB
permissions (evaluator.js) 4.00KB 1.23KB
permissions (index.js) 0.91KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.52KB
permissions (usePermissions.js) 1.50KB 0.70KB
plugin-ai (index.js) 15.71KB 3.79KB
plugin-calendar (index.js) 45.12KB 12.34KB
plugin-charts (index.js) 46.31KB 13.06KB
plugin-chatbot (index.js) 179.58KB 42.81KB
plugin-dashboard (index.js) 117.37KB 29.18KB
plugin-designer (index.js) 213.43KB 42.95KB
plugin-detail (index.js) 213.28KB 51.94KB
plugin-editor (index.js) 2.46KB 1.10KB
plugin-form (index.js) 105.08KB 25.47KB
plugin-gantt (index.js) 149.18KB 37.17KB
plugin-grid (index.js) 174.72KB 46.05KB
plugin-kanban (index.js) 47.23KB 12.88KB
plugin-list (index.js) 98.22KB 23.21KB
plugin-map (index.js) 16.80KB 5.24KB
plugin-markdown (index.js) 13.65KB 4.67KB
plugin-report (index.js) 37.81KB 9.98KB
plugin-timeline (index.js) 25.37KB 7.20KB
plugin-tree (index.js) 8.36KB 2.81KB
plugin-view (index.js) 85.72KB 20.86KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.55KB 0.67KB
providers (UploadProvider.js) 11.71KB 3.53KB
providers (index.js) 0.44KB 0.22KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 3.19KB 1.38KB
react (LazyPluginLoader.js) 3.77KB 1.33KB
react (SchemaRenderer.js) 18.70KB 6.09KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 0.76KB 0.42KB
sdui-parser (codegen.js) 4.09KB 1.74KB
sdui-parser (index.js) 2.16KB 0.94KB
sdui-parser (parse.js) 10.04KB 2.82KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 4.69KB 1.48KB
types (ai.js) 0.20KB 0.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 0.99KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 0.20KB 0.18KB
types (crud.js) 0.20KB 0.18KB
types (data-display.js) 0.20KB 0.18KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 0.77KB 0.41KB
types (disclosure.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (index.js) 1.67KB 0.75KB
types (layout.js) 0.20KB 0.18KB
types (mobile.js) 0.20KB 0.18KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (spec-report.js) 5.26KB 1.96KB
types (theme.js) 0.20KB 0.18KB
types (ui-action.js) 0.75KB 0.46KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang
os-zhuang marked this pull request as ready for review July 19, 2026 11:13
@os-zhuang
os-zhuang merged commit a4acca7 into main Jul 19, 2026
14 checks passed
@os-zhuang
os-zhuang deleted the claude/step-logs-run-observability-plxc2p branch July 19, 2026 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flow designer: render loop / parallel / try_catch as nested regions on the canvas (ADR-0031 follow-up)

2 participants