fix(plugin-detail): #2688 — header Record-#id floor + raw audit user id in the meta footer#2689
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
… in meta footer Two rendering defects on record surfaces opened with a partial context (e.g. the gantt row drawer fetching a business record + schema): 1. DetailView header: resolveDisplayTitle passed deriveFromRecordKeys:false and no caller set schema.title, so a record whose name lives in a field the type-aware derivation deliberately skips (an autonumber 'name') floored to 'Record #<id>'. Add a record-key probe as the LAST resort before the floor — only reached when schema.title is absent, so the 'guessed key must not outrank the object label' rule still holds. 2. RecordMetaFooter: UserRef degraded created_by/updated_by to type 'text' (raw opaque id) whenever the fetched schema omitted the audit system fields. They are always user references on ObjectStack — default the reference target to sys_user so the reference renderer resolves a name (or shows the muted placeholder). Verified live against a real app backend: gantt right-click 查看详情 now titles the drawer with the record name and the footer shows resolved creator/updater names. plugin-detail 236/236, plugin-gantt 336/336, tsc clean; new regression suite DetailView.title2688.test.tsx (5 cases). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem (#2688)
Record surfaces opened with a partial context — e.g. the gantt row drawer, which fetches the business record + schema itself — showed two rendering defects (same record renders correctly on the normal record page):
Record #LnLJIsTwXbv1E2gF❌创建人 Dev AdminRoot causes & fixes
1. DetailView header —
resolveDisplayTitleruns the unified resolver withderiveFromRecordKeys: falseand the drawer sets noschema.title, so a record whose name lives in a field the type-aware derivation deliberately skips (anautonumbername) fell through to theRecord #<id>floor.Fix: probe name-ish record keys (
name/title/*_name/…) as the last resort before the floor. The step is only reached whenschema.titleis absent, so the existing "guessed key must not outrank the caller's object label" rule is preserved.2. RecordMetaFooter —
UserRefdegradedcreated_by/updated_bytotype: 'text'(raw id string) whenever the fetched schema omitted the audit system fields.Fix: audit fields are always user references on ObjectStack — default the reference target to
sys_userso the reference renderer resolves a display name (or shows the muted placeholder). An explicit schema definition still wins.Verification
DetailView.title2688.test.tsx— 5 cases (record-key probe, floor preserved for truly nameless records,schema.titleprecedence intact, footer never leaks the opaque id, explicit schema def honoured).tsc --noEmitclean, zero new lint findings.Refs #2688
🤖 Generated with Claude Code