Skip to content

feat(approvals-inbox): retire hardcoded secondary buttons for server-declared actions (#2678 P2-4)#2697

Merged
os-zhuang merged 1 commit into
mainfrom
claude/enterprise-delegation-ooo-proxy-1v3m8l
Jul 19, 2026
Merged

feat(approvals-inbox): retire hardcoded secondary buttons for server-declared actions (#2678 P2-4)#2697
os-zhuang merged 1 commit into
mainfrom
claude/enterprise-delegation-ooo-proxy-1v3m8l

Conversation

@os-zhuang

Copy link
Copy Markdown
Contributor

Completes #2678 P2-4. Pairs with framework#3300 (declared action set + /revise,/resubmit routes).

What

The approvals inbox no longer hand-wires a button per decision capability. With the full declared action set now on sys_approval_request (framework#3300), DeclaredActionsBar renders + executes them, so the inbox drops its bespoke send-back / request-info / reassign / remind / recall / resubmit buttons — along with the three AlertDialogs, five action handlers (doReassign/doRemind/doRequestInfo/doSendBack/doResubmit), and the lazy user-directory loader (loadUserOptions) that backed them.

  • DeclaredActionsBar gains an exclude prop. The inbox keeps approve/reject in its richer composer — it stages file attachments the generic param dialog can't yet collect — and excludes them from the bar, so the two never render duplicate buttons.
  • Pending drawer: the "More actions" bar covers reassign / send-back / request-info (approver) and remind / recall (submitter), each gated by the declared visible CEL.
  • Returned drawer: keeps the Edit-record link; resubmit and recall-abandon come from the bar (gated to the submitter on a returned request).

Net: ~230 fewer lines of inbox-specific action code. New decision capabilities now ship as backend metadata — enterprise act-as (cloud#861) included — and render on any surface that mounts the bar.

The one thing kept hardcoded — and why

approve/reject stay in the composer because they collect file attachments (CommentAttachment + presigned upload) with an inline comment. ActionParamDialog has no file-upload param rendering yet, so a declared approve/reject couldn't carry attachments. Closing that gap (a file-type param in the shared dialog) is a reusable follow-up that would let the composer retire too — filed as the next step, not stretched into this PR.

Verification

In-browser against the live backend (framework main + framework#3300):

  • Drawer shows approve/reject in the composer and send-back / request-info / reassign / remind / recall in "More actions" — declared-action testids present, zero duplicates (approval_approve/approval_reject count 0 in the bar).
  • Submitter gating correct: viewing a request they submitted, admin sees remind/recall; resubmit is hidden on a pending request (shows only on returned).
  • Reassign opens a real sys_user picker (field-backed combobox), not a free-text box.
  • Clicking declared "Send reminder" opened the param dialog, POSTed /remind, and appended a remind audit row — end-to-end through the shared runtime with zero inbox-specific code.
  • app-shell suite green (7 DeclaredActionsBar tests incl. the new exclude cases); console typecheck clean; lint delta zero (pre-existing React-Compiler advisories unchanged).

Refs

#2678 (P2-4) · framework#3300 (backend half) · cloud#861 (enterprise act-as)

🤖 Generated with Claude Code


Generated by Claude Code

…declared actions

Completes objectui#2678 P2-4: the approvals inbox no longer hand-wires a
button per decision capability. With the full declared action set now on
sys_approval_request (framework#3300), DeclaredActionsBar renders and executes
them, so the inbox drops its bespoke send-back / request-info / reassign /
remind / recall / resubmit buttons — plus the three AlertDialogs, five action
handlers, and the lazy user-directory loader that backed them.

- DeclaredActionsBar gains an `exclude` prop. The inbox keeps approve/reject in
  its richer composer (it stages file attachments the generic param dialog
  can't yet collect) and `exclude`s them from the bar, so the two never render
  duplicate buttons.
- Pending drawer: the "More actions" bar covers reassign/send-back/request-info
  (approver) and remind/recall (submitter, gated by the declared `visible` CEL).
- Returned drawer: keeps the Edit-record link; resubmit and recall-abandon come
  from the bar (gated to the submitter on a returned request).

Net: ~230 fewer lines of inbox-specific action code; new decision capabilities
now ship as backend metadata (enterprise act-as, cloud#861, included).

Verified in-browser against the live backend: the drawer shows approve/reject
in the composer and send-back/request-info/reassign/remind/recall in "More
actions" with zero duplicates; resubmit correctly hidden on a pending request;
Reassign opens a real sys_user picker; clicking declared "Send reminder"
executed /remind and appended a `remind` audit row. app-shell suite green
(7 DeclaredActionsBar tests incl. exclude); console typecheck clean.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016ypkQikZ55oWUHUnMebwXA
@vercel

vercel Bot commented Jul 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
objectui Ignored Ignored Jul 19, 2026 4:50pm

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Main entry (gzip) 28.0 KB 350 KB
Entry file index-BjyDziQZ.js
Status PASS

📦 Bundle Size Report

Package Size Gzipped
app-shell (index.js) 8.19KB 2.96KB
app-shell (runtime-config.js) 7.42KB 2.32KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 7.57KB 2.97KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 1.17KB 0.53KB
auth (AuthProvider.js) 21.70KB 4.21KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.12KB 3.41KB
auth (LoginForm.js) 17.86KB 5.29KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.43KB 2.09KB
auth (SocialSignInButtons.js) 9.60KB 3.89KB
auth (UserMenu.js) 3.40KB 1.22KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 33.74KB 8.53KB
auth (createAuthenticatedFetch.js) 3.93KB 1.55KB
auth (index.js) 1.83KB 0.79KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 4.86KB 0.85KB
auth (useIsWorkspaceAdmin.js) 1.61KB 0.85KB
collaboration (CommentThread.js) 18.38KB 4.49KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 3.65KB 1.42KB
collaboration (PresenceProvider.js) 2.42KB 0.96KB
collaboration (index.js) 1.25KB 0.53KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 450.03KB 97.83KB
core (index.js) 1.82KB 0.62KB
create-plugin (index.js) 9.28KB 2.98KB
data-objectstack (index.js) 120.81KB 30.10KB
fields (index.js) 208.98KB 51.09KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (currency.js) 1.22KB 0.64KB
i18n (i18n.js) 4.32KB 1.77KB
i18n (index.js) 2.46KB 0.96KB
i18n (pickLocalized.js) 1.70KB 0.83KB
i18n (provider.js) 5.37KB 1.72KB
i18n (useObjectLabel.js) 21.22KB 4.69KB
i18n (useSafeTranslation.js) 2.87KB 1.28KB
layout (index.js) 38.45KB 10.67KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.74KB
mobile (index.js) 1.50KB 0.62KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 4.42KB 1.27KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.71KB 0.42KB
mobile (useResponsiveConfig.js) 1.36KB 0.63KB
mobile (useSpecGesture.js) 1.77KB 0.77KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 5.90KB 2.15KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 3.46KB 1.03KB
permissions (evaluator.js) 4.00KB 1.23KB
permissions (index.js) 0.91KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.52KB
permissions (usePermissions.js) 1.50KB 0.70KB
plugin-ai (index.js) 15.71KB 3.79KB
plugin-calendar (index.js) 45.12KB 12.34KB
plugin-charts (index.js) 46.31KB 13.06KB
plugin-chatbot (index.js) 179.58KB 42.81KB
plugin-dashboard (index.js) 117.37KB 29.18KB
plugin-designer (index.js) 213.43KB 42.95KB
plugin-detail (index.js) 213.56KB 51.99KB
plugin-editor (index.js) 2.46KB 1.10KB
plugin-form (index.js) 102.94KB 24.95KB
plugin-gantt (index.js) 162.24KB 39.49KB
plugin-grid (index.js) 174.72KB 46.05KB
plugin-kanban (index.js) 47.23KB 12.88KB
plugin-list (index.js) 98.22KB 23.21KB
plugin-map (index.js) 16.80KB 5.24KB
plugin-markdown (index.js) 13.65KB 4.67KB
plugin-report (index.js) 37.81KB 9.98KB
plugin-timeline (index.js) 25.37KB 7.20KB
plugin-tree (index.js) 8.36KB 2.81KB
plugin-view (index.js) 85.72KB 20.86KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.55KB 0.67KB
providers (UploadProvider.js) 11.71KB 3.53KB
providers (index.js) 0.44KB 0.22KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 3.19KB 1.38KB
react (LazyPluginLoader.js) 3.77KB 1.33KB
react (SchemaRenderer.js) 18.70KB 6.09KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 0.76KB 0.42KB
sdui-parser (codegen.js) 4.09KB 1.74KB
sdui-parser (index.js) 2.16KB 0.94KB
sdui-parser (parse.js) 10.04KB 2.82KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 4.69KB 1.48KB
types (ai.js) 0.20KB 0.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 0.99KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 0.20KB 0.18KB
types (crud.js) 0.20KB 0.18KB
types (data-display.js) 0.20KB 0.18KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 0.77KB 0.41KB
types (disclosure.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (index.js) 1.67KB 0.75KB
types (layout.js) 0.20KB 0.18KB
types (mobile.js) 0.20KB 0.18KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (spec-report.js) 5.26KB 1.96KB
types (theme.js) 0.20KB 0.18KB
types (ui-action.js) 0.75KB 0.46KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants