feat(app-shell): distinguish writable system objects from engine-owned in badge + empty-state (ADR-0103 / #3220)#2705
Merged
Conversation
…d in badge + empty-state (ADR-0103 / #3220) The framework split the overloaded managedBy:'system' bucket (ADR-0103): several system objects are admin/user-writable data (Notification Preferences / Subscriptions / Templates, delegated RBAC assignments, user preferences) and declare userActions opening their writes. The Console already rendered the New/Edit/Delete buttons for these (the affordance mirrors honour userActions), but the badge/empty-state copy still called every system object a "read-only monitoring surface". - ManagedByBadge accepts userActions and renders a "Platform schema — admin-writable" variant when a system object opens any write. - resolveManagedByEmptyState returns undefined for a writable system object (userActions.create) so the generic empty state with the New button shows. - New managedByBadge.systemWritable.* strings (en + zh; others fall back to en). Copy/UX only — no behavioural change. Paired with framework #3315. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fp9yZxRQ3mb7p4vVwqFXKE
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
os-zhuang
marked this pull request as ready for review
July 19, 2026 18:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Console-side companion to framework PR objectstack-ai/framework#3315 (ADR-0103, closes root cause of framework #3220).
Context
The framework split the overloaded
managedBy: 'system'bucket. Engine-owned rows stay read-only, but severalsystemobjects are admin/user-writable data — Notification Preferences / Subscriptions / Templates, the delegated RBAC link tables,sys_user_preference— and now declareuserActionsopening their writes.The Console already rendered the New/Edit/Delete buttons correctly for these (every affordance mirror —
crudAffordances,record-detailsNON_EDITABLE_BUCKETS,ObjectForm— honoursuserActions). The only staleness was the copy: the badge tooltip and empty state still called everysystemobject a "read-only monitoring surface", which is wrong for e.g. Notification Preferences (which users edit).Changes (copy/UX only — no behavioural change)
ManagedByBadgenow takes the object'suserActions; when asystemobject opens any write it renders a distinct "Platform schema — admin-writable" variant instead of the engine-owned "read-only monitoring surface" copy. Threaded at the three call sites (ObjectView,RecordDetailView,RecordFormPage).resolveManagedByEmptyStatereturnsundefinedfor asystemobject whoseuserActions.createis set, so the generic empty state (with the New button) shows instead of "entries appear automatically when their source action runs".managedByBadge.systemWritable.*strings inen+zh; other locales fall back to the EnglishdefaultValue(the i18n cross-locale parity test only checks top-level +commonkeys, so nested additions are safe).managedByEmptyState.test.tswith the ADR-0103 writable-system case.Verification
app-shellmanagedByEmptyState+crudAffordancessuites andi18nparity (89) pass.turbo build(@object-ui/app-shell+@object-ui/i18n) typechecks clean.Nothing here is required for correctness (the buttons already worked); it aligns the explanatory copy with the framework's corrected taxonomy.
🤖 Generated with Claude Code
Generated by Claude Code