fix(list): route remaining system-field groupings through the shared classifier#2706
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
❌ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
…sifier Follow-up to the owner_id default-column fix. Consolidate the display-oriented system-field exclusions onto the shared isSystemManagedField / SYSTEM_MANAGED_FIELD_NAMES helper so the framework-injected owner_id is treated consistently across the grid, record picker, and detail drawer: - ObjectGrid record-detail drawer (renderRecordDetail): split business fields vs. the muted meta section via the shared classifier, so owner_id and other injected system fields land in the meta section, not the business body. - deriveLookupColumns (record picker): drop the local SYSTEM_FIELDS name set for the shared classifier — now flag-aware (field.system), not just name-based. - RecordDetailDrawer: derive its default systemFields set from the shared SYSTEM_MANAGED_FIELD_NAMES; the systemFields prop override is preserved. deriveRelatedLists' narrow audit-FK set and plugin-detail's inline-edit never-editable set are intentionally left distinct (different semantics). Adds a flag-awareness test to deriveLookupColumns and a changeset. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NMcdh2cNs165TSF4ub61oy
os-zhuang
force-pushed
the
claude/showcase-owner-id-lists-6gxw6y
branch
from
July 19, 2026 18:41
1b16dc2 to
7fbbdfb
Compare
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
os-zhuang
marked this pull request as ready for review
July 20, 2026 01:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up cleanup to #2702 (the
owner_iddefault-column fix). Routes the remaining display-oriented system-field groupings through the sharedisSystemManagedField/SYSTEM_MANAGED_FIELD_NAMEShelper so the framework-injectedowner_idis handled consistently everywhere, and removes the duplicated per-file name lists.Changes
ObjectGridrecord-detail drawer (renderRecordDetail) — the grid's record-detail overlay split fields into a business body vs. a muted "meta" section using a hardcoded list that omittedowner_id. Now uses the shared classifier, soowner_id(and other injected system fields) sit in the meta section, consistent with the grid's default columns. Hidden system fields are also kept out of the meta section.deriveLookupColumns(record picker) — drops its localSYSTEM_FIELDSname set for the shared classifier; now also flag-aware (field.system), not just name-based.RecordDetailDrawer— its defaultsystemFieldsset is derived from the sharedSYSTEM_MANAGED_FIELD_NAMES(thesystemFieldsprop override is preserved).Deliberately left distinct
deriveRelatedLists'AUDIT_FK_FIELDS— a narrow "FK that exists on every object" set (already correct onowner_id); broadening it would change related-list generation with noowner_idbenefit.NON_EDITABLE_SYSTEM_FIELDS(inline-edit gate) — intentionally excludesowner_idbecause ownership is reassignable/editable.Verification
deriveLookupColumns, bothRecordDetailDrawersuites,deriveRelatedLists, plus the grid suites (column-features,mobileCardLookupDisplay). New test locks inderiveLookupColumnsflag-awareness (asystem: truefield with a non-canonical name is skipped).deriveLookupColumns.ts/RecordDetailDrawer.tsx(remaining output is pre-existing repo baseline noise).Affected packages
@object-ui/plugin-grid,@object-ui/fields,@object-ui/plugin-detail(patch; changeset included).🤖 Generated with Claude Code
https://claude.ai/code/session_01NMcdh2cNs165TSF4ub61oy
Generated by Claude Code