Skip to content

fix(app-shell): guard ActionParamDialog submit during file upload + map spec autonumber (ADR-0059 follow-ups)#2707

Merged
os-zhuang merged 1 commit into
mainfrom
claude/sdui-actionparamdialog-form-fields-kk6w4k
Jul 20, 2026
Merged

fix(app-shell): guard ActionParamDialog submit during file upload + map spec autonumber (ADR-0059 follow-ups)#2707
os-zhuang merged 1 commit into
mainfrom
claude/sdui-actionparamdialog-form-fields-kk6w4k

Conversation

@os-zhuang

Copy link
Copy Markdown
Contributor

Two follow-ups to the shared field-widget param rendering merged in #2704 (#2700 / ADR-0059).

1. Upload-in-progress guard

A file/image param's value only becomes its uploaded fileId once the presigned upload settles, so confirming mid-upload sent an empty/stale value to the action. Now:

  • FileField / ImageField surface their in-progress state via an optional onUploadingChange prop (shared useUploadingSignal hook; ignored by every other widget).
  • ActionParamDialog wires it only for file/image params (so no unknown prop leaks toward the DOM of other widgets), disables Confirm (label → "Uploading…", new actionDialog.uploading key across all 10 locales) and blocks submit while any upload is in flight.

2. autonumber spelling

@objectstack/spec spells the type autonumber; the widget-map key is auto_number. mapFieldTypeToFormType now folds both to the AutoNumber widget, so a spec-typed autonumber field/param no longer falls through to the plain text input — this fixes the object form path too, not just action params. The redundant param-side alias is dropped (the shared map covers it).

Tests

  • useUploadingSignal unit test (fires-on-change, latest-callback, no-op-without-callback).
  • ActionParamDialog.uploading.test.tsx — Confirm disabled/re-enabled + submit blocked, via a stubbed upload widget (deterministic mid-upload window).
  • field-type-coverage asserts autonumber → non-text widget.
  • Full fields + app-shell + i18n suites green (245 files / 2141 tests).

Browser verification (real Chromium)

Drove a throwaway Vite preview of ActionParamDialog (one param per representative type) with a deliberately slow upload adapter, via the pre-installed Chromium + Playwright:

  • All 8 types render their real controltextarea, number, boolean checkbox, Radix combobox (select), native date, native color, file + file[multiple] — none fell back to a text box.
  • Upload guard: Confirm Confirm (enabled) → mid-upload Uploading… (disabled, field shows a spinner) → after settle Confirm (enabled).

Harness was uncommitted and removed after verification.

Notes

  • @object-ui/fields package lint is red at baseline on main (pre-existing react-hooks/rules-of-hooks in ImageField/index.tsx on code this PR doesn't touch — verified by linting the pristine origin/main files). This PR's changed files add no new lint errors.
  • Deferred from the broader follow-up list (not in this PR): the approvals approve/reject composer retirement (spans the cloud repo + needs attach-on-decision browser verification against a live backend), select+multiplemultiselect (would diverge params from the form, which renders it single-select — belongs in the shared widget layer), and the @object-ui/core/fields baseline lint cleanup (touches many unrelated pre-existing-error files).

Changeset: @object-ui/fields / @object-ui/app-shell / @object-ui/i18n patch.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Rg7oavKSUdb2KzYEEYrCHX


Generated by Claude Code

…ap spec autonumber (ADR-0059 follow-ups)

Two follow-ups to the shared field-widget param rendering (#2700 / ADR-0059):

- Upload-in-progress guard: file/image params only carry their fileId once the
  presigned upload settles, so confirming mid-upload sent an empty/stale value.
  FileField/ImageField now surface upload state via an optional onUploadingChange
  prop (shared useUploadingSignal hook, ignored by other widgets); the dialog
  wires it for file/image params, disables Confirm (label -> "Uploading…", new
  actionDialog.uploading key in all 10 locales) and blocks submit while any
  upload is in flight.
- autonumber spelling: mapFieldTypeToFormType now folds the spec FieldType
  spelling `autonumber` (alongside the widget-map key `auto_number`) to the
  AutoNumber widget, so a spec-typed autonumber field/param no longer falls
  through to the text input — fixes the object form path too. The redundant
  param-side alias is dropped (the shared map now covers it).

Tests: useUploadingSignal unit test (fires-on-change, latest-callback, no-op);
ActionParamDialog upload-guard test (Confirm disabled/re-enabled, submit blocked)
via a stubbed upload widget; field-type-coverage asserts autonumber -> non-text.
Docs: ADR-0059 follow-ups section, enhanced-actions params note; changeset (patch).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Rg7oavKSUdb2KzYEEYrCHX
@vercel

vercel Bot commented Jul 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
objectui Ignored Ignored Jul 19, 2026 7:04pm

Request Review

@github-actions github-actions Bot added documentation Improvements or additions to documentation tests labels Jul 19, 2026
@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Main entry (gzip) 28.0 KB 350 KB
Entry file index-gYLfgelm.js
Status PASS

📦 Bundle Size Report

Package Size Gzipped
app-shell (index.js) 8.19KB 2.96KB
app-shell (runtime-config.js) 7.42KB 2.32KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 7.57KB 2.97KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 1.17KB 0.53KB
auth (AuthProvider.js) 21.70KB 4.21KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.12KB 3.41KB
auth (LoginForm.js) 17.86KB 5.29KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.43KB 2.09KB
auth (SocialSignInButtons.js) 9.60KB 3.89KB
auth (UserMenu.js) 3.40KB 1.22KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 33.74KB 8.53KB
auth (createAuthenticatedFetch.js) 3.93KB 1.55KB
auth (index.js) 1.83KB 0.79KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 4.86KB 0.85KB
auth (useIsWorkspaceAdmin.js) 1.61KB 0.85KB
collaboration (CommentThread.js) 18.38KB 4.49KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 3.65KB 1.42KB
collaboration (PresenceProvider.js) 2.42KB 0.96KB
collaboration (index.js) 1.25KB 0.53KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 450.03KB 97.83KB
core (index.js) 1.82KB 0.62KB
create-plugin (index.js) 9.28KB 2.98KB
data-objectstack (index.js) 120.81KB 30.10KB
fields (index.js) 209.56KB 51.26KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (currency.js) 1.22KB 0.64KB
i18n (i18n.js) 4.32KB 1.77KB
i18n (index.js) 2.46KB 0.96KB
i18n (pickLocalized.js) 1.70KB 0.83KB
i18n (provider.js) 5.37KB 1.72KB
i18n (useObjectLabel.js) 21.22KB 4.69KB
i18n (useSafeTranslation.js) 2.87KB 1.28KB
layout (index.js) 38.45KB 10.67KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.74KB
mobile (index.js) 1.50KB 0.62KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 4.42KB 1.27KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.71KB 0.42KB
mobile (useResponsiveConfig.js) 1.36KB 0.63KB
mobile (useSpecGesture.js) 1.77KB 0.77KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 5.90KB 2.15KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 3.46KB 1.03KB
permissions (evaluator.js) 4.00KB 1.23KB
permissions (index.js) 0.91KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.52KB
permissions (usePermissions.js) 1.50KB 0.70KB
plugin-ai (index.js) 15.71KB 3.79KB
plugin-calendar (index.js) 45.12KB 12.34KB
plugin-charts (index.js) 46.31KB 13.06KB
plugin-chatbot (index.js) 179.58KB 42.81KB
plugin-dashboard (index.js) 113.58KB 28.77KB
plugin-designer (index.js) 213.43KB 42.95KB
plugin-detail (index.js) 213.56KB 51.99KB
plugin-editor (index.js) 2.46KB 1.10KB
plugin-form (index.js) 102.94KB 24.95KB
plugin-gantt (index.js) 162.24KB 39.49KB
plugin-grid (index.js) 174.57KB 46.01KB
plugin-kanban (index.js) 47.23KB 12.88KB
plugin-list (index.js) 98.22KB 23.21KB
plugin-map (index.js) 16.80KB 5.24KB
plugin-markdown (index.js) 13.65KB 4.67KB
plugin-report (index.js) 37.81KB 9.98KB
plugin-timeline (index.js) 25.37KB 7.20KB
plugin-tree (index.js) 8.36KB 2.81KB
plugin-view (index.js) 85.72KB 20.86KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.55KB 0.67KB
providers (UploadProvider.js) 11.71KB 3.53KB
providers (index.js) 0.44KB 0.22KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 3.19KB 1.38KB
react (LazyPluginLoader.js) 3.77KB 1.33KB
react (SchemaRenderer.js) 18.70KB 6.09KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 0.76KB 0.42KB
sdui-parser (codegen.js) 4.09KB 1.74KB
sdui-parser (index.js) 2.16KB 0.94KB
sdui-parser (parse.js) 10.04KB 2.82KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 4.69KB 1.48KB
types (ai.js) 0.20KB 0.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 0.99KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 0.20KB 0.18KB
types (crud.js) 0.20KB 0.18KB
types (data-display.js) 0.20KB 0.18KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 0.77KB 0.41KB
types (disclosure.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (index.js) 1.97KB 0.93KB
types (layout.js) 0.20KB 0.18KB
types (mobile.js) 0.20KB 0.18KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (spec-report.js) 5.26KB 1.96KB
types (system-fields.js) 2.39KB 1.17KB
types (theme.js) 0.20KB 0.18KB
types (ui-action.js) 0.75KB 0.46KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants