Skip to content

fix(plugin-view): coerce i18n tab-label helpers to string (TS2322) #2721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-zhuang merged 1 commit into from
Jul 20, 2026
Merged

fix(plugin-view): coerce i18n tab-label helpers to string (TS2322) #2721

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/plugin-view/src/ManageViewsDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,11 @@ import type { ViewTabItem } from './ViewTabBar';
function useViewLabel() {
try {
const { t } = useObjectTranslation();
return (key: string, fallback: string, vars?: Record<string, unknown>) => {
return (key: string, fallback: string, vars?: Record<string, unknown>): string => {
const v = t(key, vars as any);
return !v || v === key ? fallback : v;
// i18next's `t()` is typed `string | object`; coerce so render sites and
// aria-labels always receive a string (an object child white-screens React).
return !v || v === key ? fallback : String(v);
};
} catch {
return (_k: string, fallback: string) => fallback;
Expand Down
6 changes: 4 additions & 2 deletions packages/plugin-view/src/ViewTabBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,11 @@ import { useObjectTranslation } from '@object-ui/react';
function useViewTabLabel() {
try {
const { t } = useObjectTranslation();
return (key: string, fallback: string, vars?: Record<string, unknown>) => {
return (key: string, fallback: string, vars?: Record<string, unknown>): string => {
const v = t(key, vars as any);
return !v || v === key ? fallback : v;
// i18next's `t()` is typed `string | object`; coerce so render sites and
// aria-labels always receive a string (an object child white-screens React).
return !v || v === key ? fallback : String(v);
};
} catch {
return (_k: string, fallback: string) => fallback;
Expand Down
Loading