feat(dashboard): retire pre-ADR-0021 inline-analytics renderer branches (framework#3320)#2723
Merged
Merged
Conversation
…es (framework#3320) Follow-up to framework#3251 / objectui#2703. Authoring already emits only the semantic-layer shape (dataset + dimensions + values); this removes the renderer's now-unauthored legacy read-branches and the deprecated type keys. - types: drop the @deprecated inline-analytics keys (object, categoryField, categoryGranularity, valueField, aggregate, measures) from DashboardWidgetSchema. - plugin-dashboard: DashboardRenderer no longer emits the object-bound metric/chart/pivot/table/list branches from top-level object + analytics keys. It keeps the renderer-internal static paths (options.data / widget.data array and provider:'object') and widget.component. The renderer no longer emits object-pivot / pivot at all — dataset pivots render via DatasetWidget; the ObjectPivotTable / PivotTable components stay as public SDUI blocks. DashboardGridLayout gets the same treatment. A widget still carrying the retired inline shape (top-level object, no dataset, no options.data) now renders a visible error placeholder prompting a rebind to a dataset, not a blank. - plugin-designer: DashboardEditor drops its inline object / value-field / aggregate fields (analytics binding is authored via the dataset picker). - tests: migrate p1-spec-alignment + DashboardRenderer.filters fixtures to the dataset shape; filters test now asserts DatasetWidget's queryDataset runtimeFilter. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the dashboard analytics migration (framework#3251 · objectui#2703 · strict flip #3316). Authoring already emits only the semantic-layer shape (
dataset+dimensions+values); this retires the renderer's now-unauthored legacy read-branches and drops the@deprecatedtype keys.Closes objectstack-ai/objectstack#3320.
Precondition audit (the blocking item) — clean
No traceable producer still emits the inline-analytics keys:
app-crm,app-todo,app-showcase) + thesystem_overviewplatform built-in: 100%dataset-shaped, zero legacy widget keys..dashboard.ts; the AI-studio blueprint emitter producesdataset/dimensions/values.plugin-designer/DashboardEditor.tsxwas a live authoring surface that feat(dashboard): Studio 只授权 ADR-0021 dataset 形态 (framework#3251) #2703 missed (still emitted inlineobject/valueField/aggregate). Its legacy fields are stripped here so it stops producing legacy keys.Changes
@deprecatedinline-analytics keys (object,categoryField,categoryGranularity,valueField,aggregate,measures) fromDashboardWidgetSchema.DashboardRendererno longer emits the object-bound metric/chart/pivot/table/list branches; removes theobject-keyedobjectFieldSetsmachinery. It keeps the renderer-internal static paths (options.data/widget.dataarray +provider:'object') andwidget.component. It no longer emitsobject-pivot/pivot— dataset pivots render viaDatasetWidget(grouped table / cross-tab);ObjectPivotTable/PivotTablestay as public SDUI blocks.DashboardGridLayoutgets the same treatment.object, nodataset, no inlineoptions.data) now renders a visible error placeholder prompting a rebind to a dataset, rather than a blank.DashboardEditordrops its inline object / value-field / aggregate fields (analytics binding is authored via the dataset picker in app-shell'sDashboardWidgetInspector/ plugin-dashboard'sWidgetConfigPanel).p1-spec-alignment+DashboardRenderer.filtersfixtures to the dataset shape (filters now assertsDatasetWidget'squeryDatasetruntimeFilter); addDashboardRenderer.legacyRetiredcovering the placeholder + the kept static/dataset paths.Two judgment calls for review
table/listobject-bound branches retired too — beyond checkbox‑1's literal enumeration (metric/chart/pivot), but forced by droppingobjectfrom the type. Capability is preserved viaoptions.dataprovider:'object'+DatasetWidget; the placeholder catches stale metadata.pivotemission stopped as well — per checkbox 2 ("stop the dashboard renderer from emitting them"), a non-dataset pivot now shows the placeholder rather than a staticPivotTable.Verification
@object-ui/typestsc --noEmitclean;plugin-dashboard/plugin-designerbuilds (tsc dts) clean.DashboardRenderer.filters(5/5),DashboardRenderer.legacyRetired(6/6),DatasetWidget(41/41),dashboard-config(16/16),p1-spec-alignmentdataset tests.data-objectstackexportDownload.test.tstype-check failure is unrelated (unchanged vsmain, no dashboard-type dependency).🤖 Generated with Claude Code