feat(report)!: drop SpecReportColumn/SpecReportGrouping re-exports + retire legacy ReportViewer chart fallback (#3463)#2816
Merged
Conversation
…retire the legacy ReportViewer chart fallback (#3463)
Cross-repo close-out of the ADR-0021 report cleanup (framework #3463). Upstream
@objectstack/spec removed the dead ReportColumnSchema / ReportGroupingSchema and
the unread report chart.groupBy; this drops their objectui mirrors and the
now-orphaned legacy report chart path.
- types: removed the SpecReportColumn / SpecReportColumnInput / SpecReportGrouping
/ SpecReportGroupingInput type re-exports and the SpecReportColumnSchema /
SpecReportGroupingSchema value re-exports (they aliased the deleted upstream
symbols). The live shape is dataset-bound: SpecReport with dataset + values
(measure names) + rows/columns (dimension names).
- app-shell: ReportView now renders every report through the spec ReportRenderer
dispatcher (dataset -> DatasetReportRenderer, stored pre-9.0 JSON -> bridge,
pre-spec { data, columns } -> LegacyReportRenderer). Deleted the ReportViewer
last-resort branch, the mapReportForViewer spec->legacy chart-section adapter
(sole producer of xAxisField/yAxisFields), and the now-dead data-fetch loading
flag. No shipped report metadata reached the removed branch.
- plugin-report: removed the ReportViewer chart-section branch. It read the
invented xAxisField/yAxisFields (never the spec's xAxis/yAxis) and was only
fed by the deleted mapReportForViewer. ReportViewer itself is retained -- its
table/summary/text sections back the report-viewer component + pre-9.0 bridge.
Browser-verified against the showcase backend: the summary, matrix and joined
reports all render through DatasetReportRenderer unchanged.
Refs #3463
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to framework PR objectstack-ai/objectstack#3488. Refs objectstack-ai/objectstack#3463 (item 2 — the objectui-side retirement).
Context
Upstream
@objectstack/specremoved the deadReportColumnSchema/ReportGroupingSchemaand the unread reportchart.groupBy(framework #3488). This PR drops their objectui mirrors and retires the now-orphaned legacy report chart path. Independent of the spec bump: objectui keeps compiling against published spec 16.x — it only stops re-exporting the removed symbols.What changed
SpecReportColumn/SpecReportColumnInput/SpecReportGrouping/SpecReportGroupingInputtype re-exports and theSpecReportColumnSchema/SpecReportGroupingSchemavalue re-exports from@object-ui/types. The live report shape is dataset-bound:SpecReportwithdataset+values(measure names) +rows/columns(dimension names).ReportViewnow renders every report through the specReportRendererdispatcher (dataset →DatasetReportRenderer, stored pre-9.0 JSON → presentation bridge, pre-spec{ data, columns }→LegacyReportRenderer). Deleted theReportViewerlast-resort branch, themapReportForViewerspec→legacy chart-section adapter (the sole producer ofxAxisField/yAxisFields), and the now-dead data-fetch loading flag. No shipped report metadata reached the removed branch — the Studio inspector only ever writes the dataset-bound shape.ReportViewerchart-section branch. It read the inventedxAxisField/yAxisFields(never the spec'sxAxis/yAxis) and was only fed by the deletedmapReportForViewer.ReportVieweritself is retained — its table/summary/text sections still back thereport-viewerregistered component and the pre-9.0 presentation bridge.Net: −248 / +10 lines across 5 files.
Migration
Nothing an author writes changes. TypeScript consumers importing
SpecReportColumn*/SpecReportGrouping*from@object-ui/typeshave no replacement type — model report columns as the dataset's measure names and grouping as its dimension names.Verification
turbo build(types → plugin-report → app-shell + deps, 60 tasks) clean; app-shell builds viatsc.turbo type-checkacross@object-ui/types+ all dependents — 60/60 clean.spec-ui-schema-reexportstest pass.DatasetReportRenderer;/api/v1/meta/report+/api/v1/analytics/dataset/queryall 200.🤖 Generated with Claude Code