fix(ci): stop the eager-closure gate header restating its ceiling and baseline - #9076
Merged
Merged
Conversation
… baseline The header note that says which constant is which stated both of them as MiB literals and then explained, correctly and at length, why the two figures were consistent with each other. The maintainer-authorised re-baseline of objectui#7685 moved both constants in `639114c4d`; the prose stayed. For four days and three subsequent edits to this file the note rendered the RETIRED pair — explaining the consistency of two numbers neither of which was in force — and nothing anywhere went red, because nothing fails on a number written in a comment. Refreshing the two literals would have restarted that clock, inside the very header that argues at length against copied numbers. So the note names its subjects and renders neither: `BASELINE` carries the measured payload, `MAX_EAGER_CLOSURE_GZIP_BYTES` is the ceiling standing over it, both a few lines below in bytes and each pinned to the commit it was measured on, and the gate's verdict line prints the live reading on every run. Saying which is which — all objectui#7528 ever asked of this paragraph — survives intact. The "Raising it" instruction moves with it: it asked for the measured figure in this comment to be updated, and after this change the header carries no such figure. It now points at the prose attached to the constant, which is where the figure lives and where the objectui#7046 pin already checks it. Second half, the durable one: a pin that refuses a rendered size written back into that note. It is deliberately NOT a widening of the chunk-count pin into a size pin — that trade was weighed and declined where it lives, for a reason that still holds. Its population is the two named paragraphs, which carry no size at all; the anchored measurements elsewhere in the header are outside it and unchanged. The region is located by its opening and closing sentences, both asserted present and unique, with a length floor and a positive control, so an empty scan is a reading rather than a silence. No constant, ceiling, baseline, floor, allowance or grain moved, and no existing pin, threshold or assertion was weakened. Fixes #8964 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FhBNJcLRZLe8M87VcUgpKr
Contributor
✅ Console Performance Budget
The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it. 📦 Bundle Size Report
Size Limits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8964
What was false
The module header of the eager-closure gate carried a note that said WHICH constant is which — and stated both of them as MiB literals while doing it. The maintainer-authorised re-baseline of objectui#7685 moved both constants; the prose stayed. For four days and three subsequent edits to that file the note rendered the RETIRED pair, explaining at length why two figures neither of which was in force were consistent with each other, and nothing anywhere went red.
Verified on
c3a427378before touching anything, and every premise the dispatch listed held:What this does
⛔ Not a refresh of the two literals. That is the one shape the ruling rules out, it is what was done last time, and it would have restarted the clock inside the very header that argues at length against copied numbers.
Instead the note names its subjects and renders neither.
BASELINEcarries the measured payload,MAX_EAGER_CLOSURE_GZIP_BYTESis the ceiling standing over it, both a few lines below in bytes and each pinned to the commit it was measured on, and the gate's verdict line prints the live reading on every run. Saying which is which — all objectui#7528 ever asked of this paragraph — survives intact. This is the shape objectui#8606 and objectui#8629 each landed today: delete the copy, point at the instrument.One consequential sentence moves with it. The "Raising it" instruction asked for the measured figure in this comment to be updated on a re-baseline; after this change the header carries no such figure, so it now points at the prose attached to the constant, which is where the figure lives and where objectui#7046's pin already checks it.
The durable half — a pin that can fail
A new pin refuses a rendered size written back into that note.
The region is located by its opening and closing sentences, both asserted present and unique, with a length floor and a positive control, so an empty scan is a reading rather than a silence.
Shown red, twice, then restored by hash. Both legs mutated the committed file on disk (proved by blob hash before and after, not by an exit code), ran the suite, and restored with
git checkout HEAD -- path, proved by blob equality against the HEAD blob plus an emptygit diff HEAD:Tests 1 failed, 123 passed — only the new pin fired, with its own message naming the figureTests 2 failed, 122 passed — the silence leg fires first, so a rewrite cannot turn the pin green by emptying itRestored state after each: disk blob
84b9ea784913ad41e46cff5fa23033b2bb29d7b2equals the HEAD blob,git diff HEADempty,git statusclean.Verification, on the final commit
1da8bca86vitest run scripts/__tests__/check-eager-closure-budget.test.ts—Test Files 1 passed,Tests 124 passed (124).Test Files 6 passed (6),Tests 326 passed (326).tsc -p tsconfig.scripts.json— exit 0, and--listFilesconfirms the edited test file is in that program, so this is a measurement rather than an assumption.check:control-bytes—OK (scanned 7264 tracked text file(s); skipped 85 binary).check:new-line-citations—0 new citation(s).check:comment-mask-corpus— exit 0,1 file(s) disagree, within the residue objectui#7882 is holding open, unchanged by this diff.check-changeset-presence.mjs— exit 0: "No source or published contract of a released package changed in this range, so no changeset is owed." A changeset with empty frontmatter is included anyway, declaring no release explicitly;check-changeset-no-major.mjsexit 0.check-governed-queue-guard.mjs --teston all three paths —NOT GOVERNED.--no-inline-config,--format json: 2 files linted, 0 errors, 0 warnings. Narrowed from the repo-wide run deliberately, and the narrowing is a measurement: the file count is read from eslint's own JSON output, and this repository enables no type-aware linting, so a comment-only edit in these two files cannot move the verdict on any file it did not touch.c3a427378, prettier appears in no workflow and in no eslint config here, so this is pre-existing and unenforced. ⛔ Not "fixed" in passing: reformatting either file would bury a comment-only diff under unrelated churn.Boundaries held
No constant, ceiling, baseline, floor, allowance or grain moved — the diff is comments plus one new test block plus a changeset. Nothing objectui#8554 landed in this file is touched, no existing pin, threshold or assertion is weakened, no test is skipped, disabled or quarantined, and
content/docs/releases/is untouched.Merged
origin/mainbefore opening: the branch is cut fromc3a427378andgit merge origin/mainreports already up to date.🤖 Generated with Claude Code
https://claude.ai/code/session_01FhBNJcLRZLe8M87VcUgpKr
Generated by Claude Code