Add per-test fieldcompare tolerance and skip_compare#847
Merged
MakisH merged 12 commits intoJun 29, 2026
Conversation
Allow overriding fieldcompare rtol via tests.yaml and optionally skip the compare step. Re-enable previously quarantined tests with tolerance 1e-2 for near-zero exported fields.
Wrap long tolerance/skip_compare lines so check_style pre-commit passes.
MakisH
changed the title
MakisH
reviewed
Jun 23, 2026
MakisH
left a comment
MakisH
left a comment
Member
There was a problem hiding this comment.
Thanks for implementing!
Here are some comments to apply before testing on GHA.
This was referenced Jun 23, 2026
Sort re-enabled tests alphabetically, apply README/changelog wording, drop compare settings from generate_reference_results, and simplify skip_compare logging.
MakisH
reviewed
Jun 28, 2026
Member
There was a problem hiding this comment.
Test on GHA - state:
- the two-phase-heat-conduction cases fail to build the
micro-dumuxparticipant. This is irrelevant, I will investigate. -> See #852 -> results again have a too large range, but the feature works - disabled comparisons for now, see #393 for a potential solution. - the
Elastic tube 3D (fluid-openfoam, solid-fenics)case passes, but running takes long, and comparing takes even longer. Maybe this just happened once, I will investigate. -> See #853 -> disabled the comparisons for this case (test)
Resolve Systemtest.py conflict: keep build_timeout defaults from develop (precice#848) and fieldcompare tolerance/skip_compare from precice#847.
MakisH
approved these changes
Jun 29, 2026
Member
There was a problem hiding this comment.
I did some more tests and adjustments, and opened a few issues.
The two-scale-heat-conduction case was not running. It runs now, but the results are still not covered by a larger tolerance. See #393 (comment) for a potential solution.
The elastic-tube-3d/solid-fenics takes too long to compare, so I have disabled the comparison of that one as well for now.
I added the following to the release test suite:
- elastic-tube-3d_fluid-openfoam_solid-fenics
- two-scale-heat-conduction_macro-dumux_micro-dumux
and the following to the extra:
- two-scale-heat-conduction_macro-nutils_micro-nutils (will not work before the next release of the micro-manager)
PranjalManhgaye
added a commit
to PranjalManhgaye/tutorials
that referenced
this pull request
Jun 30, 2026
Integrate latest develop (precice#847 tolerance/skip_compare, precice#848, precice#852, etc.) and resolve TestSuite.py conflict while keeping external: tutorial support. Set skip_compare on external suite entries now that precice#847 is merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
closes #837
i added optional tolerance and skip_compare fields in tests.yaml so we can override fieldcompare rtol per test (or skip compare entirely if we only care about build + run).
before this we had some tests stuck in expected-to-fail or commented out in component suites because exported vtk values are tiny and the default 3e-7 rtol basically always fails. now those cases use tolerance: 1e-2 instead.
what changed
tests without tolerance still use the default 3e-7 so behavior for everything else should be the same.
local testing
i tried to run things locally on my machine , elastic-tube-3d (fluid-openfoam + solid-fenics) : full build / run / fieldcompare pass with -rtol 0.01 (32/32 comparisons) , this is the main case we cared about for this issue.
macro-nutils_micro-nutils : reference tarball doesn’t exist on develop yet so i couldn’t validate that one end-to-end
so yeah locally we’ve got solid proof for the fenics case ; the rest we’ll need ci .
notes for reviewers
would be great to trigger system tests on fenics-adapter, openfoam-adapter, micro-manager, dumux-adapter (and nutils-adapter once the nutils reference exists)
macro-nutils_micro-nutils is re-enabled in yaml but the reference file might still be missing upstream : heads up if ci complains there
happy to tweak tolerance values if 1e-2 is too loose or too tight for any of the three cases ,,