fix(feedback): serialize and validate legacy feedback - #10
Merged
Conversation
Collaborator
Author
|
Validation update at 9ee17e0: the initial CI run 34000638102 retained four existing metadata-fixture failures because OpenAI 3.8.0 defaults to httpx2 while respx mocks httpx. The four metadata tests now explicitly inject supported httpx sync/async clients, preserving assertions and cleanup; production transport and dependency declarations are unchanged. OpenAI 3.8.0 installed source explicitly accepts both httpx and httpx2 clients. A clean current-dependency environment now passes all 302 tests, Ruff lint/format and mypy. Hosted matrix rerun remains the merge gate; no release or delivered-version runtime claim. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #9.
Validation
Scope: approved A1 correctness repair described by #9. No merge or publication requested by this PR creation.