Map transport failures to grpc-ruby errors - #9
Merged
samuel-williams-shopify merged 4 commits intoSep 24, 2026
Merged
Conversation
Connection, DNS, TLS, and HTTP/2 connection failures now raise `GRPC::Unavailable`, and HTTP/2 stream resets use gRPC's HTTP/2 status mapping. The original exception is preserved as the cause, so retry policies such as GAPIC's `UNAVAILABLE` retries apply. The gRPC response body treats a failed stream as empty, so wrap it to ensure stream errors are raised rather than reported as a missing status. Fixes socketry#5. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5.
Transport failures escaped
ClientStub#request_responseas raw Ruby exceptions (Errno::ECONNREFUSED,EOFError,OpenSSL::SSL::SSLError, …), breaking code written against grpc-ruby's contract that every failure is aGRPC::BadStatus, such as GAPIC'sUNAVAILABLEretry policies.Changes
GOAWAYand refused requests) raiseGRPC::Unavailable.REFUSED_STREAM→Unavailable,CANCEL→Cancelled,ENHANCE_YOUR_CALM→ResourceExhausted,INADEQUATE_SECURITY→PermissionDenied, and other reported stream errors →Internal.error.cause, and deferred operations record the status.~> 0.17, which preserves underlying body read errors (upstream fix). Transport errors propagate directly without a response-body wrapper.TLS verification failures previously raised
OpenSSL::SSL::SSLErrorand now raiseGRPC::Unavailable, matching grpc-ruby; the TLS tests are updated accordingly.Testing
🤖 Generated with Claude Code