Preserve underlying body read errors - #18
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A failed HTTP body can report
empty?while its nextreadraises the pending error. The gRPC reader skipped that read, hiding failures as EOF or replacing them with misleading truncated-frame errors. Read untilnilinstead and propagate the original exception unchanged, while preserving clean EOF and truncated-frame handling.Add regression coverage for failed empty bodies, partial prefixes, missing/partial payloads, and failures while finishing after a complete message. All five error regressions fail before the fix.
This supplies the shared reader fix needed to remove the
ResponseBodyworkaround in async-grpc-compatible#9.Validation on Ruby 4.0.7:
ResponseBodyworkaround removed: 122 tests, 436 assertions.