fix: shorten GetPipeName() output causing Unix crash - #2579
Closed
Thundernerd wants to merge 1 commit into
Closed
Conversation
Contributor
|
Sorry for not considering the length limit when making this change in the first place. One follow-up thought: would it make sense to also shorten the hash from 16 characters to something like 8 characters? That would give us even more headroom against the Unix domain socket path length limit, while still keeping the collision probability low enough for normal use cases. Thanks for the fix! |
Author
|
@JC-Chung no worries, it happens! Shortening the hash would definitely help yes. I think anything that can be shortened will help :D |
Contributor
|
The target branch should be |
Author
|
Closing in favor of #2585 with correct target branch, unable to modify it in this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a hotfix to combat the hard crash on unix machines which was introduced by e0e2ab6
On Unix machines the NamedPipeServerStream is created with a
Path.GetTempPath()and "CoreFXPipe_" prefix, causing the recent change to go over the maximum length of the pipename of 104 characters: dotnet Unix PipeStream sourcecode.Note
In the case of a long username this can still break as we now add an extra 16 characters from the hash to this pipe name.
Closes #2576