fix: shorten GetPipeName() output - #2585
Open
Thundernerd wants to merge 4 commits into
Open
Conversation
Author
|
Like @JC-Chung suggested, reduced the hash length to 8 characters. |
Contributor
That problem can be totally eliminated if include the user name in hash. What the point to keep it readable in this internal name? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redo of #2579 with correct target branch.
This is a hotfix to combat the hard crash on unix machines which was introduced by e0e2ab6
On Unix machines the NamedPipeServerStream is created with a
Path.GetTempPath()and "CoreFXPipe_" prefix, causing the recent change to go over the maximum length of the pipename of 104 characters: dotnet Unix PipeStream sourcecode.Note
In the case of a long username this can still break as we now add an extra 16 characters from the hash to this pipe name.
Closes #2576