Skip to content

chore(deps): raise nanoid floors, drop unused declarations - #4637

Merged
nicktrn merged 1 commit into
mainfrom
chore/bump-nanoid
Aug 16, 2026
Merged

chore(deps): raise nanoid floors, drop unused declarations#4637
nicktrn merged 1 commit into
mainfrom
chore/bump-nanoid

Conversation

@nicktrn

@nicktrn nicktrn commented Aug 16, 2026

Copy link
Copy Markdown
Collaborator

Summary

nanoid was pinned at exactly 3.3.8 in five manifests. Two of those five never imported it: in internal-packages/schedule-engine and internal-packages/webhook-engine the only occurrence of the string nanoid in the entire package was the package.json line itself. Both are removed rather than bumped.

The three that genuinely use it move to 3.3.18, a version already present in the tree via postcss, so this pulls in nothing new.

Package Uses it Change
internal-packages/schedule-engine no removed
internal-packages/webhook-engine no removed
apps/webapp yes 3.3.8 to 3.3.18
packages/core yes 3.3.8 to 3.3.18
internal-packages/run-engine yes 3.3.8 to 3.3.18
packages/redis-worker yes ^5.0.7 to ^5.1.16

redis-worker is on the 5.x line and is included because its declared range already permitted a newer release; the lockfile had simply not re-resolved, leaving it on 5.1.2.

The unused declarations were found with pnpm run knip:deps, which the repo already ships.

pnpm run typecheck passes across all 57 workspaces.

@nicktrn nicktrn self-assigned this Aug 16, 2026
@changeset-bot

changeset-bot Bot commented Aug 16, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 5c531a7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3407c655-71ba-4c11-85ad-3d5e98952ffb

📥 Commits

Reviewing files that changed from the base of the PR and between 148615b and 5c531a7.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (6)
  • apps/webapp/package.json
  • internal-packages/run-engine/package.json
  • internal-packages/schedule-engine/package.json
  • internal-packages/webhook-engine/package.json
  • packages/core/package.json
  • packages/redis-worker/package.json
💤 Files with no reviewable changes (2)
  • internal-packages/schedule-engine/package.json
  • internal-packages/webhook-engine/package.json

Included review availability: Your plan includes up to 10 reviews per rolling hour; 9 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (35)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (6, 12)
  • GitHub Check: e2e / 🧪 CLI v3 tests (warp-windows-latest-x64-8x - pnpm)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (7, 12)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (2, 12)
  • GitHub Check: e2e / 🧪 CLI v3 tests (warp-ubuntu-latest-x64-4x - pnpm)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (10, 12)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (9, 12)
  • GitHub Check: sdk-compat / Node.js 24.18 (warp-ubuntu-latest-x64-4x)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (11, 12)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (8, 12)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (5, 12)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (12, 12)
  • GitHub Check: sdk-compat / Bun Runtime
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (3, 12)
  • GitHub Check: sdk-compat / Node.js 22.23 (warp-ubuntu-latest-x64-4x)
  • GitHub Check: e2e / 🧪 CLI v3 tests (warp-windows-latest-x64-8x - npm)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (1, 12)
  • GitHub Check: internal / 🧪 Unit Tests: Internal
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (4, 12)
  • GitHub Check: sdk-compat / Deno Runtime
  • GitHub Check: e2e / 🧪 CLI v3 tests (warp-ubuntu-latest-x64-4x - npm)
  • GitHub Check: sdk-compat / Node.js 20.20 (warp-ubuntu-latest-x64-4x)
  • GitHub Check: packages / 🧪 Unit Tests: Packages (3, 3)
  • GitHub Check: sdk-compat / Node.js 26.4 (warp-ubuntu-latest-x64-4x)
  • GitHub Check: packages / 🧪 Unit Tests: Packages (2, 3)
  • GitHub Check: sdk-compat / Cloudflare Workers
  • GitHub Check: fk-cascade-guard / fk-cascade-guard
  • GitHub Check: packages / 🧪 Unit Tests: Packages (1, 3)
  • GitHub Check: e2e-webapp / 🧪 E2E Tests: Webapp
  • GitHub Check: runops-guard / runops-guard
  • GitHub Check: typecheck / typecheck
  • GitHub Check: code-quality / code-quality
  • GitHub Check: audit
  • GitHub Check: audit
  • GitHub Check: Analyze (javascript-typescript)
🧰 Additional context used
📓 Path-based instructions (2)
apps/webapp/**/package.json

📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)

For the webapp, never run pnpm run build --filter webapp to verify changes; use pnpm run typecheck --filter webapp after major changes. Public packages under packages/* use build instead.

Files:

  • apps/webapp/package.json
**/package.json

📄 CodeRabbit inference engine (AGENTS.md)

Adding dependencies: Edit package.json directly instead of using pnpm add, then run pnpm i from the repo root.

Files:

  • apps/webapp/package.json
  • packages/redis-worker/package.json
  • packages/core/package.json
  • internal-packages/run-engine/package.json
🧠 Learnings (1)
📚 Learning: 2026-04-27T16:46:03.861Z
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3456
File: apps/webapp/package.json:152-152
Timestamp: 2026-04-27T16:46:03.861Z
Learning: In `apps/webapp/package.json`, treat the `effect` npm package as an intentional runtime dependency (not unused/misplaced) for the Schedule + Fiber-based metadata update logic. This should apply when reviewing `apps/webapp` code paths used by `apps/webapp/app/utils/updateMetadata.server.ts` (and closely related modules) that use Effect APIs such as `Duration.divide`, `STM.cond`, namespace exports for `Effect`/`Schedule`/`Duration`/`Fiber`, and the `Fiber.RuntimeFiber` type.

Applied to files:

  • apps/webapp/package.json
🔇 Additional comments (4)
apps/webapp/package.json (1)

173-173: LGTM!

internal-packages/run-engine/package.json (1)

32-32: LGTM!

packages/core/package.json (1)

225-225: LGTM!

packages/redis-worker/package.json (1)

28-28: LGTM!


Walkthrough

Updated nanoid dependency versions in the webapp, run-engine, core, and redis-worker packages. Removed the nanoid runtime dependency from the schedule-engine and webhook-engine packages.

Merge Risk: ⚪ Minimal · up to 5c531

This change updates dependency versions and removes unused declarations; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the changes and testing, but it omits the required issue, checklist, Changelog, and Screenshots sections. Add the required template sections, complete the checklist, reference the issue, and provide changelog and screenshot entries or state that they are not applicable.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the dependency version updates and removal of unused declarations.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/bump-nanoid

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@nicktrn
nicktrn merged commit f3c46f1 into main Aug 16, 2026
55 checks passed
@nicktrn
nicktrn deleted the chore/bump-nanoid branch August 16, 2026 21:12
nicktrn added a commit that referenced this pull request Aug 16, 2026
## Summary

The existing `ip-address` override is scoped to a single parent,
`@jsonhero/json-infer-types>ip-address`. A second parent reaches
`ip-address` independently: `express-rate-limit@8.6.0`, which is itself
pinned by our `@modelcontextprotocol/sdk@>=1.26.0>express-rate-limit`
override. That path was resolving `10.2.0` while the scoped path
resolved `10.5.0`, so the tree carried two copies.

This adds a matching scoped override for the second parent:

```json
"express-rate-limit>ip-address": "^10.3.1"
```

`express-rate-limit` declares `^10.2.0`, so this asks nothing of it that
its own range did not already allow. The tree now resolves a single
`ip-address@10.5.0`.

The existing `@jsonhero/json-infer-types` override stays: that package
declares `ip-address: ^8.1.0`, so removing it brings an 8.x copy back.

Stacked on #4637.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants