Skip to content

chore(deps): cover the second ip-address parent - #4638

Merged
nicktrn merged 1 commit into
chore/bump-nanoidfrom
chore/bump-ip-address
Aug 16, 2026
Merged

chore(deps): cover the second ip-address parent#4638
nicktrn merged 1 commit into
chore/bump-nanoidfrom
chore/bump-ip-address

Conversation

@nicktrn

@nicktrn nicktrn commented Aug 16, 2026

Copy link
Copy Markdown
Collaborator

Summary

The existing ip-address override is scoped to a single parent, @jsonhero/json-infer-types>ip-address. A second parent reaches ip-address independently: express-rate-limit@8.6.0, which is itself pinned by our @modelcontextprotocol/sdk@>=1.26.0>express-rate-limit override. That path was resolving 10.2.0 while the scoped path resolved 10.5.0, so the tree carried two copies.

This adds a matching scoped override for the second parent:

"express-rate-limit>ip-address": "^10.3.1"

express-rate-limit declares ^10.2.0, so this asks nothing of it that its own range did not already allow. The tree now resolves a single ip-address@10.5.0.

The existing @jsonhero/json-infer-types override stays: that package declares ip-address: ^8.1.0, so removing it brings an 8.x copy back.

Stacked on #4637.

@nicktrn nicktrn self-assigned this Aug 16, 2026
@changeset-bot

changeset-bot Bot commented Aug 16, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: b95e328

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ccd4b6b4-23f9-4fc6-88d7-9a7033abbe84

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@nicktrn
nicktrn merged commit b4f7800 into main Aug 16, 2026
55 checks passed
@nicktrn
nicktrn deleted the chore/bump-ip-address branch August 16, 2026 21:12
nicktrn added a commit that referenced this pull request Aug 16, 2026
## Summary

`find-my-way` was resolving `9.3.0` even though its only parent,
`fastify@5.8.5`, declares `^9.0.0` and so already permitted a newer
release. The lockfile had not re-resolved since. This adds a floor so it
lands on a current 9.x:

```json
"find-my-way@>=9 <9.7.0": "^9.7.0"
```

It resolves to `9.7.0`. Nothing outside the 9.x line is touched, and no
parent is asked to accept anything its declared range did not already
allow.

The whole path is development only: `find-my-way` arrives through
`fastify`, which arrives through `evalite`, a devDependency of
`apps/webapp` used by the `eval:dev` harness.

Stacked on #4638.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants