Skip to content

fix(webapp): associate model administration labels - #4694

Merged
carderne merged 1 commit into
fix/webapp-a11y-text-and-roles-tri-13381from
fix/webapp-admin-form-labels-tri-13381
Aug 19, 2026
Merged

fix(webapp): associate model administration labels#4694
carderne merged 1 commit into
fix/webapp-a11y-text-and-roles-tri-13381from
fix/webapp-admin-form-labels-tri-13381

Conversation

@carderne

@carderne carderne commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Summary

Associate internal model administration labels with their form controls.

The model editor, creator, and tester now use explicit htmlFor and id pairs. Section titles that do not label controls now use headings instead of label elements.

Base: #4693

@changeset-bot

changeset-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 77b8db0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 886f37c6-d889-41b6-b40b-3aa870f2721c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@carderne
carderne marked this pull request as ready for review August 19, 2026 11:23

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@carderne
carderne force-pushed the fix/webapp-admin-form-labels-tri-13381 branch 2 times, most recently from fa78ffd to ea7dd44 Compare August 19, 2026 11:49
@carderne
carderne force-pushed the fix/webapp-admin-form-labels-tri-13381 branch from ea7dd44 to 77b8db0 Compare August 19, 2026 14:54
@pkg-pr-new

pkg-pr-new Bot commented Aug 19, 2026

Copy link
Copy Markdown

Open in StackBlitz

@trigger.dev/build

npm i https://pkg.pr.new/@trigger.dev/build@77b8db0

trigger.dev

npm i https://pkg.pr.new/trigger.dev@77b8db0

@trigger.dev/core

npm i https://pkg.pr.new/@trigger.dev/core@77b8db0

@trigger.dev/python

npm i https://pkg.pr.new/@trigger.dev/python@77b8db0

@trigger.dev/react-hooks

npm i https://pkg.pr.new/@trigger.dev/react-hooks@77b8db0

@trigger.dev/redis-worker

npm i https://pkg.pr.new/@trigger.dev/redis-worker@77b8db0

@trigger.dev/rsc

npm i https://pkg.pr.new/@trigger.dev/rsc@77b8db0

@trigger.dev/schema-to-json

npm i https://pkg.pr.new/@trigger.dev/schema-to-json@77b8db0

@trigger.dev/sdk

npm i https://pkg.pr.new/@trigger.dev/sdk@77b8db0

commit: 77b8db0

@carderne
carderne merged commit 3ffd123 into main Aug 19, 2026
39 checks passed
@carderne
carderne deleted the fix/webapp-admin-form-labels-tri-13381 branch August 19, 2026 15:36
carderne added a commit that referenced this pull request Aug 19, 2026
## Summary

Finish associating dashboard form labels with their controls and enforce
`jsx-a11y/label-has-associated-control`.

Repeated data store dialogs use unique generated IDs, story controls and
notification filters have explicit associations, and display-only status
text no longer uses label elements.

Base: [#4694](#4694)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants