feat: make support error-report emails legible, add a version 2 report, and fix #835 items 1-2

[jcschaff]

Closes #1495. Addresses items 1 and 2 of #835.

The problem

An error report reaches vcell_support@uchc.edu as the raw JSON it was posted in: one line, every newline a literal \n, every apostrophe a '.

Five real messages, read-only from the support mailbox: 112 KB, 136 KB, 138 KB, 188 KB, 434 KB — each a single line.

Most of that is duplication. DialogUtils built the report as new RuntimeException(supplemental, exception), so the client log became the wrapper's message and landed twice — as exceptionMessage and again at the head of stackTrace. On one 124 KB report:

	chars
body	123,975
client log, carried twice	116,558 — 94%
actual exception chain + frames	7,417

Frames began at line 219, past 58,000 characters. And because the report was wrapped, the stack trace was the wrapper's — rooted at DialogUtils:766, with the real fault demoted to a Caused by:.

Changes

1. Render the email as text (server side). Header (user, version, platform) plus headed sections. For reports from existing clients it also removes the duplicate log, leaving a marker where the stack trace had inlined it.

2. A version 2 report (client side). Each part gets its own field — modelInfo, clientLog, userEvents — and the exception is sent as thrown. A reportVersion field marks the form; the server renders both, so neither side deploys in lockstep.

3. #835 item 1 — users can say what they were doing. An optional one-line field in the error dialog. A log records what VCell did; only the user can say what they were trying to do. Empty sends exactly as before.

4. #835 item 2 — reports identify the reporter. ErrorUtils was told who was logged in once, at startup, from the command-line user name — normally absent, since people log in through the dialog. Every report was therefore anonymous. It is now told again on each successful connect.

5. The error dialog always has an owner. LWNamespace.findLWOwner returns null when no ancestor implements LWContainerHandle (it logs an error when that happens, so it does). AWT downgrades DOCUMENT_MODAL to modeless when the owner is null, so the error dialog would neither block the window that raised it nor stay in front of it — one way an error ends up behind the main window. findLWOwnerOrMostRecent falls back to the most recently focused visible top-level window.

Result on the real report

	before	after
body	123,975 chars	66,196
lines	1	1,106
first frame	past 58,000 chars	first screen

The dialog, rendered from the built classes:

Cannot invoke "cbit.vcell.mapping.ElectricalTopology.getGroundElectrode()"

What were you doing? (optional)  [________________________]

Send error report to VCell development team to assist debugging?   [?]

Tests

ErrorUtilsTest 3 → 14. The 3 existing JSON round-trip cases pass unchanged — the check that the wire format still serialises as before. New cases cover field rendering, the body not being one long line, CRLF normalisation, missing fields, a multi-line platform staying on its header line, the legacy log appearing exactly once with frames ahead of it, a short exception message left alone, and the v2 form.

Not addressed

• Error Reports from Contact-Us improvements #835 item 3 (include database transactions).
• The subject line stays "VCell Support sent through Contact-Us". Including the exception type would make the inbox scannable, but these are forwarded by a mail rule that may match the exact subject — worth checking the rule first.

🤖 Generated with Claude Code

https://claude.ai/code/session_01FUd61NUJgz88h4PZs5MqHn