Skip to content

Support wide decimals in DecimalBytePartsArray and kernels #9809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mhk197 wants to merge 9 commits into from
Open

Support wide decimals in DecimalBytePartsArray and kernels #9809

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
38a1dee
Support multi-part decimal arrays and kernels
mhk197 Sep 8, 2026
c4c7877
Simplify decimal byte-parts array helpers
mhk197 Sep 9, 2026
e30bd99
Share decimal value assembly and validate lower-part dtypes
mhk197 Sep 9, 2026
6a7b033
Validate required decimal byte-parts slots before typed access
mhk197 Sep 9, 2026
a20094e
fix comment
mhk197 Sep 9, 2026
38b5bc4
QOL and perf changes for splitting
mhk197 Sep 10, 2026
df7cbfc
comment fix
mhk197 Sep 10, 2026
b2e49fb
reorg
mhk197 Sep 10, 2026
18b8b99
comments
mhk197 Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ coverage.xml
*.cover
*.py,cover
.hypothesis/
# hegeltest's example database, the Rust equivalent of .hypothesis/
.hegel/
.pytest_cache/
cover/

Expand Down
85 changes: 83 additions & 2 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,7 @@ glob = "0.3.2"
goldenfile = "1"
half = { version = "2.7.1", features = ["std", "num-traits"] }
hashbrown = "0.17.1"
hegeltest = "0.28.7"
http = "1.5.0"
humansize = "2.1.3"
indicatif = "0.18.0"
Expand Down
2 changes: 2 additions & 0 deletions encodings/decimal-byte-parts/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,11 @@ vortex-session = { workspace = true }

[dev-dependencies]
divan = { workspace = true }
hegeltest = { workspace = true }
rand = { workspace = true }
rstest = { workspace = true }
vortex-array = { path = "../../vortex-array", features = ["_test-harness"] }
vortex-bench-support = { workspace = true }

[[bench]]
name = "dbp_assemble"
Expand Down
1 change: 1 addition & 0 deletions encodings/decimal-byte-parts/benches/dbp_assemble.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ fn main() {
divan::main();
}

#[vortex_bench_support::cpu_features]

@joseph-isaacs joseph-isaacs Sep 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you do this over the kernel working with [T] not vortex arrays. This is more noisy so it would be nice to only run if over small loops with allocs

#[divan::bench(args = cases())]
fn dbp_assemble(bencher: Bencher, (values_type, len): (DecimalType, usize)) {
let decimal = decimal_array(values_type, len, Validity::NonNullable);
Expand Down
8 changes: 8 additions & 0 deletions encodings/decimal-byte-parts/benches/dbp_split.rs
View file
Open in desktop

@joseph-isaacs joseph-isaacs Sep 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,19 @@ fn main() {
divan::main();
}

#[vortex_bench_support::cpu_features]
#[divan::bench(args = cases())]
fn dbp_split_all_valid(bencher: Bencher, (values_type, len): (DecimalType, usize)) {
bench_split(bencher, values_type, len, Validity::AllValid);
}

#[vortex_bench_support::cpu_features]
#[divan::bench(args = cases())]
fn dbp_split_all_null(bencher: Bencher, (values_type, len): (DecimalType, usize)) {
bench_split(bencher, values_type, len, Validity::AllInvalid);
}

#[vortex_bench_support::cpu_features]
#[divan::bench(args = cases())]
fn dbp_split_mixed_null(bencher: Bencher, (values_type, len): (DecimalType, usize)) {
let mut rng = StdRng::seed_from_u64(42);
Expand Down
Loading
Loading