Pushdown filter through scalar function regardless of number of children - #9830
Conversation
Signed-off-by: Robert Kruszewski <github@robertk.io>
Merging this PR will degrade performance by 10.38%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | WallTime | arrow_checked_add_u32_neon[16384] |
12.2 µs | 20.5 µs | -40.27% |
| ❌ | WallTime | dict_canonicalize_gt_u8_avx2[16000000] |
6.8 ms | 11.1 ms | -39.14% |
| ❌ | Simulation | decompress[u64, (4000, 1024)] |
70.8 µs | 87.2 µs | -18.77% |
| ❌ | WallTime | filtered_owned_i64_avx2[OneNullInEight] |
21.9 µs | 26 µs | -15.97% |
| ❌ | Simulation | compact_sliced[(1024, 90)] |
1.3 µs | 1.5 µs | -11.23% |
| ❌ | Simulation | compact[(1024, 90)] |
1.4 µs | 1.5 µs | -10.83% |
| ❌ | Simulation | compact_sliced[(2048, 90)] |
1.4 µs | 1.5 µs | -10.8% |
| ❌ | Simulation | compact[(2048, 90)] |
1.4 µs | 1.6 µs | -10.43% |
| ⚡ | WallTime | filtered_owned_i64_avx512[OneNullInEight] |
26.3 µs | 22.3 µs | +17.8% |
| ⚡ | WallTime | dict_canonicalize_gt_u8_neon[1000000] |
559.7 µs | 487.1 µs | +14.89% |
| ⚡ | Simulation | allocate_drop_arrow[0] |
456.9 ns | 402.7 ns | +13.45% |
| ⚡ | WallTime | dict_canonicalize_gt_u8_neon[16000000] |
9.4 ms | 8.4 ms | +11.38% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing rk/scalarfilterpushdown (dfcb8c8) with develop (272bf1d)2
Footnotes
-
218 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
develop(d6037bc) during the generation of this report, so 272bf1d was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
Polar Signals Profiling ResultsLatest Run
Previous Runs (2)
Powered by Polar Signals Cloud |
Benchmarks: PolarSignals Profiling 📖Commits: PR datafusion / vortex-file-compressed / ns (1.004x ➖, 0↑ 0↓)
No file size changes detected. |
Benchmarks: Statistical and Population Genetics 📖Commits: PR How to read Verdict and Engines
duckdb / vortex-file-compressed / ns (0.991x ➖, 0↑ 0↓)
duckdb / parquet / ns (1.017x ➖, 0↑ 0↓)
File Size Changes (1 files changed, -0.1% overall, 0↑ 1↓)
Totals:
|
Benchmarks: TPC-H SF=10 on NVME 📖Commits: PR How to read Verdict and Engines
datafusion / vortex-file-compressed / ns (0.995x ➖, 0↑ 0↓)
datafusion / parquet / ns (0.989x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed / ns (0.985x ➖, 0↑ 1↓)
duckdb / parquet / ns (1.000x ➖, 0↑ 0↓)
File Size Changes (6 files changed, -0.0% overall, 2↑ 4↓)
Totals:
|
Benchmarks: Clickbench Sorted on NVME 📖Commits: PR How to read Verdict and Engines
datafusion / vortex-file-compressed / ns (1.027x ➖, 0↑ 1↓)
datafusion / parquet / ns (1.004x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed / ns (0.997x ➖, 0↑ 1↓)
duckdb / parquet / ns (0.991x ➖, 0↑ 0↓)
File Size Changes (100 files changed, +0.0% overall, 46↑ 54↓)
Totals:
|
Benchmarks: TPC-DS SF=1 on NVME 📖Commits: PR How to read Verdict and Engines
datafusion / vortex-file-compressed / ns (1.002x ➖, 0↑ 0↓)
datafusion / parquet / ns (1.000x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed / ns (0.999x ➖, 1↑ 3↓)
duckdb / parquet / ns (1.002x ➖, 2↑ 4↓)
No file size changes detected. |
Benchmarks: FineWeb NVMe 📖Commits: PR How to read Verdict and Engines
datafusion / vortex-file-compressed / ns (0.974x ➖, 0↑ 0↓)
datafusion / parquet / ns (0.940x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed / ns (0.906x ➖, 3↑ 0↓)
duckdb / parquet / ns (1.014x ➖, 0↑ 0↓)
No file size changes detected. |
Benchmarks: TPC-H SF=1 on NVME 📖Commits: PR How to read Verdict and Engines
datafusion / vortex-file-compressed / ns (1.001x ➖, 0↑ 0↓)
datafusion / parquet / ns (1.002x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed / ns (0.969x ➖, 2↑ 0↓)
duckdb / parquet / ns (1.000x ➖, 0↑ 0↓)
No file size changes detected. |
Benchmarks: FineWeb S3 📖Commits: PR How to read Verdict and Engines
datafusion / vortex-file-compressed / ns (0.907x ➖, 1↑ 0↓)
datafusion / parquet / ns (1.003x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed / ns (1.024x ➖, 0↑ 0↓)
duckdb / parquet / ns (1.014x ➖, 0↑ 0↓)
|
Benchmarks: Clickbench on NVME 📖Commits: PR How to read Verdict and Engines
datafusion / vortex-file-compressed / ns (1.000x ➖, 1↑ 1↓)
datafusion / parquet / ns (1.028x ➖, 0↑ 1↓)
duckdb / vortex-file-compressed / ns (1.005x ➖, 1↑ 1↓)
duckdb / parquet / ns (0.983x ➖, 2↑ 0↓)
No file size changes detected. |
Benchmarks: TPC-H SF=1 on S3 📖Commits: PR How to read Verdict and Engines
datafusion / vortex-file-compressed / ns (1.037x ➖, 0↑ 0↓)
datafusion / parquet / ns (1.012x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed / ns (1.000x ➖, 0↑ 0↓)
duckdb / parquet / ns (1.031x ➖, 0↑ 0↓)
|
Now that we have more filter machinery this can be safe