fix broken unit test#801
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the ELF BSS guard regression test to align with the loader’s new “fail-on-header-collision” behavior (returning -5) instead of the previous skip-and-succeed behavior.
Changes:
- Update the test expectation from success (
0) to failure (-5) for the header-collision case. - Clarify the test comment to reflect that the loader aborts before any write occurs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #801
Scan targets checked: wolfboot-bugs, wolfboot-src
No new issues found in the changed files. ✅
padelsbach
reviewed
Jun 16, 2026
padelsbach
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes broken unit tests on master causing all current PRs to fail.
Seems that two separate PRs came together to break unit tests on master.
#746 changed the ELF loader's collision guard: when a segment would overwrite program headers that haven't been read yet, the loader after this PR fails with -5 instead of the old behavior of silently skipping the segment and returning 0.
The F-4418 regression test (added in #792 ) still expected the old skip-and-succeed behavior. Neither PR failed individually since they never tested each others changes, but now all PRs are failing.
Fix: update the test to expect the loader to reject the image (ret == -5) rather than return success.