Skip to content

fix broken unit test #801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgarske merged 1 commit into from
Jun 16, 2026
+5 −2
Merged

fix broken unit test #801

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions tools/unit-tests/unit-elf-bss-guard.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ START_TEST(test_elf_bss_guard_no_header_corruption)
* → write proceeds; memset zeroes ph[1].
* With the fixed guard (mem_size check):
* vaddr + mem_size = ph[1]_start + 56 > ph[1]_start → FALSE
* → write is skipped; ph[1] intact.
* → load is aborted (-5) before any write; ph[1] intact.
*/
ph[0].type = ELF_PT_LOAD;
ph[0].flags = 0;
Expand All @@ -106,7 +106,10 @@ START_TEST(test_elf_bss_guard_no_header_corruption)
}

ret = elf_load_image_mmu(g_image, sizeof(g_image), &entry, NULL);
ck_assert_int_eq(ret, 0);

/* The loader should reject this image instead of loading it, because the
* segment would overwrite part of the image it has not read yet. */
ck_assert_int_eq(ret, -5);
Comment thread
bigbrett marked this conversation as resolved.
Comment thread
padelsbach marked this conversation as resolved.

/*
* ph[1].type must not have been zeroed by the BSS memset from ph[0].
Expand Down
Loading