Stop QuoteHydrator from skipping quoted ids on retweets - #118
Open
Pitchfork-and-Torch wants to merge 1 commit into
Open
Stop QuoteHydrator from skipping quoted ids on retweets#118Pitchfork-and-Torch wants to merge 1 commit into
Pitchfork-and-Torch wants to merge 1 commit into
Conversation
This was referenced Sep 7, 2026
Stop SubscriptionHydrator from skipping exclusive ids on retweets
Pitchfork-and-Torch/x-algorithm#40
Closed
Author
|
Parking this intern-stack PR per operator GitHub cleanup (2026-09-08). Hunt notes remain local. Not a reject of the class. |
Author
|
Reopened. This was a serving-path hunt PR parked by mistake during the 2026-09-08 intern-stack cleanup. Not a reject of the class. Leaving it for xAI review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Phoenix
QuoteHydratorasks TES for quoted tweets by wrappertweet_id.get_quoted_tweetsreads the quoting tweet's nested quote. That field lives on the original post. A retweet wrapper storessource_tweet_id, notquoted_tweet.quoted_tweet_id/quoted_user_idstay None.OON retweets are already dropped by
OONRetweetReplyFilter. This path is a followed-user retweet of a quote (in-network).QuoteHydrator(phoenix_candidate_pipeline.rs,phoenix_scores_pipeline.rs)VFCandidateHydratorputsquoted_tweet_idon TimelineHomeRecommendations;AuthorSocialgraphFilterquoted mute/block;AdsBrandSafetyVfHydratorquoted labelscandidate.tweet_idinstead ofget_original_tweet_id()(retweeted_tweet_id.unwrap_or(tweet_id))MediaInfoHydrator,LanguageCodeHydrator, andEngagementCountsHydratoralready cache and fetch byget_original_tweet_id()This is not PR 117 (TES/graph fail-closed). This is not PR 94 (core TES wiping retweet/reply ids). This is not PR 98 (exclude_videos on quotes). This is not PR 23 (mute quoted author when the id is already present).
Fix
Look up and cache TES quoted tweets by
candidate.get_original_tweet_id(). Native quotes are unchanged (original == tweet_id). Two retweets of the same quote now share the cache key.Tests
cargo: cannot run. Public dump has no Home Mixer manifest.