Stop treating gizmoduck age 0 as a confirmed underage viewer - #133
Closed
Pitchfork-and-Torch wants to merge 1 commit into
Closed
Stop treating gizmoduck age 0 as a confirmed underage viewer#133Pitchfork-and-Torch wants to merge 1 commit into
Pitchfork-and-Torch wants to merge 1 commit into
Conversation
cursor
Bot
force-pushed
the
cursor/sensitive-viewer-age-zero-15a8
branch
from
September 7, 2026 04:24
b0935fd to
9d4e5e5
Compare
This was referenced Sep 7, 2026
SensitiveViewerUnderageDropRule used Known(0) as underage, so a missing birthday sentinel hard-dropped all sensitive media worldwide. Classify non-positive age like a missing birthday (NotStated if the user exists, Unknown otherwise). Move BidirectionalFollowHydrator after CoreData and skip author_id=0 so unhydrated rows are not stamped false mutual-follow.
Pitchfork-and-Torch
force-pushed
the
cursor/sensitive-viewer-age-zero-15a8
branch
from
September 8, 2026 23:12
9d4e5e5 to
902a06f
Compare
Author
|
Parking this intern-stack PR per operator GitHub cleanup (2026-09-08). Hunt notes remain local. Not a reject of the class. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Gizmoduck age_in_years: Some(0) is a missing-birthday sentinel. Visibility filtering mapped it to ViewerAge::Known(0). viewer_is_underage treated any Known(age) < 18 as a child, so SensitiveViewerUnderageDropRule hard-dropped sensitive media worldwide for those accounts.
RPC error already fails open as Unknown. Existing users with no usable birthday should be NotStated (jurisdiction-scoped via NSFW_GATING_COUNTRIES). Home-mixer and Phoenix already treat 0 as missing. VF did not.
Fix
Some(age) if age > 0 → Known. Else existing user → NotStated. Else → Unknown. Underage is logged-in + age in 1..18.
Age gates stay. Logged-out, confirmed underage, and no-stated-age-in-gating-country drops are unchanged.
Also: BidirectionalFollowHydrator now runs after CoreData and skips author_id 0 (leftover from #128). InNetwork order from #128 is unchanged.