feat: implement Infra layer for user favorites repository / お気に入り機能のInfra層実装 - #561
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Following the domain-layer migration for the
user_favoritejoin table (#560), this PR implements the Infra layer for the favorites feature: aFavoriteRepositoryInterfaceand its Eloquent-backedFavoriteRepositoryimplementation, allowing a user to add a world heritage site to their favorites.What I have done
User::favorites()BelongsToMany relation toWorldHeritagevia theuser_favoritepivot tableFavoriteRepositoryInterfacewithaddFavorite(int $userId, int $worldHeritageSiteId): voidFavoriteRepository, implementing the interface via$user->favorites()->attach(), throwing an exception when the user is not foundFavoriteRepositoryInterfacetoFavoriteRepositoryinRepositoryProviderFavoriteRepositoryagainst the real test databaseTest Results