home-mixer: use origin author for size and NSFW, fail closed on gizmoduck miss - #16
Closed
Pitchfork-and-Torch wants to merge 1 commit into
Closed
home-mixer: use origin author for size and NSFW, fail closed on gizmoduck miss#16Pitchfork-and-Torch wants to merge 1 commit into
Pitchfork-and-Torch wants to merge 1 commit into
Conversation
…duck miss Gizmoduck already fetched the retweeted user and then ignored counts and labels. Size residuals and the Simclusters NSFW drop therefore saw the retweeter. A store miss was written as empty fields; update_all drops Err, so that miss scored as clean. Follower count now comes from retweeted_user_id when present. NSFW is the OR of poster, original author, and quoted author. A missing map slot or read error is labeled, not treated as clean. Confirmed absence stays unlabeled. Quotes still size on the quoter. Co-authored-by: Jon Bailey <Pitchfork-and-Torch@users.noreply.github.com>
Owner
Author
|
Wrong base (fork PR). Ship vehicle is upstream xai-org#125. Per submit law: never PR Pitchfork-and-Torch/x-algorithm. Do not merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
GizmoduckCandidateHydratoralready fetched the retweeted user, then used that row only forretweeted_screen_name. Follower count and NSFW flags came fromcandidate.author_id(the retweeter). Quoted authors were not fetched at all.Size residuals (
author_followers_count→ IPS, OON relief, tweet-type buckets, VM ranker) therefore saw the amplifier, not the content origin. A 50-follower account retweeting a 1M-follower original inherited the small-account lift. The Simclusters OON NSFW drop (nsfw_author == Some(true)) saw the retweeter or quoter only, so an NSFW original behind a clean amplifier stayed clean.A gizmoduck miss was worse. A missing map slot or
Ok(None)became empty fields. Pipelineupdate_alldropsErrwithout writing anything, so a failed read leftnsfw_author = Noneandauthor_followers_count = None. The NSFW filter requiresSome(true). Unknown authors were scored clean and size-neutral.This is not IPS math (#31) and not the VF hydrator quote/RT verdicts (xai-org#115–xai-org#119).
Fix
One file,
home-mixer/candidate_hydrators/gizmoduck_hydrator.rs.retweeted_user_id, andquoted_user_id.nsfw_author/nsfw_author_adsare the OR of poster, original author, and quoted author.Some(true)). Confirmed store absence stays unlabeled. Values are returned onOksoupdate_allactually applies them.quoted_user_id.in_networkis unchanged. That flag is “did this poster come from someone the viewer follows.” Flipping it to the original author would let unfollowed retweets skipOONRetweetReplyFilter.Tests
home-mixerhas no Cargo manifest here. The merge function was compiled and run as arustc --testmodel of the same control flow: 5/5 passed.Upstream
Clean port onto
xai-org/x-algorithmmain (includesnsfw_author_phoenix): xai-org#125