home-mixer: use origin author for size and NSFW, fail closed on gizmoduck miss - #125
Closed
Pitchfork-and-Torch wants to merge 1 commit into
Closed
Conversation
cursor Bot
pushed a commit
to Pitchfork-and-Torch/x-algorithm
that referenced
this pull request
Sep 7, 2026
Rebased onto latest xai-org/x-algorithm main. Missed ads-VF hydration defaulted organics to MediumRisk, and ads-only nsfw_author_ads rewrote the shared verdict. Default For You blender then pulled those posts out of ranked order when placing ads. Keep a real MediumRisk tweet-label verdict off ad neighbors. Following still will not sit an ad next to Unspecified. Compatibility with sibling PRs that touch the same files: - expired ads brand-safety labels are ignored (xai-org#124) - gizmoduck uses origin author size/NSFW OR and fails closed on miss (xai-org#125) Co-authored-by: Jon Bailey <Pitchfork-and-Torch@users.noreply.github.com>
This was referenced Sep 7, 2026
Pitchfork-and-Torch
marked this pull request as ready for review
September 7, 2026 04:20
This was referenced Sep 7, 2026
Closed
Closed
Closed
Closed
Pitchfork-and-Torch
added a commit
to Pitchfork-and-Torch/x-algorithm
that referenced
this pull request
Sep 8, 2026
Rebased onto latest xai-org/x-algorithm main. Missed ads-VF hydration defaulted organics to MediumRisk, and ads-only nsfw_author_ads rewrote the shared verdict. Default For You blender then pulled those posts out of ranked order when placing ads. Keep a real MediumRisk tweet-label verdict off ad neighbors. Following still will not sit an ad next to Unspecified. Compatibility with sibling PRs that touch the same files: - expired ads brand-safety labels are ignored (xai-org#124) - gizmoduck uses origin author size/NSFW OR and fails closed on miss (xai-org#125)
Pitchfork-and-Torch
force-pushed
the
cursor/gizmoduck-origin-nsfw-018b
branch
from
September 8, 2026 23:13
1bb59b9 to
902a06f
Compare
…duck miss Gizmoduck already fetched the retweeted user and then ignored counts and labels. Size residuals and NSFW flags therefore saw the retweeter. A store miss was written as empty fields; update_all drops Err, so that miss scored as clean. Follower count now comes from retweeted_user_id when present. NSFW is the OR of poster, original author, and quoted author, including nsfw_author_phoenix. A missing map slot or read error is labeled, not treated as clean. Confirmed absence stays unlabeled. Quotes still size on the quoter.
Author
|
Parking this intern-stack PR per operator GitHub cleanup (2026-09-08). Hunt notes remain local. Not a reject of the class. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
GizmoduckCandidateHydratorfetched the retweeted user and then used that row only forretweeted_screen_name. Follower count and NSFW flags (nsfw_author,nsfw_author_ads,nsfw_author_phoenix) came from the retweeter. Quoted authors were not fetched.Size residuals therefore saw the amplifier. A 50-follower account retweeting a 1M-follower original inherited the small-account lift. The Simclusters OON NSFW drop and the Phoenix author-NSFW safety bit (quotes) saw the poster only.
A missing map slot or read error became empty fields. Pipeline
update_alldropsErr, so unknown authors scored clean.Not IPS math (#31). Not the VF hydrator quote/RT verdicts (#115–#119).
Fix
One file,
home-mixer/candidate_hydrators/gizmoduck_hydrator.rs.retweeted_user_id, andquoted_user_id.Oksoupdate_allapplies it. Confirmed absence stays unlabeled.in_networkis unchanged. That flag is whether the poster is followed. Flipping it to the original author would let unfollowed retweets skipOONRetweetReplyFilter.Tests
nsfw_author_phoenix.home-mixerhas no public Cargo manifest. The merge function was compiled and run as a rustc model: 5/5 passed.Fork dump counterpart: Pitchfork-and-Torch#16