docs(create-objectstack): correct a bogus issue reference in the pnpm-build-approvals comments#3125
Merged
Merged
Conversation
…-build-approvals comments #3119 cited "#3110" in four comments as the pnpm 11 build-approvals bug. #3110 is an unrelated, already-closed issue — "ObjectLogger file destination silently no-ops in ESM builds" (fixed by #3116). The reference was fabricated: the pnpm 11 scaffold breakage was found while diagnosing the red Publish Smoke gate and has no issue of its own, so the correct citation is the PR that fixed it, #3119. Comment-only. Left a wrong pointer in the two places most likely to be read by whoever next touches this: the "why is the smoke's pnpm unpinned" rationale in the script header, and the ratchet that guards the template. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
os-zhuang
added
the
skip-changeset
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 7 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
#3119 cited #3110 in four comments as the pnpm 11 build-approvals bug. That reference is wrong: #3110 is "ObjectLogger file destination silently no-ops in ESM builds" — unrelated, already closed, fixed by #3116.
The citation was fabricated on my part. The pnpm 11 scaffold breakage was found while diagnosing the red Publish Smoke gate and has no issue of its own, so the correct pointer is the PR that fixed it: #3119.
Why it matters
Comment-only, but it left a wrong pointer in the two places most likely to be read by whoever next touches this:
scripts/publish-smoke.sh:51— the "why is the smoke's pnpm deliberately unpinned" rationale, i.e. the exact spot someone lands on when a future pnpm major turns the gate red.template-consistency.test.ts:80— the ratchet guarding the template, where the describe name is what shows up in a failing test run.Following either to #3110 leads to an ESM logger bug and wastes the reader's time.
Verification
grep -rn 3110overscripts/publish-smoke.sh,packages/create-objectstack/,.changeset/— no remaining references.bash -n scripts/publish-smoke.shclean;vitest run13/13.pnpm-workspace.yamland the changeset never cited it, so nothing user-facing shipped with the bad reference.🤖 Generated with Claude Code