Skip to content

docs(create-objectstack): correct a bogus issue reference in the pnpm-build-approvals comments #3125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-zhuang merged 1 commit into from
Jul 17, 2026
+4 −4
Merged

docs(create-objectstack): correct a bogus issue reference in the pnpm-build-approvals comments #3125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/create-objectstack/src/template-consistency.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,10 @@ describe('blank template manifest engines.protocol (ADR-0087 D1)', () => {

// pnpm 11 turned an unapproved dependency build script from a warning into a
// hard error, so the template declaring nothing meant `npx create-objectstack`
// + `pnpm install` exited 1 for every user on a current pnpm (#3110). Both keys
// + `pnpm install` exited 1 for every user on a current pnpm (#3119). Both keys
// are load-bearing and read by different pnpm versions: pnpm 11 honours only
// `allowBuilds`, while pnpm 10.0–10.30 understand only `onlyBuiltDependencies`.
describe('blank template pnpm build approvals (#3110)', () => {
describe('blank template pnpm build approvals (#3119)', () => {
const wsPath = path.join(pkgRoot, 'src', 'templates', 'blank', 'pnpm-workspace.yaml');
const APPROVED = ['better-sqlite3', 'esbuild'];
// Strip comments: the prose below explains these keys and must not satisfy
Expand Down
4 changes: 2 additions & 2 deletions scripts/publish-smoke.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
# create-objectstack template needs updating. It has already happened once:
# pnpm 11 turned unapproved build scripts from a warning into a hard error, so
# every `npx create-objectstack` + `pnpm install` exited 1 until the template
# started declaring `allowBuilds` (#3110).
# started declaring `allowBuilds` (#3119).
#
# Usage:
# bash scripts/publish-smoke.sh
Expand Down Expand Up @@ -129,7 +129,7 @@ if [ "$SMOKE_MODE" = "pack" ]; then
# Appending, not overwriting, is load-bearing: the template's build-approval
# block (allowBuilds / onlyBuiltDependencies) is part of what a user gets, so
# it has to be part of what this gate tests. This script used to hand-write
# the whole file, declaring the approvals itself — which is exactly how #3110
# the whole file, declaring the approvals itself — which is exactly how #3119
# stayed invisible here: a locally-authored declaration proves nothing about
# what the template ships.
#
Expand Down
Loading