fix(metadata-admin): dashboard label fallback + skill activation editors (#1878)#2666
Merged
Merged
Conversation
…ors (#1878) Metadata-liveness audit follow-through (umbrella #1878), objectui side. #1891 (naming drift — dashboard title vs label): DashboardGridLayout read only `schema.title`, but the spec's canonical top-level key is `label`, so a spec-compliant dashboard rendered the literal "Dashboard" header. Fall back to `schema.label` (matching DashboardView's title-then-label precedence). #1895 (designer authoring gaps — skill): the skill authoring form exposed only name/instructions/tools. Add editors for the activation-critical fields that were previously hand-edit-only: - `surface` (ask | build | both) - `triggerPhrases` (NL activation phrases) - `triggerConditions` (field / operator / value) — the activation-critical programmatic conditions plugin-dashboard suite green (89 passing); changed files add no type errors. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LddW4NaQBdf5FTEnBPpnUJ
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
os-zhuang
marked this pull request as ready for review
July 18, 2026 15:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
objectui-side follow-through on the metadata-liveness audit umbrella (framework #1878, reopened). Companion to framework PR objectstack-ai/framework#3223.
#1891 — Naming drift (dashboard
titlevslabel)DashboardGridLayoutread onlyschema.title, but the spec's canonical top-level key islabel(only widgets carrytitle). A spec-compliant dashboard therefore rendered the literal "Dashboard" header. Now falls back toschema.label, matchingDashboardView's existingtitle → labelprecedence.#1895 — Designer authoring gaps (skill)
The skill authoring form (
metadata-admin/default-schemas.ts) exposed onlyname/instructions/tools, so the activation-critical fields could only be authored by hand-editing metadata. Added editors for:surface(ask|build|both)triggerPhrases— natural-language activation phrasestriggerConditions— programmaticfield/operator/valueconditions (the activation-critical field)Testing
@object-ui/plugin-dashboardsuite: 89 passingtype-checkfailures are unbuilt-workspace-dep module-resolution errors, unrelated to this diff).Notes / not in this PR
httpvshttp_requestnaming drift (feat(console-ai): one-click answer chips for the plan card's questions #1891) is already resolved in the current HEAD —NODE_PALETTEauthors canonicalhttp; remaininghttp_requestbranches are back-compat recognizers only.notifypalette node (chore(deps): bump the patch-updates group with 32 updates #1895) and the tool executor (feat(plugin-tree): add tree / tree-grid object view type (#1885) #1892) are larger designer/runtime features left for a dedicated change (they need node rendering + config panels / an engine executor, and should be browser-verified).🤖 Generated with Claude Code
https://claude.ai/code/session_01LddW4NaQBdf5FTEnBPpnUJ
Generated by Claude Code