Skip to content

fix(metadata-admin): dashboard label fallback + skill activation editors (#1878) #2666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-zhuang merged 1 commit into from
Jul 18, 2026
+30 −1
Merged

fix(metadata-admin): dashboard label fallback + skill activation editors (#1878) #2666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions packages/app-shell/src/views/metadata-admin/default-schemas.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,35 @@ const SCHEMAS: Record<string, Record<string, unknown>> = {
...headerProps,
instructions: { type: 'string', title: 'Instructions', format: 'multiline' },
tools: { type: 'array', title: 'Tools', items: { type: 'string' } },
surface: {
type: 'string',
title: 'Surface',
description: "Agent surface this skill binds to (ADR-0063).",
enum: ['ask', 'build', 'both'],
},
triggerPhrases: {
type: 'array',
title: 'Trigger Phrases',
description: 'Natural-language phrases that activate this skill.',
items: { type: 'string' },
},
triggerConditions: {
type: 'array',
title: 'Trigger Conditions',
description: 'Programmatic activation conditions (context field / operator / value). The activation-critical field — previously only hand-editable (#1878/#1895).',
items: {
type: 'object',
properties: {
field: { type: 'string', title: 'Field' },
operator: {
type: 'string',
title: 'Operator',
enum: ['eq', 'neq', 'in', 'not_in', 'contains'],
},
value: { type: 'string', title: 'Value' },
},
},
},
},
},

Expand Down
2 changes: 1 addition & 1 deletion packages/plugin-dashboard/src/DashboardGridLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ export const DashboardGridLayout: React.FC<DashboardGridLayoutProps> = ({
<div ref={containerRef} className={cn("w-full", className)} data-testid="grid-layout">
{hasDndProvider && <DndEditModeBridge editMode={editMode} />}
<div className="mb-4 flex items-center justify-between">
<h2 className="text-2xl font-bold">{schema.title || 'Dashboard'}</h2>
<h2 className="text-2xl font-bold">{schema.title || schema.label || 'Dashboard'}</h2>
<div className="flex gap-2">
{editMode ? (
<>
Expand Down
Loading