test(types): the unmirrored-keys pin stops claiming a doc side the flag half lost (objectui#7992) - #9688
Draft
os-justin wants to merge 1 commit into
Draft
test(types): the unmirrored-keys pin stops claiming a doc side the flag half lost (objectui#7992)#9688os-justin wants to merge 1 commit into
os-justin wants to merge 1 commit into
Conversation
…ag half lost (objectui#7992) `object-view-unmirrored-keys-7779.test.ts` labelled a pair of `SpecObjectListViewSchema` refusals with one source line reading "schema-reference.md: an ObjectQL tuple filter and a `default: true` flag." The tuple half is still true and still pinned off disk by the neighbouring "still what the docs teach" test. The flag half is not: objectui#7923 (PR objectui#7991) deleted the per-view `default: true` flag from that example, because `NamedListView` never declared the key and `ObjectView` never read it. Prose only. The `flagged` assertion still measures something real — the spec closes `default` too — so it is kept, and the comment now says what it is: a refusal pinned on its own merits, with nothing re-deriving the flag's absence from the docs, marked as history rather than a live reading. Co-authored-by: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012EpHzwH4wTy5sd7ibkD2yq
Contributor
✅ Console Performance Budget
The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it. 📦 Bundle Size Report
Size Limits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #7992
What changed — prose only
packages/types/src/__tests__/object-view-unmirrored-keys-7779.test.tslabelled a pair ofSpecObjectListViewSchemarefusals with a single source line.Before:
// schema-reference.md: an ObjectQL tuple filter and a `default: true` flag.After — the label now covers only the half that still has a doc side, and a second
comment says what the other half is:
⛔ No assertion added, removed or weakened. Mechanically: every changed line in the diff is a
//line —git diff -U0 | grep '^[+-]' | grep -v '^[+-]\s*//'(after dropping the+++/---headers) returns nothing. The
flaggedassertion is kept because it still measures somethingreal, and the sibling
readRepo('content/docs/api/schema-reference.md')assertion — the one thatstill HAS a live doc side — is untouched.
The doc-side measurement, with a control that FIRES
A bare "0 hits" would prove nothing here, and the dispatch's own first probe is the demonstration:
"default":— with the colon, JSON-quoted — also scores 0 acrosscontent/docs, so thatpattern matches nothing anywhere and a zero is a fact about the pattern, not about the tree.
Readings below taken at
d83ea4160, this branch's head; a historical reading, ⛔ not re-derived byanything and ⛔ not to be read as live.
"default": trueacrosscontent/docs"default":acrosscontent/docs"filter":incontent/docs/api/schema-reference.mddefaultin that same file"filter": [["owner", "=", "${currentUser.id}"]],in that fileobject-viewexample — the tuple half's doc side, and the string the sibling assertion pins⇒ The flag is genuinely gone, on controls that fire. What stands in its place in that example is a
node-level
"defaultListView"key — PR objectui#7991 spelled the default list view once, at thenode, instead of as a per-view flag
NamedListViewnever declared.Verification
pnpm vitest runover the changed test filepnpm --filter @object-ui/types test(via the shared verify lock)pnpm --filter @object-ui/types type-checkeslint .inpackages/typesnode scripts/check-changeset-presence.mjspnpm changeset:checkpnpm check:new-line-citationspnpm check:control-bytespnpm check:changeset-claims·pnpm check:pending-changeset-literalsnode scripts/check-governed-queue-guard.mjs --testover both changed pathsEvery exit code above was captured before any pipe (
cmd > log 2>&1; EXIT=$?), not through one.The lint reading is the whole affected package rather than a narrowing; type-aware linting is not
enabled in this repo's eslint config either way (no
project/projectServicekey), so this diffcannot move the verdict on a file it does not touch. The repo-level
turbo run lintbelongs to CI.Changeset
.changeset/issue-7992-unmirrored-keys-doc-side.md, EMPTY frontmatter — declared as releasingnothing. Followed the gate rather than guessed:
check-changeset-presence.mjsscored the test fileas published source of a released package and demanded a declaration, and names the empty
frontmatter as "a pass, not a workaround".
Scope
make the old comment true again is the wrong direction.
nothing holding prose to measurement — is NOT closed here. This card is one instance of it.
is located by content — the quoted line above — and per AGENTS.md [WIP] Update documentation for project #11 the repair is not minted
into a new line address here. Reported, not fixed: this is a scope-pinned card, so [WIP] Update documentation for project #11's
opportunistic citation repair does not apply.
content/docs/api/schema-reference.md(a lucide icon rename in thedetail-view example). Re-measured: it touches neither the
object-viewexample nordefault.No overlap with this branch, which does not touch that file at all.
Generated by Claude Code