Skip to content

test(types): the unmirrored-keys pin stops claiming a doc side the flag half lost (objectui#7992) #9688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
os-justin wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −1
Draft

test(types): the unmirrored-keys pin stops claiming a doc side the flag half lost (objectui#7992) #9688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .changeset/issue-7992-unmirrored-keys-doc-side.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
---

Test comment only: in `object-view-unmirrored-keys-7779.test.ts`, the label above the `SpecObjectListViewSchema` refusal pair no longer claims `schema-reference.md` authors a `default: true` flag — objectui#7923 (PR objectui#7991) removed that per-view flag from the `object-view` example, so the `flagged` case is now a refusal pinned on its own merits rather than a reading of a documented shape. No assertion added, removed or weakened; no published behaviour changes.
12 changes: 11 additions & 1 deletion packages/types/src/__tests__/object-view-unmirrored-keys-7779.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -903,10 +903,20 @@ describe('objectui#7779 — `listViews` stays unmirrored on the ruling\'s fallba
const filtered = SpecObjectListViewSchema.safeParse({ label: 'Under 100', type: 'grid', filter: [{ field: 'price', operator: 'less_than', value: 100 }] });
expect(filtered.success).toBe(false);
if (!filtered.success) expect(refusedAt(filtered.error.issues as readonly Issue[], 'columns')).toBe(true);
// schema-reference.md: an ObjectQL tuple filter and a `default: true` flag.
// schema-reference.md: an ObjectQL tuple filter. Only `tuple` still has a
// doc side, and that side is HELD — the "still what the docs teach" test
// below pins this exact filter string off disk.
const tuple = SpecObjectListViewSchema.safeParse({ label: 'My Deals', columns: ['name'], filter: [['owner', '=', '${currentUser.id}']] });
expect(tuple.success).toBe(false);
if (!tuple.success) expect(refusedAt(tuple.error.issues as readonly Issue[], 'filter')).toBe(true);
// `flagged` has NO doc side, and its removal was deliberate: objectui#7923
// (PR objectui#7991) deleted the per-view `default: true` flag from that
// same `object-view` example, because `NamedListView` never declared the
// key and `ObjectView` never read it. What is left is a refusal pinned on
// its OWN merits — the spec closes `default` too, which is why that doc fix
// is not merely cosmetic — so this case is no longer a reading of any shape
// the docs teach. ⚠️ Nothing re-derives that absence: read the sentence
// above as history, not as a live reading of that file.
const flagged = SpecObjectListViewSchema.safeParse({ label: 'My Deals', columns: ['name'], default: true });
expect(flagged.success).toBe(false);
// The control: the shape the schema catalog authors IS accepted, so the
Expand Down
Loading