Skip to content

Stop IneligibleSubscriptionFilter from dropping exclusive posts on a subscription-list miss - #129

Closed
Pitchfork-and-Torch wants to merge 1 commit into
xai-org:mainfrom
Pitchfork-and-Torch:cursor/subscription-list-miss-starve-d8a8
Closed

Stop IneligibleSubscriptionFilter from dropping exclusive posts on a subscription-list miss#129
Pitchfork-and-Torch wants to merge 1 commit into
xai-org:mainfrom
Pitchfork-and-Torch:cursor/subscription-list-miss-starve-d8a8

Conversation

@Pitchfork-and-Torch

Copy link
Copy Markdown

Bug

For You IneligibleSubscriptionFilter drops exclusive posts when the subscription list was never loaded, and when the viewer is the conversation author.

SubscribedUserIdsQueryHydrator errors are ignored by hydrate_query. The list stays empty. The mixer filter treated empty as "subscribed to nobody" and dropped every subscription_author_id: Some(...) before scoring.

VF DropExclusiveTweetContentRule allows the conversation author. The mixer filter did not.

  • Entry: Phoenix IneligibleSubscriptionFilter (phoenix_candidate_pipeline.rs)
  • Sink: pre-scoring drop of exclusive / Super Follow posts
  • Break: socialgraph miss → empty list → drop all exclusive; conversation author never exempted
  • Viewer effect: paying subscribers lose exclusive posts on a list-RPC miss; conversation authors lose exclusive replies in For You
  • Twin: VF still decides exclusive access when the mixer list is missing

This is not #96#120 (VF, mute/block, quote, scarecrow, geo). Brazil 2026 filter is not in this snapshot.

Fix

Mark the subscription list hydrated only after a successful socialgraph read. Keep exclusive posts when the list was not loaded. Keep exclusive posts when the viewer is the conversation author.

A hydrated empty list still drops exclusive posts for everyone except the conversation author.

Tests

Filter unit tests cover hydrator-miss keep, conversation-author keep, subscribed keep, unsubscribed drop, and hydrated-empty drop. Hydrator tests cover success marking the list ready and errors leaving it unready.

cargo: cannot run the Home Mixer crate here. Public dump has no Home Mixer manifest. Standalone keep-rule check: 6/6 passed.

…subscription-list miss

Query hydrators ignore errors, so a socialgraph miss left subscribed_user_ids empty. The mixer filter treated that as "subscribed to nobody" and dropped every exclusive post before VF. Also keep exclusive posts when the viewer is the conversation author, matching DropExclusiveTweetContentRule.
@Pitchfork-and-Torch
Pitchfork-and-Torch force-pushed the cursor/subscription-list-miss-starve-d8a8 branch from 71ea54a to 902a06f Compare September 8, 2026 23:12
@Pitchfork-and-Torch

Copy link
Copy Markdown
Author

Parking this intern-stack PR per operator GitHub cleanup (2026-09-08). Hunt notes remain local. Not a reject of the class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant