Stop IneligibleSubscriptionFilter from dropping exclusive posts on a subscription-list miss - #129
Closed
Pitchfork-and-Torch wants to merge 1 commit into
Conversation
cursor
Bot
force-pushed
the
cursor/subscription-list-miss-starve-d8a8
branch
from
September 7, 2026 04:12
e45b67e to
71ea54a
Compare
This was referenced Sep 7, 2026
Stop SubscriptionHydrator from skipping exclusive ids on retweets
Pitchfork-and-Torch/x-algorithm#40
Closed
…subscription-list miss Query hydrators ignore errors, so a socialgraph miss left subscribed_user_ids empty. The mixer filter treated that as "subscribed to nobody" and dropped every exclusive post before VF. Also keep exclusive posts when the viewer is the conversation author, matching DropExclusiveTweetContentRule.
Pitchfork-and-Torch
force-pushed
the
cursor/subscription-list-miss-starve-d8a8
branch
from
September 8, 2026 23:12
71ea54a to
902a06f
Compare
Author
|
Parking this intern-stack PR per operator GitHub cleanup (2026-09-08). Hunt notes remain local. Not a reject of the class. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
For You
IneligibleSubscriptionFilterdrops exclusive posts when the subscription list was never loaded, and when the viewer is the conversation author.SubscribedUserIdsQueryHydratorerrors are ignored byhydrate_query. The list stays empty. The mixer filter treated empty as "subscribed to nobody" and dropped everysubscription_author_id: Some(...)before scoring.VF
DropExclusiveTweetContentRuleallows the conversation author. The mixer filter did not.IneligibleSubscriptionFilter(phoenix_candidate_pipeline.rs)This is not #96–#120 (VF, mute/block, quote, scarecrow, geo). Brazil 2026 filter is not in this snapshot.
Fix
Mark the subscription list hydrated only after a successful socialgraph read. Keep exclusive posts when the list was not loaded. Keep exclusive posts when the viewer is the conversation author.
A hydrated empty list still drops exclusive posts for everyone except the conversation author.
Tests
Filter unit tests cover hydrator-miss keep, conversation-author keep, subscribed keep, unsubscribed drop, and hydrated-empty drop. Hydrator tests cover success marking the list ready and errors leaving it unready.
cargo: cannot run the Home Mixer crate here. Public dump has no Home Mixer manifest. Standalone keep-rule check: 6/6 passed.