Stop CoreData from skipping TES on NightOwl replies and retweets - #132
Closed
Pitchfork-and-Torch wants to merge 1 commit into
Closed
Conversation
cursor
Bot
force-pushed
the
cursor/nightowl-coredata-skip-tes-0ca8
branch
from
September 7, 2026 04:22
4e0cc2b to
663e316
Compare
This was referenced Sep 7, 2026
Closed
Pitchfork-and-Torch
force-pushed
the
cursor/nightowl-coredata-skip-tes-0ca8
branch
from
September 8, 2026 23:16
663e316 to
902a06f
Compare
NightOwl already sets author_id and tweet_text, so CoreData treated Latest Following cards as hydrated and never filled ancestor_users or retweeted_user_id. SelfReplyChainFilter then fail-opened.
Author
|
Parking this intern-stack PR per operator GitHub cleanup (2026-09-08). Hunt notes remain local. Not a reject of the class. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Latest Following (NightOwl) pre-fills author_id and tweet_text. CoreDataCandidateHydrator.already_hydrated treated that as done and skipped TES.
NightOwl does not set ancestor_users or retweeted_user_id. SelfReplyChainFilter fail-opens when ancestor_users is empty, so self-replies aimed at an unfollowed user stay in Following.
Fix
Call TES when a reply still has empty ancestor_users, or a retweet still has no retweeted_user_id. Originals with author and text still skip TES.
On TES miss, keep the source fields.
Not #94 (TES miss wiping Thunder/Phoenix ids). Not #99 (For You self-reply chains). Related to but distinct from CoreData stale author overwrite (#131).