Skip to content

[ET-VK][ops] Move group norm reduction lanes to Z - #22222

Open
SS-JIA wants to merge 1 commit into
gh/SS-JIA/602/basefrom
gh/SS-JIA/602/head
Open

[ET-VK][ops] Move group norm reduction lanes to Z#22222
SS-JIA wants to merge 1 commit into
gh/SS-JIA/602/basefrom
gh/SS-JIA/602/head

Conversation

@SS-JIA

@SS-JIA SS-JIA commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Stack from ghstack (oldest at bottom):

Move group norm's cooperative 64-thread reduction dimension from Y to Z. This preserves X as the output-element dimension while leaving Y available for two-dimensional linear dispatch wrapping.

Add an explicit null check to the resize callback while updating the implementation.

Authored with Codex.

Differential Revision: D117706347

[ghstack-poisoned]
@pytorch-bot

pytorch-bot Bot commented Aug 27, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22222

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 024a7e5 with merge base cf9bcd8 (image):

NEW FAILURE - The following job has failed:

  • Build Presets / apple (llm) / build (gh)
    ##[error]fatal: Fetched in submodule path 'extension/llm/tokenizers/third-party/json', but it did not contain e6cafa573aac6ed9227f752a5371c0b3f436307d. Direct fetching of that commit failed.

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@shoumikhin

Copy link
Copy Markdown
Contributor
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants