[ET-VK][runtime][2/3] Add typed dispatch size abstractions - #22224
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22224
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 43da1f8 with merge base a5f15b5 ( NEW FAILURE - The following job has failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Aug 27, 2026
This PR needs a
|
metascroy
approved these changes
Aug 28, 2026
meta-codesync
Bot
merged commit Aug 28, 2026
3622d4d
into
gh/SS-JIA/604/base
193 of 195 checks passed
SS-JIA
added a commit
that referenced
this pull request
Aug 29, 2026
Pull Request resolved: #22224 Introduce `LocalWorkGroup`, `LwgShape`, `GlobalWorkGrid`, and `DispatchGridIntent` in `runtime/vk_api/DispatchGrid`. Remove legacy `WorkgroupSize`. Model local shapes as power-of-two exponents, support fitting against global extents, and validate local dimensions against device limits. Track dispatch intent independently from optional required local workgroup geometry. Authored with Codex. ghstack-source-id: 421281484 @exported-using-ghexport Differential Revision: [D117706351](https://our.internmc.facebook.com/intern/diff/D117706351/)
SS-JIA
added a commit
that referenced
this pull request
Aug 29, 2026
Pull Request resolved: #22224 Introduce `LocalWorkGroup`, `LwgShape`, `GlobalWorkGrid`, and `DispatchGridIntent` in `runtime/vk_api/DispatchGrid`. Remove legacy `WorkgroupSize`. Model local shapes as power-of-two exponents, support fitting against global extents, and validate local dimensions against device limits. Track dispatch intent independently from optional required local workgroup geometry. Authored with Codex. ghstack-source-id: 421281484 @exported-using-ghexport Differential Revision: [D117706351](https://our.internmc.facebook.com/intern/diff/D117706351/)
SS-JIA
added a commit
that referenced
this pull request
Aug 29, 2026
Pull Request resolved: #22224 Introduce `LocalWorkGroup`, `LwgShape`, `GlobalWorkGrid`, and `DispatchGridIntent` in `runtime/vk_api/DispatchGrid`. Remove legacy `WorkgroupSize`. Model local shapes as power-of-two exponents, support fitting against global extents, and validate local dimensions against device limits. Track dispatch intent independently from optional required local workgroup geometry. Authored with Codex. ghstack-source-id: 421281484 @exported-using-ghexport Differential Revision: [D117706351](https://our.internmc.facebook.com/intern/diff/D117706351/)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Introduce
LocalWorkGroup,LwgShape,GlobalWorkGrid, andDispatchGridIntentinruntime/vk_api/DispatchGrid. Remove legacyWorkgroupSize.Model local shapes as power-of-two exponents, support fitting against global
extents, and validate local dimensions against device limits. Track dispatch
intent independently from optional required local workgroup geometry.
Authored with Codex.
Differential Revision: D117706351