[ET-VK][runtime][3/3] Enforce device-safe dispatch geometry - #22225
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22225
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Unrelated FailureAs of commit a745e5e with merge base a5f15b5 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
Pull Request resolved: #22225 Migrate dispatch, prepack, profiling, and workgroup picker interfaces to `GlobalWorkGrid` and `LocalWorkGroup`. Wrap oversized linear grids using device limits and validate final geometry before `vkCmdDispatch`. Carry exact local geometry as `GlobalWorkGrid` metadata. Cooperative and reduction grid pickers set it explicitly, while `pick_required_lwg` validates and returns it. Preserve elongated Conv1d depthwise workgroups where the default shape would regress GPU latency. Add end-to-end oversized linear dispatch coverage. Authored with Codex. ghstack-source-id: 420783889 @exported-using-ghexport Differential Revision: [D117706355](https://our.internmc.facebook.com/intern/diff/D117706355/)
9800583
into
gh/SS-JIA/605/base
Pull Request resolved: #22225 Migrate dispatch, prepack, profiling, and workgroup picker interfaces to `GlobalWorkGrid` and `LocalWorkGroup`. Wrap oversized linear grids using device limits and validate final geometry before `vkCmdDispatch`. Carry exact local geometry as `GlobalWorkGrid` metadata. Cooperative and reduction grid pickers set it explicitly, while `pick_required_lwg` validates and returns it. Preserve elongated Conv1d depthwise workgroups where the default shape would regress GPU latency. Add end-to-end oversized linear dispatch coverage. Authored with Codex. ghstack-source-id: 421281492 @exported-using-ghexport Differential Revision: [D117706355](https://our.internmc.facebook.com/intern/diff/D117706355/)
Pull Request resolved: #22225 Migrate dispatch, prepack, profiling, and workgroup picker interfaces to `GlobalWorkGrid` and `LocalWorkGroup`. Wrap oversized linear grids using device limits and validate final geometry before `vkCmdDispatch`. Carry exact local geometry as `GlobalWorkGrid` metadata. Cooperative and reduction grid pickers set it explicitly, while `pick_required_lwg` validates and returns it. Preserve elongated Conv1d depthwise workgroups where the default shape would regress GPU latency. Add end-to-end oversized linear dispatch coverage. Authored with Codex. ghstack-source-id: 421281492 @exported-using-ghexport Differential Revision: [D117706355](https://our.internmc.facebook.com/intern/diff/D117706355/)
Pull Request resolved: #22225 Migrate dispatch, prepack, profiling, and workgroup picker interfaces to `GlobalWorkGrid` and `LocalWorkGroup`. Wrap oversized linear grids using device limits and validate final geometry before `vkCmdDispatch`. Carry exact local geometry as `GlobalWorkGrid` metadata. Cooperative and reduction grid pickers set it explicitly, while `pick_required_lwg` validates and returns it. Preserve elongated Conv1d depthwise workgroups where the default shape would regress GPU latency. Add end-to-end oversized linear dispatch coverage. Authored with Codex. ghstack-source-id: 421281492 @exported-using-ghexport Differential Revision: [D117706355](https://our.internmc.facebook.com/intern/diff/D117706355/)
Pull Request resolved: #22225 Migrate dispatch, prepack, profiling, and workgroup picker interfaces to `GlobalWorkGrid` and `LocalWorkGroup`. Wrap oversized linear grids using device limits and validate final geometry before `vkCmdDispatch`. Carry exact local geometry as `GlobalWorkGrid` metadata. Cooperative and reduction grid pickers set it explicitly, while `pick_required_lwg` validates and returns it. Preserve elongated Conv1d depthwise workgroups where the default shape would regress GPU latency. Add end-to-end oversized linear dispatch coverage. Authored with Codex. ghstack-source-id: 421281492 @exported-using-ghexport Differential Revision: [D117706355](https://our.internmc.facebook.com/intern/diff/D117706355/)
Stack from ghstack (oldest at bottom):
Migrate dispatch, prepack, profiling, and workgroup picker interfaces to
GlobalWorkGridandLocalWorkGroup. Wrap oversized linear grids using devicelimits and validate final geometry before
vkCmdDispatch.Carry exact local geometry as
GlobalWorkGridmetadata. Cooperative andreduction grid pickers set it explicitly, while
pick_required_lwgvalidatesand returns it. Preserve elongated Conv1d depthwise workgroups where the
default shape would regress GPU latency. Add end-to-end oversized linear
dispatch coverage.
Authored with Codex.
Differential Revision: D117706355