Skip to content

[ET-VK][runtime][3/3] Enforce device-safe dispatch geometry - #22225

Merged
meta-codesync[bot] merged 3 commits into
gh/SS-JIA/605/basefrom
gh/SS-JIA/605/head
Aug 28, 2026
Merged

[ET-VK][runtime][3/3] Enforce device-safe dispatch geometry#22225
meta-codesync[bot] merged 3 commits into
gh/SS-JIA/605/basefrom
gh/SS-JIA/605/head

Conversation

@SS-JIA

@SS-JIA SS-JIA commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Stack from ghstack (oldest at bottom):

Migrate dispatch, prepack, profiling, and workgroup picker interfaces to
GlobalWorkGrid and LocalWorkGroup. Wrap oversized linear grids using device
limits and validate final geometry before vkCmdDispatch.

Carry exact local geometry as GlobalWorkGrid metadata. Cooperative and
reduction grid pickers set it explicitly, while pick_required_lwg validates
and returns it. Preserve elongated Conv1d depthwise workgroups where the
default shape would regress GPU latency. Add end-to-end oversized linear
dispatch coverage.

Authored with Codex.

Differential Revision: D117706355

[ghstack-poisoned]
@pytorch-bot

pytorch-bot Bot commented Aug 27, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22225

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Unrelated Failure

As of commit a745e5e with merge base a5f15b5 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 27, 2026
@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

[ghstack-poisoned]
SS-JIA added a commit that referenced this pull request Aug 27, 2026
Pull Request resolved: #22225

Migrate dispatch, prepack, profiling, and workgroup picker interfaces to
`GlobalWorkGrid` and `LocalWorkGroup`. Wrap oversized linear grids using device
limits and validate final geometry before `vkCmdDispatch`.

Carry exact local geometry as `GlobalWorkGrid` metadata. Cooperative and
reduction grid pickers set it explicitly, while `pick_required_lwg` validates
and returns it. Preserve elongated Conv1d depthwise workgroups where the
default shape would regress GPU latency. Add end-to-end oversized linear
dispatch coverage.

Authored with Codex.
ghstack-source-id: 420783889
@exported-using-ghexport

Differential Revision: [D117706355](https://our.internmc.facebook.com/intern/diff/D117706355/)
@SS-JIA
SS-JIA requested a review from metascroy August 27, 2026 23:21
[ghstack-poisoned]
@meta-codesync
meta-codesync Bot merged commit 9800583 into gh/SS-JIA/605/base Aug 28, 2026
191 of 195 checks passed
@meta-codesync
meta-codesync Bot deleted the gh/SS-JIA/605/head branch August 28, 2026 23:02
@meta-codesync
meta-codesync Bot deployed to cherry-pick-bot August 28, 2026 23:02 Active
SS-JIA added a commit that referenced this pull request Aug 29, 2026
Pull Request resolved: #22225

Migrate dispatch, prepack, profiling, and workgroup picker interfaces to
`GlobalWorkGrid` and `LocalWorkGroup`. Wrap oversized linear grids using device
limits and validate final geometry before `vkCmdDispatch`.

Carry exact local geometry as `GlobalWorkGrid` metadata. Cooperative and
reduction grid pickers set it explicitly, while `pick_required_lwg` validates
and returns it. Preserve elongated Conv1d depthwise workgroups where the
default shape would regress GPU latency. Add end-to-end oversized linear
dispatch coverage.

Authored with Codex.
ghstack-source-id: 421281492
@exported-using-ghexport

Differential Revision: [D117706355](https://our.internmc.facebook.com/intern/diff/D117706355/)
SS-JIA added a commit that referenced this pull request Aug 29, 2026
Pull Request resolved: #22225

Migrate dispatch, prepack, profiling, and workgroup picker interfaces to
`GlobalWorkGrid` and `LocalWorkGroup`. Wrap oversized linear grids using device
limits and validate final geometry before `vkCmdDispatch`.

Carry exact local geometry as `GlobalWorkGrid` metadata. Cooperative and
reduction grid pickers set it explicitly, while `pick_required_lwg` validates
and returns it. Preserve elongated Conv1d depthwise workgroups where the
default shape would regress GPU latency. Add end-to-end oversized linear
dispatch coverage.

Authored with Codex.
ghstack-source-id: 421281492
@exported-using-ghexport

Differential Revision: [D117706355](https://our.internmc.facebook.com/intern/diff/D117706355/)
SS-JIA added a commit that referenced this pull request Aug 29, 2026
Pull Request resolved: #22225

Migrate dispatch, prepack, profiling, and workgroup picker interfaces to
`GlobalWorkGrid` and `LocalWorkGroup`. Wrap oversized linear grids using device
limits and validate final geometry before `vkCmdDispatch`.

Carry exact local geometry as `GlobalWorkGrid` metadata. Cooperative and
reduction grid pickers set it explicitly, while `pick_required_lwg` validates
and returns it. Preserve elongated Conv1d depthwise workgroups where the
default shape would regress GPU latency. Add end-to-end oversized linear
dispatch coverage.

Authored with Codex.
ghstack-source-id: 421281492
@exported-using-ghexport

Differential Revision: [D117706355](https://our.internmc.facebook.com/intern/diff/D117706355/)
SS-JIA added a commit that referenced this pull request Aug 29, 2026
Pull Request resolved: #22225

Migrate dispatch, prepack, profiling, and workgroup picker interfaces to
`GlobalWorkGrid` and `LocalWorkGroup`. Wrap oversized linear grids using device
limits and validate final geometry before `vkCmdDispatch`.

Carry exact local geometry as `GlobalWorkGrid` metadata. Cooperative and
reduction grid pickers set it explicitly, while `pick_required_lwg` validates
and returns it. Preserve elongated Conv1d depthwise workgroups where the
default shape would regress GPU latency. Add end-to-end oversized linear
dispatch coverage.

Authored with Codex.
ghstack-source-id: 421281492
@exported-using-ghexport

Differential Revision: [D117706355](https://our.internmc.facebook.com/intern/diff/D117706355/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants