Skip to content

[ET-VK][runtime][1/3] Prepare linear shaders for 2D dispatch - #22223

Merged
meta-codesync[bot] merged 2 commits into
gh/SS-JIA/603/basefrom
gh/SS-JIA/603/head
Aug 28, 2026
Merged

[ET-VK][runtime][1/3] Prepare linear shaders for 2D dispatch#22223
meta-codesync[bot] merged 2 commits into
gh/SS-JIA/603/basefrom
gh/SS-JIA/603/head

Conversation

@SS-JIA

@SS-JIA SS-JIA commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Stack from ghstack (oldest at bottom):

Add dispatch.glslh with linear_idx_from_gid(), which flattens two-dimensional global invocation IDs. Migrate shaders whose global X coordinate represents a linear logical index. Existing one-dimensional dispatch geometry remains unchanged, making this a behavior-neutral preparation for centralized dispatch wrapping.

Authored with Codex.

Differential Revision: D117706349

[ghstack-poisoned]
@pytorch-bot

pytorch-bot Bot commented Aug 27, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22223

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Unrelated Failure

As of commit ed8a598 with merge base a5f15b5 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 27, 2026
@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

[ghstack-poisoned]
@meta-codesync
meta-codesync Bot merged commit a554791 into gh/SS-JIA/603/base Aug 28, 2026
192 of 195 checks passed
@meta-codesync
meta-codesync Bot deleted the gh/SS-JIA/603/head branch August 28, 2026 23:02
@meta-codesync
meta-codesync Bot deployed to cherry-pick-bot August 28, 2026 23:02 Active
SS-JIA added a commit that referenced this pull request Aug 29, 2026
Pull Request resolved: #22223

Add `dispatch.glslh` with `linear_idx_from_gid()`, which flattens two-dimensional global invocation IDs. Migrate shaders whose global X coordinate represents a linear logical index. Existing one-dimensional dispatch geometry remains unchanged, making this a behavior-neutral preparation for centralized dispatch wrapping.

Authored with Codex.
ghstack-source-id: 421281480
@exported-using-ghexport

Differential Revision: [D117706349](https://our.internmc.facebook.com/intern/diff/D117706349/)
SS-JIA added a commit that referenced this pull request Aug 29, 2026
Pull Request resolved: #22223

Add `dispatch.glslh` with `linear_idx_from_gid()`, which flattens two-dimensional global invocation IDs. Migrate shaders whose global X coordinate represents a linear logical index. Existing one-dimensional dispatch geometry remains unchanged, making this a behavior-neutral preparation for centralized dispatch wrapping.

Authored with Codex.
ghstack-source-id: 421281480
@exported-using-ghexport

Differential Revision: [D117706349](https://our.internmc.facebook.com/intern/diff/D117706349/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants