[ET-VK][ops] Add batch support to q8ta convolutions - #22254
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22254
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 7317611 with merge base a5f15b5 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Aug 28, 2026
This PR needs a
|
metascroy
approved these changes
Aug 28, 2026
meta-codesync
Bot
merged commit Aug 28, 2026
c9852c8
into
gh/SS-JIA/607/base
207 of 216 checks passed
SS-JIA
added a commit
that referenced
this pull request
Aug 29, 2026
Add batch-aware direct, pointwise, depthwise, and im2col q8ta convolution dispatch. Batched im2col uses an NCHW scratch tensor and batch-strided shader indexing, with conservative groups=1 high-K/small-spatial routing bounded by a 32 MiB scratch cap. Grouped and large-spatial convolutions stay on the direct path. Authored with Codex. Differential Revision: [D117869783](https://our.internmc.facebook.com/intern/diff/D117869783/) ghstack-source-id: 421281491 Pull-Request: #22254
SS-JIA
added a commit
that referenced
this pull request
Aug 29, 2026
Add batch-aware direct, pointwise, depthwise, and im2col q8ta convolution dispatch. Batched im2col uses an NCHW scratch tensor and batch-strided shader indexing, with conservative groups=1 high-K/small-spatial routing bounded by a 32 MiB scratch cap. Grouped and large-spatial convolutions stay on the direct path. Authored with Codex. Differential Revision: [D117869783](https://our.internmc.facebook.com/intern/diff/D117869783/) ghstack-source-id: 421281491 Pull-Request: #22254
SS-JIA
added a commit
that referenced
this pull request
Aug 29, 2026
Add batch-aware direct, pointwise, depthwise, and im2col q8ta convolution dispatch. Batched im2col uses an NCHW scratch tensor and batch-strided shader indexing, with conservative groups=1 high-K/small-spatial routing bounded by a 32 MiB scratch cap. Grouped and large-spatial convolutions stay on the direct path. Authored with Codex. Differential Revision: [D117869783](https://our.internmc.facebook.com/intern/diff/D117869783/) ghstack-source-id: 421281491 Pull-Request: #22254
SS-JIA
added a commit
that referenced
this pull request
Aug 29, 2026
Add batch-aware direct, pointwise, depthwise, and im2col q8ta convolution dispatch. Batched im2col uses an NCHW scratch tensor and batch-strided shader indexing, with conservative groups=1 high-K/small-spatial routing bounded by a 32 MiB scratch cap. Grouped and large-spatial convolutions stay on the direct path. Authored with Codex. Differential Revision: [D117869783](https://our.internmc.facebook.com/intern/diff/D117869783/) ghstack-source-id: 421281491 Pull-Request: #22254
SS-JIA
added a commit
that referenced
this pull request
Aug 29, 2026
Add batch-aware direct, pointwise, depthwise, and im2col q8ta convolution dispatch. Batched im2col uses an NCHW scratch tensor and batch-strided shader indexing, with conservative groups=1 high-K/small-spatial routing bounded by a 32 MiB scratch cap. Grouped and large-spatial convolutions stay on the direct path. Authored with Codex. Differential Revision: [D117869783](https://our.internmc.facebook.com/intern/diff/D117869783/) ghstack-source-id: 421281491 Pull-Request: #22254
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Add batch-aware direct, pointwise, depthwise, and im2col q8ta convolution dispatch. Batched im2col uses an NCHW scratch tensor and batch-strided shader indexing, with conservative groups=1 high-K/small-spatial routing bounded by a 32 MiB scratch cap. Grouped and large-spatial convolutions stay on the direct path. Authored with Codex.
Differential Revision: D117869783