Skip to content

[ET-VK][ops] Add batch support to q8ta convolutions - #22254

Merged
meta-codesync[bot] merged 1 commit into
gh/SS-JIA/607/basefrom
gh/SS-JIA/607/head
Aug 28, 2026
Merged

[ET-VK][ops] Add batch support to q8ta convolutions#22254
meta-codesync[bot] merged 1 commit into
gh/SS-JIA/607/basefrom
gh/SS-JIA/607/head

Conversation

@SS-JIA

@SS-JIA SS-JIA commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Stack from ghstack (oldest at bottom):

Add batch-aware direct, pointwise, depthwise, and im2col q8ta convolution dispatch. Batched im2col uses an NCHW scratch tensor and batch-strided shader indexing, with conservative groups=1 high-K/small-spatial routing bounded by a 32 MiB scratch cap. Grouped and large-spatial convolutions stay on the direct path. Authored with Codex.

Differential Revision: D117869783

[ghstack-poisoned]
@pytorch-bot

pytorch-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22254

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 7317611 with merge base a5f15b5 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-codesync
meta-codesync Bot merged commit c9852c8 into gh/SS-JIA/607/base Aug 28, 2026
207 of 216 checks passed
@meta-codesync
meta-codesync Bot deleted the gh/SS-JIA/607/head branch August 28, 2026 23:03
@meta-codesync
meta-codesync Bot deployed to cherry-pick-bot August 28, 2026 23:03 Active
SS-JIA added a commit that referenced this pull request Aug 29, 2026
Add batch-aware direct, pointwise, depthwise, and im2col q8ta convolution dispatch. Batched im2col uses an NCHW scratch tensor and batch-strided shader indexing, with conservative groups=1 high-K/small-spatial routing bounded by a 32 MiB scratch cap. Grouped and large-spatial convolutions stay on the direct path. Authored with Codex.

Differential Revision: [D117869783](https://our.internmc.facebook.com/intern/diff/D117869783/)


ghstack-source-id: 421281491
Pull-Request: #22254
SS-JIA added a commit that referenced this pull request Aug 29, 2026
Add batch-aware direct, pointwise, depthwise, and im2col q8ta convolution dispatch. Batched im2col uses an NCHW scratch tensor and batch-strided shader indexing, with conservative groups=1 high-K/small-spatial routing bounded by a 32 MiB scratch cap. Grouped and large-spatial convolutions stay on the direct path. Authored with Codex.

Differential Revision: [D117869783](https://our.internmc.facebook.com/intern/diff/D117869783/)


ghstack-source-id: 421281491
Pull-Request: #22254
SS-JIA added a commit that referenced this pull request Aug 29, 2026
Add batch-aware direct, pointwise, depthwise, and im2col q8ta convolution dispatch. Batched im2col uses an NCHW scratch tensor and batch-strided shader indexing, with conservative groups=1 high-K/small-spatial routing bounded by a 32 MiB scratch cap. Grouped and large-spatial convolutions stay on the direct path. Authored with Codex.

Differential Revision: [D117869783](https://our.internmc.facebook.com/intern/diff/D117869783/)


ghstack-source-id: 421281491
Pull-Request: #22254
SS-JIA added a commit that referenced this pull request Aug 29, 2026
Add batch-aware direct, pointwise, depthwise, and im2col q8ta convolution dispatch. Batched im2col uses an NCHW scratch tensor and batch-strided shader indexing, with conservative groups=1 high-K/small-spatial routing bounded by a 32 MiB scratch cap. Grouped and large-spatial convolutions stay on the direct path. Authored with Codex.

Differential Revision: [D117869783](https://our.internmc.facebook.com/intern/diff/D117869783/)


ghstack-source-id: 421281491
Pull-Request: #22254
SS-JIA added a commit that referenced this pull request Aug 29, 2026
Add batch-aware direct, pointwise, depthwise, and im2col q8ta convolution dispatch. Batched im2col uses an NCHW scratch tensor and batch-strided shader indexing, with conservative groups=1 high-K/small-spatial routing bounded by a 32 MiB scratch cap. Grouped and large-spatial convolutions stay on the direct path. Authored with Codex.

Differential Revision: [D117869783](https://our.internmc.facebook.com/intern/diff/D117869783/)


ghstack-source-id: 421281491
Pull-Request: #22254
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants