Stop Latest Following from ignoring hide-videos - #120
Open
Pitchfork-and-Torch wants to merge 1 commit into
Open
Conversation
This was referenced Sep 7, 2026
Closed
Closed
Author
|
Parking this intern-stack PR per operator GitHub cleanup (2026-09-08). Hunt notes remain local. Not a reject of the class. |
Author
|
Reopened. This was a serving-path hunt PR parked by mistake during the 2026-09-08 intern-stack cleanup. Not a reject of the class. Leaving it for xAI review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Latest Following copies
exclude_videosonto the query, then never hydrates video duration or runsVideoFilter.Night Owl maps hits with
..Default::default(), somin_video_duration_msstays None. Reverse-chron hydrators are TES core data, conversation ancestors, and quoted text. Filters are RT-dedup, muted keyword, and self-reply. Hide-videos is a no-op.Ranked Following goes through Phoenix, which already has
MediaInfoHydrator+VideoFilter, so the same proto flag works there.QueryBuildercopiesproto_query.exclude_videos(server.rs)VideoFilterkeeps iffmin_video_duration_ms.is_none(), gated onquery.exclude_videosReverseChronPostsPipelineconstructs no media-info client and does not wireMediaInfoHydratororVideoFilterThis is not PR 98 (Phoenix
VideoFiltermissing quoted-video duration). Reverse-chron has noQuoteHydrator. Do not intern-enableVideoFilterwithout media-info: duration stays None and every post is kept.Fix
Construct
ProdMediaInfoCacheClient(mock in tests) on reverse-chron. WireMediaInfoHydratorthenVideoFilter. Ranked Following and Phoenix are unchanged.Tests
VideoFilterdrops a native video whenexclude_videosis set, keeps a non-videoVideoFilterstays disabled when the flag is offcargo: cannot run. Public dump has no Home Mixer manifest.