Skip to content

Stop Latest Following from ignoring hide-videos - #120

Open
Pitchfork-and-Torch wants to merge 1 commit into
xai-org:mainfrom
Pitchfork-and-Torch:fix/following-hide-videos
Open

Stop Latest Following from ignoring hide-videos#120
Pitchfork-and-Torch wants to merge 1 commit into
xai-org:mainfrom
Pitchfork-and-Torch:fix/following-hide-videos

Conversation

@Pitchfork-and-Torch

Copy link
Copy Markdown

Bug

Latest Following copies exclude_videos onto the query, then never hydrates video duration or runs VideoFilter.

Night Owl maps hits with ..Default::default(), so min_video_duration_ms stays None. Reverse-chron hydrators are TES core data, conversation ancestors, and quoted text. Filters are RT-dedup, muted keyword, and self-reply. Hide-videos is a no-op.

Ranked Following goes through Phoenix, which already has MediaInfoHydrator + VideoFilter, so the same proto flag works there.

  • Entry: Following URT QueryBuilder copies proto_query.exclude_videos (server.rs)
  • Sink: VideoFilter keeps iff min_video_duration_ms.is_none(), gated on query.exclude_videos
  • Break: ReverseChronPostsPipeline constructs no media-info client and does not wire MediaInfoHydrator or VideoFilter
  • Viewer effect: user who hid videos still sees followed users' native videos on Latest Following
  • Twin: Phoenix For You / Ranked Following already hydrate duration then filter

This is not PR 98 (Phoenix VideoFilter missing quoted-video duration). Reverse-chron has no QuoteHydrator. Do not intern-enable VideoFilter without media-info: duration stays None and every post is kept.

Fix

Construct ProdMediaInfoCacheClient (mock in tests) on reverse-chron. Wire MediaInfoHydrator then VideoFilter. Ranked Following and Phoenix are unchanged.

Tests

  • Mock pipeline hydrator/filter counts include the new pair (fails on unmodified main)
  • Media-info then VideoFilter drops a native video when exclude_videos is set, keeps a non-video
  • VideoFilter stays disabled when the flag is off

cargo: cannot run. Public dump has no Home Mixer manifest.

@Pitchfork-and-Torch

Copy link
Copy Markdown
Author

Parking this intern-stack PR per operator GitHub cleanup (2026-09-08). Hunt notes remain local. Not a reject of the class.

@Pitchfork-and-Torch

Copy link
Copy Markdown
Author

Reopened. This was a serving-path hunt PR parked by mistake during the 2026-09-08 intern-stack cleanup. Not a reject of the class. Leaving it for xAI review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant