Stop CoreData from keeping a stale source author_id after TES - #131
Open
Pitchfork-and-Torch wants to merge 1 commit into
Open
Conversation
cursor
Bot
force-pushed
the
cursor/tes-author-overwrite-in-network-a4ef
branch
from
September 7, 2026 04:22
daaba32 to
172c429
Compare
This was referenced Sep 7, 2026
xai-org#128 runs InNetwork after CoreData so TES can fill author_id. CoreData only wrote author_id when the source field was 0. Phoenix and Thunder ship a nonzero id. TES ran and was discarded. InNetwork stamped the source id. A followed TES author then hit TimelineHomeRecommendations. NSFW HP / gore / card Recs-drop; the same labels are interstitial on TimelineHome. TES author now overwrites a nonzero source id. TES miss still keeps source.
Pitchfork-and-Torch
force-pushed
the
cursor/tes-author-overwrite-in-network-a4ef
branch
from
September 8, 2026 23:12
172c429 to
902a06f
Compare
Author
|
Parking this intern-stack PR per operator GitHub cleanup (2026-09-08). Hunt notes remain local. Not a reject of the class. |
Author
|
Reopened. This was a serving-path hunt PR parked by mistake during the 2026-09-08 intern-stack cleanup. Not a reject of the class. Leaving it for xAI review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
#128 runs InNetwork after CoreData so TES can fill
author_id. CoreDataupdateonly wroteauthor_idwhen the source field was already 0.Phoenix (and Thunder) ship a nonzero
author_id. TES still runs (text is empty, soalready_hydratedis false). The TES author is discarded. InNetwork stamps the source id.A followed TES author is then fetched at
TimelineHomeRecommendations. Recs-only Drop fires for tweetNSFW_HIGH_PRECISION,GORE_AND_VIOLENCE_HIGH_PRECISION, andNSFW_CARD_IMAGE. The same labels on Home are Interstitial (NSFW_MEDIA_INTERSTITIALS).CoreDataCandidateHydrator::updatefill-if-zeroVFCandidateHydrator(in_network.unwrap_or(false)→ Recs) thenVFFilterretweeted_tweet_id/retweeted_user_idfrom TES already overwrite the sourceThis is not rewriting Recs-only policy. This is not #128 (order). This is not #119 (RT wrapper primary id). This is not #115 (Following quotes).
Fix
When TES returns a nonzero author, write it. TES miss still keeps the source author.
Tests
author_id = 0, TES42→4299, TES42→420) keeps source42(followed) then InNetwork →in_network = true99without TES overwrite still stamps OONStandalone decision-table harness (same predicate): 6 assertions passed.
cargo testcannot run here. Public dump has no Home Mixer manifest.Leftover
already_hydratedstill skips TES when sourceauthor_id != 0and text is nonempty.InNetworkCandidateHydrator.enableis still!has_cached_posts.